Reland "Extract InspectorInjectedScriptManager from InspectorPageAgent" [chromium/src : main]
1 view
Skip to first unread message
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
May 1, 2026, 6:36:22 PM (3 days ago) May 1
to Andrey Kosyakov, luci-bi...@appspot.gserviceaccount.com, Dmitry Gozman, Chromium LUCI CQ, Victor Tan, Scott Haseley, Alex Rudenko, android-bu...@system.gserviceaccount.com, AI Code Reviewer, chromium...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org
Attention needed from Alex Rudenko, Dmitry Gozman, Scott Haseley and Victor Tan
rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Alex Rudenko
- Dmitry Gozman
- Scott Haseley
- Victor Tan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
May 1, 2026, 6:41:18 PM (3 days ago) May 1
to Andrey Kosyakov, luci-bi...@appspot.gserviceaccount.com, Dmitry Gozman, Chromium LUCI CQ, Victor Tan, Scott Haseley, Alex Rudenko, android-bu...@system.gserviceaccount.com, AI Code Reviewer, chromium...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org
Attention needed from Alex Rudenko, Dmitry Gozman, Scott Haseley and Victor Tan
Message from rubber-...@appspot.gserviceaccount.com![]( "Open in Gerrit")
Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.
Related details
Attention is currently required from:
- Alex Rudenko
- Dmitry Gozman
- Scott Haseley
- Victor Tan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitry Gozman (Gerrit)
May 2, 2026, 4:39:04 AM (2 days ago) May 2
to Andrey Kosyakov, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Victor Tan, Scott Haseley, Alex Rudenko, android-bu...@system.gserviceaccount.com, AI Code Reviewer, chromium...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org
Attention needed from Alex Rudenko, Andrey Kosyakov, Scott Haseley and Victor Tan
Dmitry Gozman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Rudenko
- Andrey Kosyakov
- Scott Haseley
- Victor Tan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
2:27 AM (13 hours ago) 2:27 AM
to Andrey Kosyakov, Dmitry Gozman, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Victor Tan, Scott Haseley, android-bu...@system.gserviceaccount.com, AI Code Reviewer, chromium...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org
Attention needed from Andrey Kosyakov, Scott Haseley and Victor Tan
Alex Rudenko added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/inspector/inspector_page_agent.cc
Line 1980, Patchset 2 (Latest):
injected_script_manager_ = nullptr;Alex Rudenko . unresolved
Is it possible that this would gc the injected script manager (as expected), destroying the fields it creates and leaving the dangling pointers to the injected script manager in the inspector state?
Related details
Attention is currently required from:
- Andrey Kosyakov
- Scott Haseley
- Victor Tan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
12:39 PM (3 hours ago) 12:39 PM
to Dmitry Gozman, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Victor Tan, Scott Haseley, Alex Rudenko, android-bu...@system.gserviceaccount.com, AI Code Reviewer, chromium...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org
Attention needed from Alex Rudenko, Scott Haseley and Victor Tan
Andrey Kosyakov added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/inspector/inspector_page_agent.cc
Line 1980, Patchset 2 (Latest):
injected_script_manager_ = nullptr;Alex Rudenko . unresolved
Is it possible that this would gc the injected script manager (as expected), destroying the fields it creates and leaving the dangling pointers to the injected script manager in the inspector state?
Andrey Kosyakov
That's a good catch. I don't think this is practically significant because we wouldn't touch any of the fields after Dispose(), but let me take care of this just in case.
Related details
Attention is currently required from:
- Alex Rudenko
- Scott Haseley
- Victor Tan
Reply all
Reply to author
Forward
0 new messages