Implement description for Actions that need RequestApproved [devtools/devtools-frontend : main]

0 views

Skip to first unread message

Nikolay Vitkov (Gerrit)

unread,

10:46 AM (4 hours ago) 10:46 AM

to Jack Franklin, Alex Rudenko, devtools-rev...@chromium.org

Attention needed from Alex Rudenko and Jack Franklin

Nikolay Vitkov voted and added 2 comments

Votes added by Nikolay Vitkov

Auto-Submit	+1
Commit-Queue	+1

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Nikolay Vitkov . resolved

PTAL - I refactored the code so it's more inline with the current nomenclature.

File front_end/models/ai_assistance/agents/AiAgent.ts

Line 87, Patchset 1 (Latest): description: string|null;

Nikolay Vitkov . unresolved

We use `null` to explicitly tell we don't want a description.
Prevents cases where one forgot to add it due to it being optional.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Jack Franklin

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

12:10 PM (3 hours ago) 12:10 PM

to Nikolay Vitkov, Devtools-frontend LUCI CQ, Jack Franklin, devtools-rev...@chromium.org

Attention needed from Jack Franklin and Nikolay Vitkov

Alex Rudenko voted Code-Review+1

Code-Review