[DebugUITabStrip] TabStripInternals UI state storage [chromium/src : main]
Brijesh Giri (Gerrit)
Brijesh Giri added 2 comments![]( "Open in Gerrit")
private handleDividerKeydown_(e: KeyboardEvent) {Brijesh GiriI wonder what should be a good place to explain the keyboard shortcuts used for resizing, along with other ways of interacting with the UI?
As of now, the only keyboard shortcuts supported are to move the divider of our split pane to the left or to the right via keyboard, assuming it is the currently selected element.
In future, we could potentially document it with an information icon that lets the user know about all the available shortcuts, in-case we do end-up adding more.
However, given that our UI is just a read-only view, I do not forsee us adding more shortcuts. Please let me know in-case my assumption is incorrect.
observer(change);Brijesh Girisame comment as the previous CL, this is essentially a callback being run, not a Observer class.
Have updated it.
Related details
- Atharv Maan
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brijesh Giri (Gerrit)
Brijesh Giri added 1 comment![]( "Open in Gerrit")
private handleDividerKeydown_(e: KeyboardEvent) {Brijesh GiriI wonder what should be a good place to explain the keyboard shortcuts used for resizing, along with other ways of interacting with the UI?
As of now, the only keyboard shortcuts supported are to move the divider of our split pane to the left or to the right via keyboard, assuming it is the currently selected element.
In future, we could potentially document it with an information icon that lets the user know about all the available shortcuts, in-case we do end-up adding more.
However, given that our UI is just a read-only view, I do not forsee us adding more shortcuts. Please let me know in-case my assumption is incorrect.
Done
Related details
- Atharv Maan
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brijesh Giri (Gerrit)
Brijesh Giri added 1 comment![]( "Open in Gerrit")
localStorage.setItem(Is it okay to use localStorage in this manner?
Related details
- Atharv Maan
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brijesh Giri (Gerrit)
Brijesh Giri added 1 comment![]( "Open in Gerrit")
localStorage.setItem(Is it okay to use localStorage in this manner?
Done
Related details
- Atharv Maan
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Darryl James voted Code-Review+1![]( "Open in Gerrit")
- Atharv Maan
- Brijesh Giri
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Atharv Maan (Gerrit)
Atharv Maan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Brijesh Giri
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[DebugUITabStrip] TabStripInternals UI state storage
This CL introduces Phase 3 of the 'tab-strip-internals' page, a debug
WebUI intended to visualize the live state of the TabStrip model.
Changes:
- Updated `tab_strip_internals_view.ts` to add event listeners
for resizing the left/right pane
- Updated `tab_strip_internals_viewmodel.ts` to add support for
savinga and restoring UI state from local storage
- Updated `tab-strip-internals.html` with new CSS styles
Project doc:
https://docs.google.com/document/d/1EKJicM4grBpp2nA4SOPzUvsKVLa_Ndj5L0HrIsGJNUI
- M chrome/browser/resources/tab_strip_internals/tab_strip_internals.html
- M chrome/browser/resources/tab_strip_internals/tab_strip_internals_view.ts
- M chrome/browser/resources/tab_strip_internals/tab_strip_internals_viewmodel.ts
Code-Review: +1 by Darryl James, +1 by Atharv Maan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |