[RecordReplay] Refine database seeding with error logging and comments [chromium/src : main]
0 views
Skip to first unread message
Friedrich Hauser (Gerrit)
12:44 PM (3 hours ago) 12:44 PM
to Adem Derinel, Andrew Rayskiy, James Maclean, Khushal Sagar, CJ DiMeglio, Avi Drissman, Kevin Babbitt, Olga Gerchikov, Henrique Ferreiro, Moe Adel, Thorsten Kober, Fredrik Söderquist, Sean Maher, Michael Moss, Peter Williamson, Simon Hangl, Enterprise Policy Reviews, Stephen Chenney, Heron Yang, Zewen Li, Daniel Cheng, Rijubrata Bhaumik, Menard, Alexis, Tommy Li, Thiabaud Engelbrecht, Ilya Biryukov, Anurag Simgeker, Kevin McNee, Ryan Sultanem, Sadrul Chowdhury, Peter Beverloo, Kenneth Rohde Christiansen, Hu, Ningxin, Raphael Kubo da Costa, Zijie He, Christian Biesinger, Mangesh Ghiware, Chromium Metrics Reviews, Ian Vollick, Linyu He, Jerome Jiang, Hongchan Choi, Dirk Schulze, Neil Coronado, Hans Wennborg, James Su, Javier Fernandez, Sinan Sahin, (Julie)Jeongeun Kim, Shu Yang, Lei Zhang, Nikhil Nayunigari, Nico Weber, Jiewei Qian, srirama chandra sekhar, Nate Chapin, Mirko Bonadei, Kentaro Hara, Charles Hager, Peter Collingbourne, Reid Kleckner, Mark Schillaci, Xida Chen, Luna Lu, Hiroki Nakagawa, android-bu...@system.gserviceaccount.com, AyeAye Python Dispatcher, Chromium LUCI CQ, chromium...@chromium.org, chromium-...@engflow.com, francisjp...@google.com, iclella...@chromium.org, kenjibah...@chromium.org, tranbaod...@chromium.org, vaapi-...@chromium.org, vasilii+watchlis...@chromium.org, lens-chrome...@google.com, mac-r...@chromium.org, katie...@chromium.org, cwp-review...@google.com, estali...@chromium.org, network-ser...@chromium.org, siyua+aut...@chromium.org, dullweb...@chromium.org, mreichhoff+watc...@chromium.org, stevenjb+wa...@chromium.org, hashimo...@chromium.org, xiangdongkong+...@google.com, ashleynewson+w...@chromium.org, shimazu...@chromium.org, cros-essential...@chromium.org, yhanada...@chromium.org, csharrison+...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, lucasrada...@google.com, headless...@chromium.org, gcasto+w...@chromium.org, ios-r...@chromium.org, gavinp...@chromium.org, chfreme...@chromium.org, eme-r...@chromium.org, ajayramamurt...@google.com, chungshe...@google.com, kinuko...@chromium.org, toshikikikuchi+...@chromium.org, chadduffin+wa...@chromium.org, feature-me...@chromium.org, sloboda...@chromium.org, jonmann+watc...@chromium.org, lizeb+watch...@chromium.org, joeantonetti+...@google.com, mercer...@google.com, max+watc...@igalia.com, mgiuca...@chromium.org, chikamu...@chromium.org, bling-ai-foundatio...@google.com, oshima...@chromium.org, servicewor...@chromium.org, nona+...@chromium.org, filesapp...@chromium.org, armalhotra+a...@google.com, cros-print...@google.com, chlily...@chromium.org, blink-re...@chromium.org, print-revi...@chromium.org, navigation...@chromium.org, hidehik...@chromium.org, blink-reviews-p...@chromium.org, ender...@chromium.org, ios-rev...@chromium.org, chrome-tab-group-en...@google.com, accessibility-a...@google.com, jz...@chromium.org, petewi...@chromium.org, tgupta...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, fmalit...@chromium.org, arthursonzog...@chromium.org, thefro...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, alexmt...@chromium.org, browser-comp...@chromium.org, ortuno...@chromium.org, glider...@chromium.org, core-timi...@chromium.org, nicolas...@chromium.org, chrome-regionalc...@google.com, yhanad...@chromium.org, ayman...@chromium.org, jackshira+...@google.com, ydago...@chromium.org, wychen...@chromium.org, lizeb...@chromium.org, ejcaruso+wa...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, ajayramamurthy+w...@google.com, crisrael+wa...@google.com, asvitkine...@chromium.org, ios-revie...@chromium.org, cblume...@chromium.org, kouhe...@chromium.org, nikhilcn+wat...@google.com, odejesu...@chromium.org, rsleev...@chromium.org, tluk+...@chromium.org, language...@chromium.org, loyso...@chromium.org, csharris...@chromium.org, vinnypersky+...@google.com, gavin...@chromium.org, gangwu...@chromium.org, webauthn...@chromium.org, jackshira+w...@google.com, martijn...@martijnc.be, crost...@chromium.org, omnibox-...@chromium.org, chromiumme...@microsoft.com, jdeblas...@chromium.org, chromotin...@chromium.org, scheduler-...@chromium.org, dmurph+watch...@chromium.org, twifka...@chromium.org, ashleydp+fe...@google.com, chromeos-ca...@google.com, dibyapal+wa...@chromium.org, permissio...@chromium.org, mfoltz+wa...@chromium.org, nyquis...@chromium.org, cros-ed...@google.com, crisrael+...@google.com, asvitki...@chromium.org, phoglun...@chromium.org, blink-re...@chromium.org, chrome-b...@google.com, titoua...@chromium.org, khorimoto+w...@chromium.org, penghu...@chromium.org, blink-revie...@chromium.org, mattsimm...@chromium.org, gab+...@chromium.org, ios-web-view...@google.com, suetfei+wa...@google.com, enne...@chromium.org, speed-metr...@chromium.org, jackshira+wa...@google.com, eic+...@google.com, khorimoto+wa...@chromium.org, kinuko+ser...@chromium.org, shend...@chromium.org, bmcquad...@chromium.org, fserb...@chromium.org, sky+...@chromium.org, shannc...@chromium.org, mfoltz+wa...@chromium.org, cblum...@chromium.org, droger+w...@chromium.org, drott...@chromium.org, hansenmichael...@google.com, blink-revie...@chromium.org, shimazu+se...@chromium.org, npm+...@chromium.org, jonmann+wa...@chromium.org, devtools...@chromium.org, knollr+wat...@chromium.org, iwells...@chromium.org, mek+w...@chromium.org, jackshira+w...@google.com, grt+...@chromium.org, dmurph+wat...@chromium.org, shgar+aut...@google.com, geoffla...@chromium.org, ajayramamurth...@google.com, dbaro...@chromium.org, creis...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, ozone-...@chromium.org, web-schedulin...@chromium.org, dmurph+watchi...@chromium.org, hansberry+wa...@chromium.org, mar...@chromium.org, print-rev...@chromium.org, polard...@google.com, harringt...@chromium.org, fgal...@chromium.org, shuche...@chromium.org, aleventh...@chromium.org, dfried...@chromium.org, cwalle...@chromium.org, ramyagopa...@google.com, dom+...@chromium.org, marinacio...@chromium.org, rainhar...@chromium.org, net-r...@chromium.org, yongshun+...@google.com, jasonrobe...@google.com, christia...@chromium.org, jbroma...@chromium.org, kuragin+web-ap...@chromium.org, tburkar...@chromium.org, torne...@chromium.org, android-web...@chromium.org, longbowei+fe...@google.com, kyungjunle...@google.com, blink-work...@chromium.org, crmulli...@chromium.org, gfhuan...@chromium.org, alexmit...@chromium.org, dgroga...@chromium.org, caitkp...@chromium.org, hsuregan+wa...@chromium.org, ukai+...@chromium.org, pkotwic...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, core-web-vita...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, loading...@chromium.org, nektar...@chromium.org, security-...@chromium.org, wangdanny+fe...@google.com, dmurph+watchin...@chromium.org, pushi+wat...@google.com, steimel+...@chromium.org, blink-rev...@chromium.org, jiajunz+wat...@google.com, webapks-...@chromium.org, fenced-fra...@chromium.org, bnc+...@chromium.org, jatapiaro+wat...@google.com, blink-re...@chromium.org, chasej...@chromium.org, ckitaga...@chromium.org, japhet+...@chromium.org, mickeybu...@chromium.org, dtseng...@chromium.org, xinghui...@chromium.org, pdr+svgw...@chromium.org, pushi+wa...@google.com, josiah...@chromium.org, cc-...@chromium.org, ddrone...@google.com, prerenderi...@chromium.org, byronle...@chromium.org, nickdiego+wa...@igalia.com, moqati-team+chr...@google.com, chromeos-gfx-...@google.com, philli...@chromium.org, wnwen...@chromium.org, blink-rev...@chromium.org, ntp-dev...@chromium.org, drott+bl...@chromium.org, hsuregan+wat...@chromium.org, media-wi...@chromium.org, chrome-gr...@chromium.org, chrome-intelligence-te...@google.com, jorgel...@chromium.org, keithle...@chromium.org, johnche...@chromium.org, blink-re...@chromium.org, eugeni...@chromium.org, ffred...@chromium.org, xlythe+wa...@google.com, rginda...@chromium.org, media-cro...@chromium.org, subresource-f...@chromium.org, mdjone...@chromium.org, storage...@chromium.org, blink-rev...@chromium.org, gogeral...@chromium.org, yyhyyh+fee...@google.com, michaelcheco+watch-i...@google.com, kainin...@chromium.org, dominicc+...@chromium.org, msrame...@chromium.org, telemetr...@chromium.org, mbarowsky+watc...@chromium.org, tbarzi...@chromium.org, cros-setti...@google.com, loading-re...@chromium.org, dtseng+c...@chromium.org, aashna...@google.com, dewitt...@chromium.org, jiajunz+wa...@google.com, jackshira+wa...@google.com, blink-revi...@chromium.org, fuchsia...@chromium.org, kinuko...@chromium.org, antoniosarto...@chromium.org, mfoltz+wa...@chromium.org, tracing...@chromium.org, mkwst+w...@chromium.org, dcheng+c...@chromium.org, yuzo+...@chromium.org, jackshira+wat...@google.com, zol...@webkit.org, gavinp...@chromium.org, cfredri...@chromium.org, translat...@chromium.org, roagarw...@chromium.org, xiaochen...@chromium.org, blink-revie...@chromium.org, fdoray...@chromium.org, emircan+watch...@chromium.org, weiluanw...@google.com, srahim...@chromium.org, jshin...@chromium.org, croissant-...@chromium.org, meilian...@chromium.org, loading-rev...@chromium.org, michaelchec...@google.com, davidj...@chromium.org, dmurph+watching...@chromium.org, arc-review...@google.com, ajayramamurthy...@google.com, roblia...@chromium.org, jonmann+wat...@chromium.org, dclasson+w...@google.com, rayanka...@chromium.org, stanfie...@google.com, crostin...@chromium.org, dtraino...@chromium.org, niharm...@google.com, dennyh...@google.com, video-networking...@google.com, rmcelra...@chromium.org, jonmann+w...@chromium.org, yfriedm...@chromium.org, vakh+safe_br...@chromium.org, jdonnel...@chromium.org, ajwong...@chromium.org, speed-metrics...@chromium.org, peilinwa...@google.com, dtapuska+ch...@chromium.org, lwinston+watc...@google.com, yhanada+...@chromium.org, hiroshig...@chromium.org, chadduffin+w...@chromium.org, hansberry+wat...@chromium.org, wfh+...@chromium.org, performance-m...@chromium.org, chromium-a...@chromium.org, halliwe...@chromium.org, hirokisa...@chromium.org, bfcach...@chromium.org, cbe-cep-eng...@google.com, wangdanny+watch-in...@google.com, cblume+im...@chromium.org, penghuan...@chromium.org, yyhyyh+watch-inpu...@google.com, crisrael+w...@google.com, dmurph+wa...@chromium.org, yigu+...@chromium.org, abigailbk...@google.com, mattreyno...@chromium.org, jmedle...@chromium.org, marq+...@chromium.org, jophba...@chromium.org, joeantonetti+wa...@google.com, olka+...@chromium.org, thegreenf...@chromium.org, trewin...@google.com, yusufo...@chromium.org, menghua...@google.com, rkgibso...@chromium.org, tmartino+tran...@chromium.org, hansberry+wa...@chromium.org, jbauma...@chromium.org, schedule...@chromium.org, chrome-intell...@chromium.org, jeffreycohen+watc...@chromium.org, alexmo...@chromium.org, pdf-r...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, chromeos-kio...@google.com, zelin+watch-we...@chromium.org, hais+wat...@google.com, loading-rev...@chromium.org, dmurph+watc...@chromium.org, scheduler...@chromium.org, anastas...@google.com, jessemcke...@google.com, mpdento...@chromium.org, mcasas+med...@chromium.org, yuezhang...@chromium.org, horo+...@chromium.org, rrsilva+wat...@google.com, jkeitel+watch-...@google.com, agriev...@chromium.org, mtomas...@chromium.org, hansberry+w...@chromium.org, blink-revi...@chromium.org, edgesto...@microsoft.com, donnd...@chromium.org, apavlo...@chromium.org, pasko...@chromium.org, hanxi...@chromium.org, kinuko+...@chromium.org, oilpan-rev...@chromium.org, rhalava...@chromium.org, eric.c...@apple.com, pushi+watc...@google.com, kouhe...@chromium.org, siashah+au...@chromium.org, twelling...@chromium.org, apaselti...@chromium.org, derinel+wat...@google.com, zackha...@chromium.org, tommyw+w...@chromium.org, gbb-cct...@google.com, spang...@chromium.org, feature-v...@chromium.org, kouhei...@chromium.org
Attention needed from Adem Derinel
Friedrich Hauser added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Friedrich Hauser . resolved
Hi Adem,
Would you please take a look?
Related details
Attention is currently required from:
- Adem Derinel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Moe Adel (Gerrit)
1:49 PM (2 hours ago) 1:49 PM
to Friedrich Hauser, Adem Derinel, Andrew Rayskiy, James Maclean, Khushal Sagar, CJ DiMeglio, Avi Drissman, Kevin Babbitt, Olga Gerchikov, Henrique Ferreiro, Thorsten Kober, Fredrik Söderquist, Sean Maher, Michael Moss, Peter Williamson, Simon Hangl, Enterprise Policy Reviews, Stephen Chenney, Heron Yang, Zewen Li, Daniel Cheng, Rijubrata Bhaumik, Menard, Alexis, Tommy Li, Thiabaud Engelbrecht, Ilya Biryukov, Anurag Simgeker, Kevin McNee, Ryan Sultanem, Sadrul Chowdhury, Peter Beverloo, Kenneth Rohde Christiansen, Hu, Ningxin, Raphael Kubo da Costa, Zijie He, Christian Biesinger, Mangesh Ghiware, Chromium Metrics Reviews, Ian Vollick, Linyu He, Jerome Jiang, Hongchan Choi, Dirk Schulze, Neil Coronado, Hans Wennborg, James Su, Javier Fernandez, Sinan Sahin, (Julie)Jeongeun Kim, Shu Yang, Lei Zhang, Nikhil Nayunigari, Nico Weber, Jiewei Qian, srirama chandra sekhar, Nate Chapin, Mirko Bonadei, Kentaro Hara, Charles Hager, Peter Collingbourne, Reid Kleckner, Mark Schillaci, Xida Chen, Luna Lu, Hiroki Nakagawa, android-bu...@system.gserviceaccount.com, AyeAye Python Dispatcher, Chromium LUCI CQ, chromium...@chromium.org, chromium-...@engflow.com, francisjp...@google.com, iclella...@chromium.org, kenjibah...@chromium.org, tranbaod...@chromium.org, vaapi-...@chromium.org, vasilii+watchlis...@chromium.org, lens-chrome...@google.com, mac-r...@chromium.org, katie...@chromium.org, cwp-review...@google.com, estali...@chromium.org, network-ser...@chromium.org, siyua+aut...@chromium.org, dullweb...@chromium.org, mreichhoff+watc...@chromium.org, stevenjb+wa...@chromium.org, hashimo...@chromium.org, xiangdongkong+...@google.com, ashleynewson+w...@chromium.org, shimazu...@chromium.org, cros-essential...@chromium.org, yhanada...@chromium.org, csharrison+...@chromium.org, gavin...@chromium.org, hayato...@chromium.org, lucasrada...@google.com, headless...@chromium.org, gcasto+w...@chromium.org, ios-r...@chromium.org, gavinp...@chromium.org, chfreme...@chromium.org, eme-r...@chromium.org, ajayramamurt...@google.com, chungshe...@google.com, kinuko...@chromium.org, toshikikikuchi+...@chromium.org, chadduffin+wa...@chromium.org, feature-me...@chromium.org, sloboda...@chromium.org, jonmann+watc...@chromium.org, lizeb+watch...@chromium.org, joeantonetti+...@google.com, mercer...@google.com, max+watc...@igalia.com, mgiuca...@chromium.org, chikamu...@chromium.org, bling-ai-foundatio...@google.com, oshima...@chromium.org, servicewor...@chromium.org, nona+...@chromium.org, filesapp...@chromium.org, armalhotra+a...@google.com, cros-print...@google.com, chlily...@chromium.org, blink-re...@chromium.org, print-revi...@chromium.org, navigation...@chromium.org, hidehik...@chromium.org, blink-reviews-p...@chromium.org, ender...@chromium.org, ios-rev...@chromium.org, chrome-tab-group-en...@google.com, accessibility-a...@google.com, jz...@chromium.org, petewi...@chromium.org, tgupta...@chromium.org, andysjl...@chromium.org, nwoked...@chromium.org, fmalit...@chromium.org, arthursonzog...@chromium.org, thefro...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, alexmt...@chromium.org, browser-comp...@chromium.org, ortuno...@chromium.org, glider...@chromium.org, core-timi...@chromium.org, nicolas...@chromium.org, chrome-regionalc...@google.com, yhanad...@chromium.org, ayman...@chromium.org, jackshira+...@google.com, ydago...@chromium.org, wychen...@chromium.org, lizeb...@chromium.org, ejcaruso+wa...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, ajayramamurthy+w...@google.com, crisrael+wa...@google.com, asvitkine...@chromium.org, ios-revie...@chromium.org, cblume...@chromium.org, kouhe...@chromium.org, nikhilcn+wat...@google.com, odejesu...@chromium.org, rsleev...@chromium.org, tluk+...@chromium.org, language...@chromium.org, loyso...@chromium.org, csharris...@chromium.org, vinnypersky+...@google.com, gavin...@chromium.org, gangwu...@chromium.org, webauthn...@chromium.org, jackshira+w...@google.com, martijn...@martijnc.be, crost...@chromium.org, omnibox-...@chromium.org, chromiumme...@microsoft.com, jdeblas...@chromium.org, chromotin...@chromium.org, scheduler-...@chromium.org, dmurph+watch...@chromium.org, twifka...@chromium.org, ashleydp+fe...@google.com, chromeos-ca...@google.com, dibyapal+wa...@chromium.org, permissio...@chromium.org, mfoltz+wa...@chromium.org, nyquis...@chromium.org, cros-ed...@google.com, crisrael+...@google.com, asvitki...@chromium.org, phoglun...@chromium.org, blink-re...@chromium.org, chrome-b...@google.com, titoua...@chromium.org, khorimoto+w...@chromium.org, penghu...@chromium.org, blink-revie...@chromium.org, mattsimm...@chromium.org, gab+...@chromium.org, ios-web-view...@google.com, suetfei+wa...@google.com, enne...@chromium.org, speed-metr...@chromium.org, jackshira+wa...@google.com, eic+...@google.com, khorimoto+wa...@chromium.org, kinuko+ser...@chromium.org, shend...@chromium.org, bmcquad...@chromium.org, fserb...@chromium.org, sky+...@chromium.org, shannc...@chromium.org, mfoltz+wa...@chromium.org, cblum...@chromium.org, droger+w...@chromium.org, drott...@chromium.org, hansenmichael...@google.com, blink-revie...@chromium.org, shimazu+se...@chromium.org, npm+...@chromium.org, jonmann+wa...@chromium.org, devtools...@chromium.org, knollr+wat...@chromium.org, iwells...@chromium.org, mek+w...@chromium.org, jackshira+w...@google.com, grt+...@chromium.org, dmurph+wat...@chromium.org, shgar+aut...@google.com, geoffla...@chromium.org, ajayramamurth...@google.com, dbaro...@chromium.org, creis...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, ozone-...@chromium.org, web-schedulin...@chromium.org, dmurph+watchi...@chromium.org, hansberry+wa...@chromium.org, mar...@chromium.org, print-rev...@chromium.org, polard...@google.com, harringt...@chromium.org, fgal...@chromium.org, shuche...@chromium.org, aleventh...@chromium.org, dfried...@chromium.org, cwalle...@chromium.org, ramyagopa...@google.com, dom+...@chromium.org, marinacio...@chromium.org, rainhar...@chromium.org, net-r...@chromium.org, yongshun+...@google.com, jasonrobe...@google.com, christia...@chromium.org, jbroma...@chromium.org, kuragin+web-ap...@chromium.org, tburkar...@chromium.org, torne...@chromium.org, android-web...@chromium.org, longbowei+fe...@google.com, kyungjunle...@google.com, blink-work...@chromium.org, crmulli...@chromium.org, gfhuan...@chromium.org, alexmit...@chromium.org, dgroga...@chromium.org, caitkp...@chromium.org, hsuregan+wa...@chromium.org, ukai+...@chromium.org, pkotwic...@chromium.org, osaul+aut...@google.com, rsesek...@chromium.org, core-web-vita...@chromium.org, yhanada+...@chromium.org, pmonett...@chromium.org, loading...@chromium.org, nektar...@chromium.org, security-...@chromium.org, wangdanny+fe...@google.com, dmurph+watchin...@chromium.org, pushi+wat...@google.com, steimel+...@chromium.org, blink-rev...@chromium.org, jiajunz+wat...@google.com, webapks-...@chromium.org, fenced-fra...@chromium.org, bnc+...@chromium.org, jatapiaro+wat...@google.com, blink-re...@chromium.org, chasej...@chromium.org, ckitaga...@chromium.org, japhet+...@chromium.org, mickeybu...@chromium.org, dtseng...@chromium.org, xinghui...@chromium.org, pdr+svgw...@chromium.org, pushi+wa...@google.com, josiah...@chromium.org, cc-...@chromium.org, ddrone...@google.com, prerenderi...@chromium.org, byronle...@chromium.org, nickdiego+wa...@igalia.com, moqati-team+chr...@google.com, chromeos-gfx-...@google.com, philli...@chromium.org, wnwen...@chromium.org, blink-rev...@chromium.org, ntp-dev...@chromium.org, drott+bl...@chromium.org, hsuregan+wat...@chromium.org, media-wi...@chromium.org, chrome-gr...@chromium.org, chrome-intelligence-te...@google.com, jorgel...@chromium.org, keithle...@chromium.org, johnche...@chromium.org, blink-re...@chromium.org, eugeni...@chromium.org, ffred...@chromium.org, xlythe+wa...@google.com, rginda...@chromium.org, media-cro...@chromium.org, subresource-f...@chromium.org, mdjone...@chromium.org, storage...@chromium.org, blink-rev...@chromium.org, gogeral...@chromium.org, yyhyyh+fee...@google.com, michaelcheco+watch-i...@google.com, kainin...@chromium.org, dominicc+...@chromium.org, msrame...@chromium.org, telemetr...@chromium.org, mbarowsky+watc...@chromium.org, tbarzi...@chromium.org, cros-setti...@google.com, loading-re...@chromium.org, dtseng+c...@chromium.org, aashna...@google.com, dewitt...@chromium.org, jiajunz+wa...@google.com, jackshira+wa...@google.com, blink-revi...@chromium.org, fuchsia...@chromium.org, kinuko...@chromium.org, antoniosarto...@chromium.org, mfoltz+wa...@chromium.org, tracing...@chromium.org, mkwst+w...@chromium.org, dcheng+c...@chromium.org, yuzo+...@chromium.org, jackshira+wat...@google.com, zol...@webkit.org, gavinp...@chromium.org, cfredri...@chromium.org, translat...@chromium.org, roagarw...@chromium.org, xiaochen...@chromium.org, blink-revie...@chromium.org, fdoray...@chromium.org, emircan+watch...@chromium.org, weiluanw...@google.com, srahim...@chromium.org, jshin...@chromium.org, croissant-...@chromium.org, meilian...@chromium.org, loading-rev...@chromium.org, michaelchec...@google.com, davidj...@chromium.org, dmurph+watching...@chromium.org, arc-review...@google.com, ajayramamurthy...@google.com, roblia...@chromium.org, jonmann+wat...@chromium.org, dclasson+w...@google.com, rayanka...@chromium.org, stanfie...@google.com, crostin...@chromium.org, dtraino...@chromium.org, niharm...@google.com, dennyh...@google.com, video-networking...@google.com, rmcelra...@chromium.org, jonmann+w...@chromium.org, yfriedm...@chromium.org, vakh+safe_br...@chromium.org, jdonnel...@chromium.org, ajwong...@chromium.org, speed-metrics...@chromium.org, peilinwa...@google.com, dtapuska+ch...@chromium.org, lwinston+watc...@google.com, yhanada+...@chromium.org, hiroshig...@chromium.org, chadduffin+w...@chromium.org, hansberry+wat...@chromium.org, wfh+...@chromium.org, performance-m...@chromium.org, chromium-a...@chromium.org, halliwe...@chromium.org, hirokisa...@chromium.org, bfcach...@chromium.org, cbe-cep-eng...@google.com, wangdanny+watch-in...@google.com, cblume+im...@chromium.org, penghuan...@chromium.org, yyhyyh+watch-inpu...@google.com, crisrael+w...@google.com, dmurph+wa...@chromium.org, yigu+...@chromium.org, abigailbk...@google.com, mattreyno...@chromium.org, jmedle...@chromium.org, marq+...@chromium.org, jophba...@chromium.org, joeantonetti+wa...@google.com, olka+...@chromium.org, thegreenf...@chromium.org, trewin...@google.com, yusufo...@chromium.org, menghua...@google.com, rkgibso...@chromium.org, tmartino+tran...@chromium.org, hansberry+wa...@chromium.org, jbauma...@chromium.org, schedule...@chromium.org, chrome-intell...@chromium.org, jeffreycohen+watc...@chromium.org, alexmo...@chromium.org, pdf-r...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, chromeos-kio...@google.com, zelin+watch-we...@chromium.org, hais+wat...@google.com, loading-rev...@chromium.org, dmurph+watc...@chromium.org, scheduler...@chromium.org, anastas...@google.com, jessemcke...@google.com, mpdento...@chromium.org, mcasas+med...@chromium.org, yuezhang...@chromium.org, horo+...@chromium.org, rrsilva+wat...@google.com, jkeitel+watch-...@google.com, agriev...@chromium.org, mtomas...@chromium.org, hansberry+w...@chromium.org, blink-revi...@chromium.org, edgesto...@microsoft.com, donnd...@chromium.org, apavlo...@chromium.org, pasko...@chromium.org, hanxi...@chromium.org, kinuko+...@chromium.org, oilpan-rev...@chromium.org, rhalava...@chromium.org, eric.c...@apple.com, pushi+watc...@google.com, kouhe...@chromium.org, siashah+au...@chromium.org, twelling...@chromium.org, apaselti...@chromium.org, derinel+wat...@google.com, zackha...@chromium.org, tommyw+w...@chromium.org, gbb-cct...@google.com, spang...@chromium.org, feature-v...@chromium.org, kouhei...@chromium.org
Attention needed from Adem Derinel and Friedrich Hauser
Moe Adel voted and added 4 comments![]( "Open in Gerrit")
Votes added by Moe Adel
| Code-Review | +1 |
4 comments
File components/record_replay/core/browser/capabilities_database.cc
Line 52, Patchset 5 (Latest):
db_.set_error_callback(base::BindRepeating([](int error,Moe Adel . unresolved
not sure, would like your input: What's the reason for using `NOTREACHED` compared to `(D)LOG` statements that do not crash?
Line 57, Patchset 5 (Latest):
if ((error & 0xff) == 19) { // SQLITE_CONSTRAINTMoe Adel . unresolved
does 0xff mean a constraint violation?
Line 60, Patchset 5 (Latest):
NOTREACHED() << "CapabilitiesDatabase SQLite Error: " << errorMoe Adel . unresolved
I think use (D)LOG here to log runtime errors in the callback without causing a crash
Line 267, Patchset 5 (Latest):
CHECK(false) << first_error;Moe Adel . unresolved
I am wondering if we should loop in the finch team to add a check there that checks the string's integrity before it hits here. Is there a way to check that? I think a broken string will crash the browser for all users running that finch experiment. Maybe we should add a log statement here to keep track of that?
Related details
Attention is currently required from:
- Adem Derinel
- Friedrich Hauser
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages