[dbsc] Handle transient cryptographic errors [chromium/src : main]

0 views

Skip to first unread message

Jan Wilken Dörrie (Gerrit)

unread,

10:16 AM (5 hours ago) 10:16 AM

to Alex Ilin, Chromium LUCI CQ, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org

Attention needed from Alex Ilin

Jan Wilken Dörrie added 1 comment

File net/device_bound_sessions/registration_fetcher.cc

Line 54, Patchset 9 (Latest):

    case ServiceError::kOperationCancelled:
    case ServiceError::kCryptoApiFailed:
      return SessionError::kTransientSigningError;

Jan Wilken Dörrie . unresolved

Gemini suggested we also treat Crypto API failures as transient, and don't delete sessions if we encounter them. I see its point, but we already retry on signing errors, so I'm not super sure if we should do it. Do you have strong opinions here?

Open in Gerrit

Related details

Attention is currently required from:

Alex Ilin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages