[tracing] Migrate legacy async macros in various folders [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Dec 22, 2025, 2:33:55 PM (4 days ago) Dec 22
to Mikhail Khokhlov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, devtools-re...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org
Attention needed from Mikhail Khokhlov

Etienne Pierre-Doray added 2 comments

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Etienne Pierre-Doray . resolved

PTAL

File base/test/trace_event_analyzer_unittest.cc
Line 486, Patchset 5 (Parent):TEST_F(TraceEventAnalyzerTest, AsyncBeginEndAssocationsWithSteps) {
Etienne Pierre-Doray . resolved

This is removed because there are no longer any usage in chrome and a presubmit preventing new usage.

Open in Gerrit

Related details

Attention is currently required from:
  • Mikhail Khokhlov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If94ea61fc2415184c2a8e28e854bacb1bccb640a
Gerrit-Change-Number: 7283670
Gerrit-PatchSet: 6
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
Gerrit-Attention: Mikhail Khokhlov <khok...@google.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 19:33:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mikhail Khokhlov (Gerrit)

unread,
Dec 23, 2025, 6:27:09 AM (3 days ago) Dec 23
to Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, devtools-re...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org
Attention needed from Etienne Pierre-Doray

Mikhail Khokhlov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If94ea61fc2415184c2a8e28e854bacb1bccb640a
    Gerrit-Change-Number: 7283670
    Gerrit-PatchSet: 6
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 11:26:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Dec 23, 2025, 10:04:58 AM (3 days ago) Dec 23
    to Colin Blundell, Mikhail Khokhlov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, devtools-re...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org
    Attention needed from Colin Blundell

    Etienne Pierre-Doray added 1 comment

    Patchset-level comments
    Etienne Pierre-Doray . resolved

    +blundell@ for ash/ and ui/

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Colin Blundell
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If94ea61fc2415184c2a8e28e854bacb1bccb640a
    Gerrit-Change-Number: 7283670
    Gerrit-PatchSet: 6
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 15:04:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Dec 23, 2025, 10:10:51 AM (3 days ago) Dec 23
    to Andrey Kosyakov, Colin Blundell, Mikhail Khokhlov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, devtools-re...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org
    Attention needed from Andrey Kosyakov and Colin Blundell

    Etienne Pierre-Doray added 1 comment

    Patchset-level comments
    Etienne Pierre-Doray . resolved

    +caseq@ for content/browser/devtools/ and third_party/blink/renderer/core/inspector/

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrey Kosyakov
    • Colin Blundell
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If94ea61fc2415184c2a8e28e854bacb1bccb640a
    Gerrit-Change-Number: 7283670
    Gerrit-PatchSet: 6
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
    Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 15:10:44 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrey Kosyakov (Gerrit)

    unread,
    Dec 23, 2025, 4:54:31 PM (3 days ago) Dec 23
    to Etienne Pierre-Doray, Colin Blundell, Mikhail Khokhlov, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, torne...@chromium.org, lizeb...@chromium.org, agriev...@chromium.org, yfriedm...@chromium.org, asvitki...@chromium.org, blink-...@chromium.org, chromiumme...@microsoft.com, devtools-re...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org
    Attention needed from Colin Blundell and Etienne Pierre-Doray

    Andrey Kosyakov voted and added 1 comment

    Votes added by Andrey Kosyakov

    Code-Review+1

    1 comment

    Patchset-level comments
    Andrey Kosyakov . resolved

    devtools lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Colin Blundell
    • Etienne Pierre-Doray
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If94ea61fc2415184c2a8e28e854bacb1bccb640a
    Gerrit-Change-Number: 7283670
    Gerrit-PatchSet: 6
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 21:54:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages