Revert "[bedrock] Migrate BrowserListObserver to BrowserCollectionObserver - part 8/n" [chromium/src : main]
0 views
Skip to first unread message
luci-bisection@appspot.gserviceaccount.com (Gerrit)
10:32 AM (2 hours ago) 10:32 AM
to Zhentao Lu, Chromium LUCI CQ, Qikai Zhong, Tom Lukaszewicz, AyeAye, devtools...@chromium.org, chromium...@chromium.org
Attention needed from Qikai Zhong, Tom Lukaszewicz and Zhentao Lu
luci-bi...@appspot.gserviceaccount.com has uploaded the change for review![]( "Open in Gerrit")
luci-bi...@appspot.gserviceaccount.com would like Zhentao Lu, Chromium LUCI CQ, Qikai Zhong and Tom Lukaszewicz to review this change.
Commit message
Revert "[bedrock] Migrate BrowserListObserver to BrowserCollectionObserver - part 8/n"
This reverts commit c5409808b4e00f9e02c2fde662ac634bcfb9235b.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5717198149517312
Sample build with failed test: https://ci.chromium.org/b/8690280166184440401
Affected test(s):
[://chrome/test\:browser_tests!gtest::AppListSortBrowserTest#InterruptReorderFadeOutAnimationTabletMode](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::AppListSortBrowserTest%23InterruptReorderFadeOutAnimationTabletMode?q=VHash%3Abda1baee33115d39)
[://chrome/test\:browser_tests!gtest::AppListSortLoginTest#RecordPrefSortOrderOnSessionStart/All.1](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::AppListSortLoginTest%23RecordPrefSortOrderOnSessionStart%2FAll.1?q=VHash%3Abda1baee33115d39)
[://chrome/test\:browser_tests!gtest::AppListWithRecentAppBrowserTest#RecentAppsShownInTabletModeAfterClearingSearch](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::AppListWithRecentAppBrowserTest%23RecentAppsShownInTabletModeAfterClearingSearch?q=VHash%3Abda1baee33115d39)
[://chrome/test\:browser_tests!gtest::AppServiceAppItemBrowserTest#ActivateAppRecordsNewInstallHistogram](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::AppServiceAppItemBrowserTest%23ActivateAppRecordsNewInstallHistogram?q=VHash%3Abda1baee33115d39)
[://chrome/test\:browser_tests!gtest::AutotestPrivateApiOverviewTest#Default/EventPage.0](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::AutotestPrivateApiOverviewTest%23Default%2FEventPage.0?q=VHash%3Abda1baee33115d39)
and 31 more ...
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5717198149517312&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7550350&type=BUG
Original change's description:
> [bedrock] Migrate BrowserListObserver to BrowserCollectionObserver - part 8/n
>
> This migration is part of project bedrock to reduce the dependencies on
> Browser and BrowserList. See https://crbug.com/431671320 for more info.
>
> Bug: 431671320
> Change-Id: I80309f4c279838a7feef76f2f60c2407022fcf89
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7550350
> Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>
> Commit-Queue: Zhentao Lu <zhent...@microsoft.com>
> Reviewed-by: Qikai Zhong <qikai...@microsoft.com>
> Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1582244}
>
Bug: 431671320
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I97e1f121bb652ed1ecd0d819933473f0d9c64554
Change diff
Change information
Files:
- M chrome/browser/devtools/devtools_browser_context_manager.cc
- M chrome/browser/devtools/devtools_browser_context_manager.h
- M chrome/browser/sync/sessions/browser_list_router_helper.cc
- M chrome/browser/sync/sessions/browser_list_router_helper.h
- M chrome/browser/ui/browser_tab_strip_tracker.cc
- M chrome/browser/ui/browser_tab_strip_tracker.h
- M chrome/browser/ui/views/profiles/profile_picker_view_browsertest.cc
- M chrome/browser/ui/views/web_apps/web_app_integration_test_driver.cc
- M chrome/browser/ui/web_applications/test/web_app_browsertest_util.cc
- M chrome/browser/ui/web_applications/test/web_app_browsertest_util.h
- M chrome/browser/ui/web_applications/web_app_ui_manager_impl.cc
- M chrome/browser/ui/web_applications/web_app_ui_manager_impl.h
- M chrome/browser/ui/webui/whats_new/whats_new_fetcher.cc
- M chrome/test/base/interactive_test_utils.cc
- M chrome/test/base/interactive_test_utils.h
- M chrome/test/interaction/webcontents_interaction_test_util.cc
Change size: L
Delta: 16 files changed, 196 insertions(+), 159 deletions(-)
Related details
Attention is currently required from:
- Qikai Zhong
- Tom Lukaszewicz
- Zhentao Lu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
10:32 AM (2 hours ago) 10:32 AM
to Zaina Al-Mashni, Rubber Stamper, Zhentao Lu, Chromium LUCI CQ, Qikai Zhong, Tom Lukaszewicz, AyeAye, devtools...@chromium.org, chromium...@chromium.org, musa...@google.com, philli...@chromium.org, japhet+...@chromium.org, zelin+watch-we...@chromium.org, estali...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, mickeybu...@chromium.org, dfried...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, aixba+wat...@chromium.org
Attention needed from Qikai Zhong, Tom Lukaszewicz, Zaina Al-Mashni and Zhentao Lu
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.
Related details
Attention is currently required from:
- Qikai Zhong
- Tom Lukaszewicz
- Zaina Al-Mashni
- Zhentao Lu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
10:33 AM (2 hours ago) 10:33 AM
to luci-bi...@appspot.gserviceaccount.com, Zaina Al-Mashni, Zhentao Lu, Chromium LUCI CQ, Qikai Zhong, Tom Lukaszewicz, AyeAye, devtools...@chromium.org, chromium...@chromium.org, musa...@google.com, philli...@chromium.org, japhet+...@chromium.org, zelin+watch-we...@chromium.org, estali...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, mickeybu...@chromium.org, dfried...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, aixba+wat...@chromium.org
Attention needed from Qikai Zhong, Tom Lukaszewicz, Zaina Al-Mashni and Zhentao Lu
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Qikai Zhong
- Tom Lukaszewicz
- Zaina Al-Mashni
- Zhentao Lu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Muhammad Salmaan (Gerrit)
10:34 AM (2 hours ago) 10:34 AM
to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, Zaina Al-Mashni, Zhentao Lu, Chromium LUCI CQ, Qikai Zhong, Tom Lukaszewicz, AyeAye, devtools...@chromium.org, chromium...@chromium.org, musa...@google.com, philli...@chromium.org, japhet+...@chromium.org, zelin+watch-we...@chromium.org, estali...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, mickeybu...@chromium.org, dfried...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, aixba+wat...@chromium.org
Attention needed from Qikai Zhong, Tom Lukaszewicz, Zaina Al-Mashni and Zhentao Lu
Muhammad Salmaan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Qikai Zhong
- Tom Lukaszewicz
- Zaina Al-Mashni
- Zhentao Lu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zaina Al-Mashni (Gerrit)
10:38 AM (2 hours ago) 10:38 AM
to luci-bi...@appspot.gserviceaccount.com, Muhammad Salmaan, Rubber Stamper, Zhentao Lu, Chromium LUCI CQ, Qikai Zhong, Tom Lukaszewicz, AyeAye, devtools...@chromium.org, chromium...@chromium.org, musa...@google.com, philli...@chromium.org, japhet+...@chromium.org, zelin+watch-we...@chromium.org, estali...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, mickeybu...@chromium.org, dfried...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, aixba+wat...@chromium.org
Attention needed from Qikai Zhong, Tom Lukaszewicz and Zhentao Lu
Zaina Al-Mashni voted![]( "Open in Gerrit")
Attention is currently required from:
- Qikai Zhong
- Tom Lukaszewicz
- Zhentao Lu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:38 AM (2 hours ago) 10:38 AM
to luci-bi...@appspot.gserviceaccount.com, Zaina Al-Mashni, Muhammad Salmaan, Rubber Stamper, Zhentao Lu, Qikai Zhong, Tom Lukaszewicz, AyeAye, devtools...@chromium.org, chromium...@chromium.org, musa...@google.com, philli...@chromium.org, japhet+...@chromium.org, zelin+watch-we...@chromium.org, estali...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, mickeybu...@chromium.org, dfried...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, aixba+wat...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit-Queue: Zaina Al-Mashni <zalm...@google.com>
Reviewed-by: Muhammad Salmaan <musa...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Owners-Override: Zaina Al-Mashni <zalm...@google.com>
Cr-Commit-Position: refs/heads/main@{#1582515}
Files:
- M chrome/browser/devtools/devtools_browser_context_manager.cc
- M chrome/browser/devtools/devtools_browser_context_manager.h
- M chrome/browser/sync/sessions/browser_list_router_helper.cc
- M chrome/browser/sync/sessions/browser_list_router_helper.h
- M chrome/browser/ui/browser_tab_strip_tracker.cc
- M chrome/browser/ui/browser_tab_strip_tracker.h
- M chrome/browser/ui/views/profiles/profile_picker_view_browsertest.cc
- M chrome/browser/ui/views/web_apps/web_app_integration_test_driver.cc
- M chrome/browser/ui/web_applications/test/web_app_browsertest_util.cc
- M chrome/browser/ui/web_applications/test/web_app_browsertest_util.h
- M chrome/browser/ui/web_applications/web_app_ui_manager_impl.cc
- M chrome/browser/ui/web_applications/web_app_ui_manager_impl.h
- M chrome/browser/ui/webui/whats_new/whats_new_fetcher.cc
- M chrome/test/base/interactive_test_utils.cc
- M chrome/test/base/interactive_test_utils.h
- M chrome/test/interaction/webcontents_interaction_test_util.cc
Change size: L
Delta: 16 files changed, 196 insertions(+), 159 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Muhammad Salmaan, Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages