Add hmac-secret(-mc) support to DevTools WebAuthn panel [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Byungwoo Lee (Gerrit)
Mar 19, 2026, 12:43:10 AM (5 days ago) Mar 19
to Eric Leese, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Eric Leese
Byungwoo Lee added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Byungwoo Lee . resolved
Hello Eric,
This CL adds 'Supports hmac-secret' and 'Supports hmac-secret-mc' check boxes to the WebAuthn devtools panel.
Could you please review this?
Thank you!
Related details
Attention is currently required from:
- Eric Leese
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Leese (Gerrit)
Mar 19, 2026, 4:03:32 AM (5 days ago) Mar 19
to Byungwoo Lee, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Byungwoo Lee
Eric Leese added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Eric Leese . unresolved
Looks good, but let's wait for these files to be copied as part of the normal browser-protocol roll (hopefully less than a day) and then rebase this change.
Related details
Attention is currently required from:
- Byungwoo Lee
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Byungwoo Lee (Gerrit)
Mar 22, 2026, 7:07:32 PM (2 days ago) Mar 22
to Eric Leese, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Eric Leese
Byungwoo Lee added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Looks good, but let's wait for these files to be copied as part of the normal browser-protocol roll (hopefully less than a day) and then rebase this change.
Byungwoo Lee
Done
File-level comment, Patchset 2 (Latest):
Byungwoo Lee . resolved
Thank you for the review! I rebased after the browser-protocol roll.
Could you please take another look?
Related details
Attention is currently required from:
- Eric Leese
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Leese (Gerrit)
Mar 23, 2026, 9:29:08 AM (20 hours ago) Mar 23
to Byungwoo Lee, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Byungwoo Lee
Eric Leese voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Byungwoo Lee
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
Mar 23, 2026, 9:32:16 AM (20 hours ago) Mar 23
to Byungwoo Lee, Eric Leese, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Byungwoo Lee
Danil Somsikov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Byungwoo Lee
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Byungwoo Lee (Gerrit)
Mar 23, 2026, 9:20:49 PM (8 hours ago) Mar 23
to Danil Somsikov, Eric Leese, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Byungwoo Lee voted and added 1 comment![]( "Open in Gerrit")
Votes added by Byungwoo Lee
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Mar 23, 2026, 10:06:07 PM (8 hours ago) Mar 23
to Byungwoo Lee, Danil Somsikov, Eric Leese, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add hmac-secret(-mc) support to DevTools WebAuthn panel
Add "Supports hmac-secret" and "Supports hmac-secret-mc" checkboxes to
"New Authenticator" section of the DevTools WebAuthn panel, so that
the hmac-secret-mc extension behavior can be tested with a virtual
authenticator in DevTools.
Depends on Chromium CL: https://crrev.com/c/7673678
Bug: 420689820
Change-Id: I29ca266ec744b4339c90551b312a144a29d8a2f0
Reviewed-by: Danil Somsikov <d...@chromium.org>
Commit-Queue: Byungwoo Lee <bl...@igalia.com>
Reviewed-by: Eric Leese <le...@chromium.org>
Files:
- M front_end/panels/webauthn/WebauthnPane.ts
- M front_end/ui/visual_logging/KnownContextValues.ts
Change size: M
Delta: 2 files changed, 54 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Danil Somsikov, +1 by Eric Leese
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages