[docs] Add a screenshot test for LMI and remove it from component docs [devtools/devtools-frontend : main]

3 views

Skip to first unread message

Kim-Anh Tran (Gerrit)

unread,

Nov 4, 2025, 7:36:26 AM (5 days ago) Nov 4

to Benedikt Meurer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Benedikt Meurer

Kim-Anh Tran voted and added 1 comment

Votes added by Kim-Anh Tran

Auto-Submit

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Kim-Anh Tran . resolved

Hi Benedikt,

I'm removing the lmi component doc, and am adding a screenshot test instead. PTAL!

Open in Gerrit

Related details

Attention is currently required from:

Benedikt Meurer

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Simon Zünd (Gerrit)

unread,

Nov 5, 2025, 12:33:49 AM (4 days ago) Nov 5

to Kim-Anh Tran, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Attention needed from Kim-Anh Tran

Simon Zünd voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Kim-Anh Tran

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,

Nov 5, 2025, 12:35:12 AM (4 days ago) Nov 5

to Kim-Anh Tran, Simon Zünd, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:

[docs] Add a screenshot test for LMI and remove it from component docs

The component doc for the LMI is very likely never looked up. Instead,
just add a screenshot test.

Bug: 414332459

Change-Id: I3030d69e0f774e5224f77b84d838d128938042db

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7117244

Reviewed-by: Simon Zünd <szu...@chromium.org>

Commit-Queue: Simon Zünd <szu...@chromium.org>

Auto-Submit: Kim-Anh Tran <kim...@chromium.org>

Files:

M front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.test.ts
M front_end/ui/components/docs/BUILD.gn
D front_end/ui/components/docs/linear_memory_inspector/BUILD.gn
D front_end/ui/components/docs/linear_memory_inspector/basic.html
D front_end/ui/components/docs/linear_memory_inspector/basic.ts
A test/goldens/linux/linear_memory_inspector/lmi.png

Change size: M

Delta: 6 files changed, 62 insertions(+), 94 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Simon Zünd

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages