Reland "prefetch: Reflect Devtools emulated user agent override in headers" [chromium/src : main]

0 views
Skip to first unread message

Ken Okada (Gerrit)

unread,
Oct 7, 2025, 1:47:39 AM (7 days ago) Oct 7
to Huanpo Lin, Chromium LUCI CQ, Takashi Nakayama, Hiroshige Hayashizaki, Victor Tan, Danil Somsikov, Kent Tamura, Rakina Zata Amni, AyeAye, prerendering-reviews, Code Review Nudger, Hiroki Nakagawa, chromium...@chromium.org, Mike Taylor, Kouhei Ueno, Yoshisato Yanagisawa, tburkar...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, blink-...@chromium.org, devtools...@chromium.org, lingqi...@chromium.org
Attention needed from Huanpo Lin

Ken Okada added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ken Okada . unresolved

What is the diff?

Open in Gerrit

Related details

Attention is currently required from:
  • Huanpo Lin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I14955192936e95e01f1adb9863eddee561e2a7d0
Gerrit-Change-Number: 7015170
Gerrit-PatchSet: 1
Gerrit-Owner: Huanpo Lin <robe...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Reviewer: Ken Okada <ken...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Reviewer: Takashi Nakayama <tn...@chromium.org>
Gerrit-Reviewer: Victor Tan <vict...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Yoshisato Yanagisawa <yyana...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Huanpo Lin <robe...@chromium.org>
Gerrit-Comment-Date: Tue, 07 Oct 2025 05:46:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Huanpo Lin (Gerrit)

unread,
Oct 7, 2025, 9:04:15 PM (6 days ago) Oct 7
to Danil Somsikov, Victor Tan, Chromium LUCI CQ, Takashi Nakayama, Hiroshige Hayashizaki, Ken Okada, Kent Tamura, Rakina Zata Amni, AyeAye, prerendering-reviews, Code Review Nudger, Hiroki Nakagawa, chromium...@chromium.org, Mike Taylor, Kouhei Ueno, Yoshisato Yanagisawa, tburkar...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, blink-...@chromium.org, devtools...@chromium.org, lingqi...@chromium.org
Attention needed from Ken Okada

Huanpo Lin voted and added 1 comment

Votes added by Huanpo Lin

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1:
Ken Okada . resolved

What is the diff?

Huanpo Lin

The system sent out notification automatically and it wasn't updated yet. I've made updates and added descriptions. PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Ken Okada
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I14955192936e95e01f1adb9863eddee561e2a7d0
    Gerrit-Change-Number: 7015170
    Gerrit-PatchSet: 3
    Gerrit-Owner: Huanpo Lin <robe...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
    Gerrit-Reviewer: Huanpo Lin <robe...@chromium.org>
    Gerrit-Reviewer: Ken Okada <ken...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Takashi Nakayama <tn...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Danil Somsikov <d...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
    Gerrit-CC: Mike Taylor <mike...@chromium.org>
    Gerrit-CC: Victor Tan <vict...@chromium.org>
    Gerrit-CC: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Ken Okada <ken...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Oct 2025 01:02:33 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Ken Okada <ken...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ken Okada (Gerrit)

    unread,
    Oct 8, 2025, 12:49:08 AM (6 days ago) Oct 8
    to Huanpo Lin, Danil Somsikov, Victor Tan, Chromium LUCI CQ, Takashi Nakayama, Hiroshige Hayashizaki, Kent Tamura, Rakina Zata Amni, AyeAye, prerendering-reviews, Code Review Nudger, Hiroki Nakagawa, chromium...@chromium.org, Mike Taylor, Kouhei Ueno, Yoshisato Yanagisawa, tburkar...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, blink-...@chromium.org, devtools...@chromium.org, lingqi...@chromium.org
    Attention needed from Hiroshige Hayashizaki, Huanpo Lin, Kent Tamura, Rakina Zata Amni and Takashi Nakayama

    Ken Okada added 1 comment

    Commit Message
    Line 11, Patchset 3 (Latest):Diff from the original CLs:
    Ken Okada . unresolved

    Could you add 1. the reason for revert and then describe 2. how we fixed it.

    https://chromium-review.googlesource.com/c/chromium/src/+/7015190
    https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/59207/overview

    The reason is use-of-uninitialized-value, detected by MSan. (The code diff looks good.)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hiroshige Hayashizaki
    • Huanpo Lin
    • Kent Tamura
    • Rakina Zata Amni
    • Takashi Nakayama
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Gerrit-Attention: Huanpo Lin <robe...@chromium.org>
      Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>
      Gerrit-Attention: Takashi Nakayama <tn...@chromium.org>
      Gerrit-Attention: Kent Tamura <tk...@chromium.org>
      Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Comment-Date: Wed, 08 Oct 2025 04:47:21 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ken Okada (Gerrit)

      unread,
      Oct 8, 2025, 12:52:59 AM (6 days ago) Oct 8
      to Huanpo Lin, Danil Somsikov, Victor Tan, Chromium LUCI CQ, Takashi Nakayama, Hiroshige Hayashizaki, Kent Tamura, Rakina Zata Amni, AyeAye, prerendering-reviews, Code Review Nudger, Hiroki Nakagawa, chromium...@chromium.org, Mike Taylor, Kouhei Ueno, Yoshisato Yanagisawa, tburkar...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, blink-...@chromium.org, devtools...@chromium.org, lingqi...@chromium.org
      Attention needed from Hiroshige Hayashizaki, Huanpo Lin, Kent Tamura, Rakina Zata Amni and Takashi Nakayama

      Ken Okada added 1 comment

      File content/browser/devtools/devtools_instrumentation.h
      Line 112, Patchset 3 (Latest): bool accept_language_overridden = false;
      Ken Okada . unresolved

      [nit]

      https://chromium-review.googlesource.com/c/chromium/src/+/6719107/comment/fb8cd6c4_b75f0087/

      Note that I personally prefer using designated initializer as using `false` is a logic of `ApplyEmulationOverrides()` and it's nice to sit in the function.

      Gerrit-Comment-Date: Wed, 08 Oct 2025 04:51:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ken Okada (Gerrit)

      unread,
      Oct 8, 2025, 12:54:28 AM (6 days ago) Oct 8
      to Huanpo Lin, Danil Somsikov, Victor Tan, Chromium LUCI CQ, Takashi Nakayama, Hiroshige Hayashizaki, Kent Tamura, Rakina Zata Amni, AyeAye, prerendering-reviews, Code Review Nudger, Hiroki Nakagawa, chromium...@chromium.org, Mike Taylor, Kouhei Ueno, Yoshisato Yanagisawa, tburkar...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, blink-...@chromium.org, devtools...@chromium.org, lingqi...@chromium.org
      Attention needed from Hiroshige Hayashizaki, Huanpo Lin, Kent Tamura, Rakina Zata Amni and Takashi Nakayama

      Ken Okada added 1 comment

      File content/browser/devtools/devtools_instrumentation.h
      Line 112, Patchset 3 (Latest): bool accept_language_overridden = false;
      Ken Okada . unresolved

      [nit]

      https://chromium-review.googlesource.com/c/chromium/src/+/6719107/comment/fb8cd6c4_b75f0087/

      Note that I personally prefer using designated initializer as using `false` is a logic of `ApplyEmulationOverrides()` and it's nice to sit in the function.

      Ken Okada

      in this case. (I usually use default initialize params in headers to prevent use-before-initialization.)

      Gerrit-Comment-Date: Wed, 08 Oct 2025 04:52:41 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Ken Okada <ken...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Takashi Nakayama (Gerrit)

      unread,
      Oct 8, 2025, 3:18:15 AM (6 days ago) Oct 8
      to Huanpo Lin, Danil Somsikov, Victor Tan, Chromium LUCI CQ, Hiroshige Hayashizaki, Ken Okada, Kent Tamura, Rakina Zata Amni, AyeAye, prerendering-reviews, Code Review Nudger, Hiroki Nakagawa, chromium...@chromium.org, Mike Taylor, Kouhei Ueno, Yoshisato Yanagisawa, tburkar...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, blink-...@chromium.org, devtools...@chromium.org, lingqi...@chromium.org
      Attention needed from Hiroshige Hayashizaki, Huanpo Lin, Kent Tamura and Rakina Zata Amni

      Takashi Nakayama voted and added 2 comments

      Votes added by Takashi Nakayama

      Code-Review+1

      2 comments

      Patchset-level comments
      File-level comment, Patchset 3 (Latest):
      Takashi Nakayama . resolved

      non-owner LGTM. Thanks!

      File content/browser/devtools/devtools_instrumentation.h
      Line 112, Patchset 3 (Latest): bool accept_language_overridden = false;
      Ken Okada . unresolved

      [nit]

      https://chromium-review.googlesource.com/c/chromium/src/+/6719107/comment/fb8cd6c4_b75f0087/

      Note that I personally prefer using designated initializer as using `false` is a logic of `ApplyEmulationOverrides()` and it's nice to sit in the function.

      Ken Okada

      in this case. (I usually use default initialize params in headers to prevent use-before-initialization.)

      Takashi Nakayama

      IMHO it is natural enough to set default values here, given the risk of using uninitialized fields. But I don't have a strong opinion on this.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Hiroshige Hayashizaki
      • Huanpo Lin
      • Kent Tamura
      • Rakina Zata Amni
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Gerrit-Attention: Kent Tamura <tk...@chromium.org>
        Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
        Gerrit-Comment-Date: Wed, 08 Oct 2025 07:16:08 +0000
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Huanpo Lin (Gerrit)

        unread,
        Oct 9, 2025, 2:20:05 AM (5 days ago) Oct 9
        to Takashi Nakayama, Danil Somsikov, Victor Tan, Chromium LUCI CQ, Hiroshige Hayashizaki, Ken Okada, Kent Tamura, Rakina Zata Amni, AyeAye, prerendering-reviews, Code Review Nudger, Hiroki Nakagawa, chromium...@chromium.org, Mike Taylor, Kouhei Ueno, Yoshisato Yanagisawa, tburkar...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, blink-...@chromium.org, devtools...@chromium.org, lingqi...@chromium.org
        Attention needed from Hiroshige Hayashizaki, Ken Okada, Kent Tamura and Rakina Zata Amni

        Huanpo Lin voted and added 2 comments

        Votes added by Huanpo Lin

        Commit-Queue+1

        2 comments

        Commit Message
        Line 11, Patchset 3:Diff from the original CLs:
        Ken Okada . resolved

        Could you add 1. the reason for revert and then describe 2. how we fixed it.

        https://chromium-review.googlesource.com/c/chromium/src/+/7015190
        https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/59207/overview

        The reason is use-of-uninitialized-value, detected by MSan. (The code diff looks good.)

        Huanpo Lin

        Done

        File content/browser/devtools/devtools_instrumentation.h
        Line 112, Patchset 3: bool accept_language_overridden = false;
        Ken Okada . unresolved

        [nit]

        https://chromium-review.googlesource.com/c/chromium/src/+/6719107/comment/fb8cd6c4_b75f0087/

        Note that I personally prefer using designated initializer as using `false` is a logic of `ApplyEmulationOverrides()` and it's nice to sit in the function.

        Ken Okada

        in this case. (I usually use default initialize params in headers to prevent use-before-initialization.)

        Takashi Nakayama

        IMHO it is natural enough to set default values here, given the risk of using uninitialized fields. But I don't have a strong opinion on this.

        Huanpo Lin

        `DevtoolsOverriddenOutputParams` is going to be used by `ApplyNetworkRequestOverrides` in another follow-up refactor CL. Maybe it will save more code to do it like the current PS instead of putting initialization into individual functions if all functions use the default value `false`?
        cc the owner @rak...@chromium.org if have any preference

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hiroshige Hayashizaki
        • Ken Okada
        • Kent Tamura
        • Rakina Zata Amni
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I14955192936e95e01f1adb9863eddee561e2a7d0
        Gerrit-Change-Number: 7015170
        Gerrit-PatchSet: 4
        Gerrit-Owner: Huanpo Lin <robe...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
        Gerrit-Reviewer: Huanpo Lin <robe...@chromium.org>
        Gerrit-Reviewer: Ken Okada <ken...@chromium.org>
        Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
        Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
        Gerrit-Reviewer: Takashi Nakayama <tn...@chromium.org>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-CC: Danil Somsikov <d...@chromium.org>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
        Gerrit-CC: Mike Taylor <mike...@chromium.org>
        Gerrit-CC: Victor Tan <vict...@chromium.org>
        Gerrit-CC: Yoshisato Yanagisawa <yyana...@chromium.org>
        Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
        Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>
        Gerrit-Attention: Ken Okada <ken...@chromium.org>
        Gerrit-Attention: Kent Tamura <tk...@chromium.org>
        Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
        Gerrit-Comment-Date: Thu, 09 Oct 2025 06:18:07 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Takashi Nakayama <tn...@chromium.org>
        Comment-In-Reply-To: Ken Okada <ken...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Rakina Zata Amni (Gerrit)

        unread,
        Oct 9, 2025, 10:10:31 PM (4 days ago) Oct 9
        to Huanpo Lin, Takashi Nakayama, Danil Somsikov, Victor Tan, Chromium LUCI CQ, Hiroshige Hayashizaki, Ken Okada, Kent Tamura, AyeAye, prerendering-reviews, Code Review Nudger, Hiroki Nakagawa, chromium...@chromium.org, Mike Taylor, Kouhei Ueno, Yoshisato Yanagisawa, tburkar...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, blink-...@chromium.org, devtools...@chromium.org, lingqi...@chromium.org
        Attention needed from Hiroshige Hayashizaki, Huanpo Lin, Ken Okada and Kent Tamura

        Rakina Zata Amni voted and added 1 comment

        Votes added by Rakina Zata Amni

        Code-Review+1

        1 comment

        File content/browser/devtools/devtools_instrumentation.h
        Line 112, Patchset 3: bool accept_language_overridden = false;
        Ken Okada . unresolved

        [nit]

        https://chromium-review.googlesource.com/c/chromium/src/+/6719107/comment/fb8cd6c4_b75f0087/

        Note that I personally prefer using designated initializer as using `false` is a logic of `ApplyEmulationOverrides()` and it's nice to sit in the function.

        Ken Okada

        in this case. (I usually use default initialize params in headers to prevent use-before-initialization.)

        Takashi Nakayama

        IMHO it is natural enough to set default values here, given the risk of using uninitialized fields. But I don't have a strong opinion on this.

        Huanpo Lin

        `DevtoolsOverriddenOutputParams` is going to be used by `ApplyNetworkRequestOverrides` in another follow-up refactor CL. Maybe it will save more code to do it like the current PS instead of putting initialization into individual functions if all functions use the default value `false`?
        cc the owner @rak...@chromium.org if have any preference

        Rakina Zata Amni

        Seems fine to use default values like in the current PS.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hiroshige Hayashizaki
        • Huanpo Lin
        • Ken Okada
        • Kent Tamura
        Gerrit-Attention: Huanpo Lin <robe...@chromium.org>
        Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>
        Gerrit-Attention: Ken Okada <ken...@chromium.org>
        Gerrit-Attention: Kent Tamura <tk...@chromium.org>
        Gerrit-Comment-Date: Fri, 10 Oct 2025 02:08:16 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Huanpo Lin <robe...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Kent Tamura (Gerrit)

        unread,
        Oct 13, 2025, 10:52:46 PM (3 hours ago) Oct 13
        to Huanpo Lin, Kent Tamura, Rakina Zata Amni, Takashi Nakayama, Danil Somsikov, Victor Tan, Chromium LUCI CQ, Hiroshige Hayashizaki, Ken Okada, AyeAye, prerendering-reviews, Code Review Nudger, Hiroki Nakagawa, chromium...@chromium.org, Mike Taylor, Kouhei Ueno, Yoshisato Yanagisawa, tburkar...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, blink-...@chromium.org, devtools...@chromium.org, lingqi...@chromium.org
        Attention needed from Hiroshige Hayashizaki, Huanpo Lin and Ken Okada

        Kent Tamura voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hiroshige Hayashizaki
        • Huanpo Lin
        • Ken Okada
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I14955192936e95e01f1adb9863eddee561e2a7d0
        Gerrit-Change-Number: 7015170
        Gerrit-PatchSet: 5
        Gerrit-Owner: Huanpo Lin <robe...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
        Gerrit-Reviewer: Huanpo Lin <robe...@chromium.org>
        Gerrit-Reviewer: Ken Okada <ken...@chromium.org>
        Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
        Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
        Gerrit-Reviewer: Takashi Nakayama <tn...@chromium.org>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-CC: Danil Somsikov <d...@chromium.org>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
        Gerrit-CC: Mike Taylor <mike...@chromium.org>
        Gerrit-CC: Victor Tan <vict...@chromium.org>
        Gerrit-CC: Yoshisato Yanagisawa <yyana...@chromium.org>
        Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
        Gerrit-Attention: Huanpo Lin <robe...@chromium.org>
        Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>
        Gerrit-Attention: Ken Okada <ken...@chromium.org>
        Gerrit-Comment-Date: Tue, 14 Oct 2025 02:50:37 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Hiroshige Hayashizaki (Gerrit)

        unread,
        Oct 13, 2025, 11:30:14 PM (3 hours ago) Oct 13
        to Huanpo Lin, Kent Tamura, Rakina Zata Amni, Takashi Nakayama, Danil Somsikov, Victor Tan, Chromium LUCI CQ, Ken Okada, AyeAye, prerendering-reviews, Code Review Nudger, Hiroki Nakagawa, chromium...@chromium.org, Mike Taylor, Kouhei Ueno, Yoshisato Yanagisawa, tburkar...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, blink-...@chromium.org, devtools...@chromium.org, lingqi...@chromium.org
        Attention needed from Huanpo Lin and Ken Okada

        Hiroshige Hayashizaki voted and added 1 comment

        Votes added by Hiroshige Hayashizaki

        Code-Review+1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 5 (Latest):
        Hiroshige Hayashizaki . resolved

        LGTM (defer to other reviewers for the existing discussions)

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Huanpo Lin
        • Ken Okada
        Gerrit-Attention: Ken Okada <ken...@chromium.org>
        Gerrit-Comment-Date: Tue, 14 Oct 2025 03:29:38 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages