AI: improve LH audit output [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Jack Franklin (Gerrit)

unread,
Mar 23, 2026, 10:59:55 AM (21 hours ago) Mar 23
to Alina Varkki, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org, lighthouse-en...@google.com
Attention needed from Alina Varkki

Jack Franklin voted and added 1 comment

Votes added by Jack Franklin

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Jack Franklin . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Alina Varkki
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I48dba944d423b50ffa068644bf2d6bd98ed11a92
Gerrit-Change-Number: 7691248
Gerrit-PatchSet: 3
Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Alina Varkki <alina...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Alina Varkki <alina...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 14:59:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Connor Clark (Gerrit)

unread,
Mar 23, 2026, 2:29:34 PM (18 hours ago) Mar 23
to Jack Franklin, Alina Varkki, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org, lighthouse-en...@google.com
Attention needed from Alina Varkki and Jack Franklin

Connor Clark voted and added 2 comments

Votes added by Connor Clark

Code-Review+1

2 comments

Patchset-level comments
Connor Clark . resolved

lgtm, thanks

Commit Message
Line 12, Patchset 3 (Latest):Bug: 489620101
Connor Clark . unresolved

```suggestion
Bug: 491078108
```

(wrong bug)

Open in Gerrit

Related details

Attention is currently required from:
  • Alina Varkki
  • Jack Franklin
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I48dba944d423b50ffa068644bf2d6bd98ed11a92
Gerrit-Change-Number: 7691248
Gerrit-PatchSet: 3
Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Alina Varkki <alina...@chromium.org>
Gerrit-Reviewer: Connor Clark <cja...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Alina Varkki <alina...@chromium.org>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 18:29:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jack Franklin (Gerrit)

unread,
5:24 AM (3 hours ago) 5:24 AM
to Connor Clark, Alina Varkki, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org, lighthouse-en...@google.com
Attention needed from Alina Varkki

Jack Franklin voted and added 1 comment

Votes added by Jack Franklin

Commit-Queue+2

1 comment

Commit Message
Connor Clark . resolved

```suggestion
Bug: 491078108
```

(wrong bug)

Jack Franklin

good catch ty!

Open in Gerrit

Related details

Attention is currently required from:
  • Alina Varkki
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I48dba944d423b50ffa068644bf2d6bd98ed11a92
    Gerrit-Change-Number: 7691248
    Gerrit-PatchSet: 3
    Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Reviewer: Alina Varkki <alina...@chromium.org>
    Gerrit-Reviewer: Connor Clark <cja...@chromium.org>
    Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Alina Varkki <alina...@chromium.org>
    Gerrit-Comment-Date: Tue, 24 Mar 2026 09:24:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Connor Clark <cja...@chromium.org>
    satisfied_requirement
    open
    diffy

    Devtools-frontend LUCI CQ (Gerrit)

    unread,
    5:28 AM (3 hours ago) 5:28 AM
    to Jack Franklin, Connor Clark, Alina Varkki, devtools-rev...@chromium.org, lighthouse-en...@google.com

    Devtools-frontend LUCI CQ submitted the change

    Change information

    Commit message:
    AI: improve LH audit output

    Improves the format by adding sub-item details, and also formatting the
    values as units more consistently.
    Bug: 489620101
    Change-Id: I48dba944d423b50ffa068644bf2d6bd98ed11a92
    Auto-Submit: Jack Franklin <jacktf...@chromium.org>
    Commit-Queue: Jack Franklin <jacktf...@chromium.org>
    Reviewed-by: Connor Clark <cja...@chromium.org>
    Files:
    • M front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt
    • M front_end/models/ai_assistance/data_formatters/LighthouseFormatter.test.ts
    • M front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts
    • M front_end/models/lighthouse/LighthouseReporterTypes.ts
    Change size: L
    Delta: 4 files changed, 320 insertions(+), 32 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Connor Clark
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I48dba944d423b50ffa068644bf2d6bd98ed11a92
    Gerrit-Change-Number: 7691248
    Gerrit-PatchSet: 4
    Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Reviewer: Alina Varkki <alina...@chromium.org>
    Gerrit-Reviewer: Connor Clark <cja...@chromium.org>
    Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages