Introduce ObserverListReentrancyPolicy to specify untriaged renttrancy. [chromium/src : main]

0 views
Skip to first unread message

Mitsuru Oshima (Gerrit)

unread,
Feb 8, 2026, 4:27:01 PM (2 days ago) Feb 8
to Rushan Suleymanov, Kenichi Ishibashi, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Ian Vollick, Chromium Sync Reviews, Dale Curtis, Bo Liu, Daniel Cheng, Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, abigailbk...@google.com, alexmo...@chromium.org, creis...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
Attention needed from Bo Liu, Chromium Sync Reviews, Dale Curtis, Daniel Cheng, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Ian Vollick, Kenichi Ishibashi, Rushan Suleymanov and Tom Lukaszewicz

Mitsuru Oshima voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bo Liu
  • Chromium Sync Reviews
  • Dale Curtis
  • Daniel Cheng
  • Denis Kuznetsov
  • Francois Pierre Doray
  • Gavin Williams
  • Ian Vollick
  • Kenichi Ishibashi
  • Rushan Suleymanov
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib069f7a49a68bca47012ef119b90ea98d25e2947
Gerrit-Change-Number: 7554792
Gerrit-PatchSet: 5
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Chromium Sync Reviews <chromium-s...@google.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Gavin Williams <gavi...@chromium.org>
Gerrit-Reviewer: Ian Vollick <vol...@chromium.org>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Gavin Williams <gavi...@chromium.org>
Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Attention: Ian Vollick <vol...@chromium.org>
Gerrit-Attention: Rushan Suleymanov <rus...@google.com>
Gerrit-Attention: Bo Liu <bo...@chromium.org>
Gerrit-Attention: Denis Kuznetsov <ant...@chromium.org>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Attention: Chromium Sync Reviews <chromium-s...@google.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Sun, 08 Feb 2026 21:26:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Feb 8, 2026, 4:30:19 PM (2 days ago) Feb 8
to Mitsuru Oshima, Chromium Sync Reviews, Rushan Suleymanov, Kenichi Ishibashi, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Ian Vollick, Dale Curtis, Bo Liu, Daniel Cheng, Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, abigailbk...@google.com, alexmo...@chromium.org, creis...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
Attention needed from Bo Liu, Dale Curtis, Daniel Cheng, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Ian Vollick, Kenichi Ishibashi, Rushan Suleymanov and Tom Lukaszewicz

Message from gwsq

Reviewer source(s):
rus...@google.com is from context(googleclient/chrome/chromium_gwsq/components/sync/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Bo Liu
  • Dale Curtis
  • Daniel Cheng
  • Denis Kuznetsov
  • Francois Pierre Doray
  • Gavin Williams
  • Ian Vollick
  • Kenichi Ishibashi
  • Rushan Suleymanov
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib069f7a49a68bca47012ef119b90ea98d25e2947
Gerrit-Change-Number: 7554792
Gerrit-PatchSet: 5
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Gavin Williams <gavi...@chromium.org>
Gerrit-Reviewer: Ian Vollick <vol...@chromium.org>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Gavin Williams <gavi...@chromium.org>
Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Attention: Ian Vollick <vol...@chromium.org>
Gerrit-Attention: Rushan Suleymanov <rus...@google.com>
Gerrit-Attention: Bo Liu <bo...@chromium.org>
Gerrit-Attention: Denis Kuznetsov <ant...@chromium.org>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Sun, 08 Feb 2026 21:29:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kenichi Ishibashi (Gerrit)

unread,
Feb 8, 2026, 6:25:24 PM (2 days ago) Feb 8
to Mitsuru Oshima, Chromium Sync Reviews, Rushan Suleymanov, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Ian Vollick, Dale Curtis, Bo Liu, Daniel Cheng, Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, abigailbk...@google.com, alexmo...@chromium.org, creis...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
Attention needed from Bo Liu, Dale Curtis, Daniel Cheng, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Ian Vollick, Mitsuru Oshima, Rushan Suleymanov and Tom Lukaszewicz

Kenichi Ishibashi voted and added 1 comment

Votes added by Kenichi Ishibashi

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Kenichi Ishibashi . resolved

//net lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Bo Liu
  • Dale Curtis
  • Daniel Cheng
  • Denis Kuznetsov
  • Francois Pierre Doray
  • Gavin Williams
  • Ian Vollick
  • Mitsuru Oshima
  • Rushan Suleymanov
  • Tom Lukaszewicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Ian Vollick <vol...@chromium.org>
    Gerrit-Attention: Rushan Suleymanov <rus...@google.com>
    Gerrit-Attention: Bo Liu <bo...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Denis Kuznetsov <ant...@chromium.org>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Sun, 08 Feb 2026 23:24:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mitsuru Oshima (Gerrit)

    unread,
    Feb 8, 2026, 6:44:50 PM (2 days ago) Feb 8
    to Kenichi Ishibashi, Chromium Sync Reviews, Rushan Suleymanov, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Bo Liu, Daniel Cheng, Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, abigailbk...@google.com, alexmo...@chromium.org, creis...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Bo Liu, Daniel Cheng, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Rushan Suleymanov and Tom Lukaszewicz

    Mitsuru Oshima added 1 comment

    Patchset-level comments
    File-level comment, Patchset 6 (Latest):
    Mitsuru Oshima . resolved

    bashi@ -> net (thank you!)
    dcheng@ -> base
    fdoray@ -> compoents/performance_manager
    rushans@ -> comopnents/skills, components/sync
    boliu@ -> content/browser
    tluk@ -> chrome/browser, ui/

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bo Liu
    • Daniel Cheng
    • Denis Kuznetsov
    • Francois Pierre Doray
    • Gavin Williams
    • Rushan Suleymanov
    • Tom Lukaszewicz
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib069f7a49a68bca47012ef119b90ea98d25e2947
    Gerrit-Change-Number: 7554792
    Gerrit-PatchSet: 6
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Gavin Williams <gavi...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Gavin Williams <gavi...@chromium.org>
    Gerrit-Attention: Rushan Suleymanov <rus...@google.com>
    Gerrit-Attention: Bo Liu <bo...@chromium.org>
    Gerrit-Attention: Denis Kuznetsov <ant...@chromium.org>
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Sun, 08 Feb 2026 23:44:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mitsuru Oshima (Gerrit)

    unread,
    Feb 8, 2026, 6:46:28 PM (2 days ago) Feb 8
    to Kenichi Ishibashi, Chromium Sync Reviews, Rushan Suleymanov, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Bo Liu, Daniel Cheng, Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, abigailbk...@google.com, alexmo...@chromium.org, creis...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Bo Liu, Daniel Cheng, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Rushan Suleymanov and Tom Lukaszewicz

    Mitsuru Oshima voted Commit-Queue+1

    Commit-Queue+1
    Gerrit-Comment-Date: Sun, 08 Feb 2026 23:46:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rushan Suleymanov (Gerrit)

    unread,
    Feb 9, 2026, 3:45:15 AM (yesterday) Feb 9
    to Mitsuru Oshima, Kenichi Ishibashi, Chromium Sync Reviews, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Bo Liu, Daniel Cheng, Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, abigailbk...@google.com, alexmo...@chromium.org, creis...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Bo Liu, Daniel Cheng, Denis Kuznetsov, Francois Pierre Doray, Gavin Williams, Mitsuru Oshima and Tom Lukaszewicz

    Rushan Suleymanov voted and added 1 comment

    Votes added by Rushan Suleymanov

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Rushan Suleymanov . resolved

    sync, skills, gcm_driver lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bo Liu
    • Daniel Cheng
    • Denis Kuznetsov
    • Francois Pierre Doray
    • Gavin Williams
    • Mitsuru Oshima
    • Tom Lukaszewicz
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib069f7a49a68bca47012ef119b90ea98d25e2947
    Gerrit-Change-Number: 7554792
    Gerrit-PatchSet: 7
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Denis Kuznetsov <ant...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Gavin Williams <gavi...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Gavin Williams <gavi...@chromium.org>
    Gerrit-Attention: Bo Liu <bo...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Denis Kuznetsov <ant...@chromium.org>
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 09 Feb 2026 08:45:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Denis Kuznetsov (Gerrit)

    unread,
    Feb 9, 2026, 8:35:32 AM (yesterday) Feb 9
    to Mitsuru Oshima, Rushan Suleymanov, Kenichi Ishibashi, Chromium Sync Reviews, Francois Pierre Doray, Gavin Williams, Bo Liu, Daniel Cheng, Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, abigailbk...@google.com, alexmo...@chromium.org, creis...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Bo Liu, Daniel Cheng, Francois Pierre Doray, Gavin Williams, Mitsuru Oshima and Tom Lukaszewicz

    Denis Kuznetsov voted and added 1 comment

    Votes added by Denis Kuznetsov

    Code-Review+1

    1 comment

    Patchset-level comments
    Denis Kuznetsov . resolved

    `chromeos/ash/components` LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bo Liu
    • Daniel Cheng
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 09 Feb 2026 13:35:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Bo Liu (Gerrit)

    unread,
    Feb 9, 2026, 10:11:19 AM (yesterday) Feb 9
    to Mitsuru Oshima, Bo Liu, Denis Kuznetsov, Rushan Suleymanov, Kenichi Ishibashi, Chromium Sync Reviews, Francois Pierre Doray, Gavin Williams, Daniel Cheng, Tom Lukaszewicz, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, abigailbk...@google.com, alexmo...@chromium.org, creis...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Daniel Cheng, Francois Pierre Doray, Gavin Williams, Mitsuru Oshima and Tom Lukaszewicz

    Bo Liu voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 09 Feb 2026 15:11:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tom Lukaszewicz (Gerrit)

    unread,
    Feb 9, 2026, 12:33:02 PM (24 hours ago) Feb 9
    to Mitsuru Oshima, Bo Liu, Denis Kuznetsov, Rushan Suleymanov, Kenichi Ishibashi, Chromium Sync Reviews, Francois Pierre Doray, Gavin Williams, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, abigailbk...@google.com, alexmo...@chromium.org, creis...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Daniel Cheng, Francois Pierre Doray, Gavin Williams and Mitsuru Oshima

    Tom Lukaszewicz voted and added 1 comment

    Votes added by Tom Lukaszewicz

    Code-Review+1

    1 comment

    Patchset-level comments
    Tom Lukaszewicz . resolved

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    • Francois Pierre Doray
    • Gavin Williams
    • Mitsuru Oshima
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 09 Feb 2026 17:32:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    1:17 AM (11 hours ago) 1:17 AM
    to Mitsuru Oshima, Daniel Cheng, Tom Lukaszewicz, Bo Liu, Denis Kuznetsov, Rushan Suleymanov, Kenichi Ishibashi, Chromium Sync Reviews, Francois Pierre Doray, Gavin Williams, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, abigailbk...@google.com, alexmo...@chromium.org, creis...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Francois Pierre Doray, Gavin Williams and Mitsuru Oshima

    Daniel Cheng voted and added 2 comments

    Votes added by Daniel Cheng

    Code-Review+1

    2 comments

    Patchset-level comments
    Daniel Cheng . resolved

    LGTM

    Let me know if you want to use OO+1; otherwise, I didn't look at any of the non-//base changes.

    File content/browser/devtools/protocol/target_auto_attacher.h
    Line 89, Patchset 7 (Latest): base::ObserverListReentrancyPolicy::kAllowReentrancyUntriaged>
    Daniel Cheng . unresolved

    I assume someone will actively work on triaging these and fixing them? Is there a TODO bug to attach here?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Francois Pierre Doray
    • Gavin Williams
    • Mitsuru Oshima
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Gerrit-Comment-Date: Tue, 10 Feb 2026 06:17:39 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Francois Pierre Doray (Gerrit)

      unread,
      10:38 AM (2 hours ago) 10:38 AM
      to Mitsuru Oshima, Daniel Cheng, Tom Lukaszewicz, Bo Liu, Denis Kuznetsov, Rushan Suleymanov, Kenichi Ishibashi, Chromium Sync Reviews, Gavin Williams, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, abigailbk...@google.com, alexmo...@chromium.org, creis...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, hashimo...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
      Attention needed from Gavin Williams and Mitsuru Oshima

      Francois Pierre Doray voted and added 1 comment

      Votes added by Francois Pierre Doray

      Code-Review+1

      1 comment

      Patchset-level comments
      Francois Pierre Doray . resolved

      //components/performance_manager/ LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Gavin Williams
      • Mitsuru Oshima
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      Gerrit-Comment-Date: Tue, 10 Feb 2026 15:38:24 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages