WebMCP: Expose document.modelContext [chromium/src : main]
1 view
Skip to first unread message
Dominic Farolino (Gerrit)
May 21, 2026, 5:53:18 PM (3 days ago) May 21
to Chromium LUCI CQ, Mark Foltz, chromium...@chromium.org, Khushal Sagar, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Mark Foltz
Dominic Farolino voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Mark Foltz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Foltz (Gerrit)
May 22, 2026, 5:51:55 PM (2 days ago) May 22
to Dominic Farolino, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Dominic Farolino
Mark Foltz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Foltz
| Code-Review | +1 |
1 comment
File third_party/blink/web_tests/wpt_internal/webmcp/resources/webmcp-helpers.js
Line 1, Patchset 2 (Latest):
async function waitForTool(name) {Mark Foltz . unresolved
This duplicates waitForTool in third_party/blink/web_tests/fast/webmcp/resources/webmcp-helpers.js ...
Related details
Attention is currently required from:
- Dominic Farolino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Foltz (Gerrit)
May 22, 2026, 5:53:05 PM (2 days ago) May 22
to Dominic Farolino, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Dominic Farolino
Mark Foltz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mark Foltz . resolved
Looks like a rebaseline is needed for a bunch of WPTs because of the deprecation warning 😋
Dominic Farolino (Gerrit)
11:49 AM (7 hours ago) 11:49 AM
to android-bu...@system.gserviceaccount.com, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Mark Foltz
Dominic Farolino voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dominic Farolino
| Commit-Queue | +1 |
Mark Foltz . resolved
Looks like a rebaseline is needed for a bunch of WPTs because of the deprecation warning 😋
Dominic Farolino
Think I got them all. We'll see if the bots are happy.
File third_party/blink/web_tests/wpt_internal/webmcp/resources/webmcp-helpers.js
This duplicates waitForTool in third_party/blink/web_tests/fast/webmcp/resources/webmcp-helpers.js ...
Dominic Farolino
Yeah so there is some unfortunate duplication, there are three `webmcp-helpers.js` files:
- fast/
- wpt_internal
- external/wpt
The duplication between the first two is what you're commenting on, but I don't think those two types of tests can share files, so it is what it is. The last two technically don't have to be duplicated, so I've removed `wpt_internal/webmcp/resources/webmcp-helpers.js` and updated the internal WPTs to reference the external file. Seems like a good change.
Related details
Attention is currently required from:
- Mark Foltz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Farolino (Gerrit)
12:26 PM (6 hours ago) 12:26 PM
to android-bu...@system.gserviceaccount.com, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Mark Foltz
Dominic Farolino voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Mark Foltz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Farolino (Gerrit)
12:26 PM (6 hours ago) 12:26 PM
to android-bu...@system.gserviceaccount.com, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Mark Foltz
Dominic Farolino voted Commit-Queue+0![]( "Open in Gerrit")
| Commit-Queue | +0 |
Dominic Farolino (Gerrit)
12:39 PM (6 hours ago) 12:39 PM
to android-bu...@system.gserviceaccount.com, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Mark Foltz
Dominic Farolino voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominic Farolino
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Dominic Farolino . resolved
Jetski botched the rebase but I fixed it...
Related details
Attention is currently required from:
- Mark Foltz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Farolino (Gerrit)
1:15 PM (5 hours ago) 1:15 PM
to android-bu...@system.gserviceaccount.com, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Mark Foltz
Dominic Farolino voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Mark Foltz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages