Move common unit tests to foundation [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alex Rudenko (Gerrit)
Nov 3, 2025, 10:18:26 AM (2 days ago) Nov 3
to Natallia Harshunova, devtools-rev...@chromium.org
Attention needed from Natallia Harshunova
Alex Rudenko voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Natallia Harshunova
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Nov 4, 2025, 3:24:35 AM (yesterday) Nov 4
to Simon Zünd, Devtools-frontend LUCI CQ, Natallia Harshunova, devtools-rev...@chromium.org
Attention needed from Natallia Harshunova and Simon Zünd
Alex Rudenko added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Alex Rudenko . resolved
@szu...@chromium.org PTAL as well. Shall we do double type-check right away or are we fine with expecting an error in specific test files.
Related details
Attention is currently required from:
- Natallia Harshunova
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
Nov 4, 2025, 4:26:31 AM (yesterday) Nov 4
to Alex Rudenko, Devtools-frontend LUCI CQ, Natallia Harshunova, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Natallia Harshunova
Simon Zünd voted and added 1 comment![]( "Open in Gerrit")
Votes added by Simon Zünd
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Simon Zünd . resolved
I think we can land this as-is for now. Doing a double-type-check is non-trivial.
Related details
Attention is currently required from:
- Alex Rudenko
- Natallia Harshunova
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Nov 4, 2025, 8:00:42 AM (yesterday) Nov 4
to Simon Zünd, Devtools-frontend LUCI CQ, Natallia Harshunova, devtools-rev...@chromium.org
Attention needed from Natallia Harshunova and Simon Zünd
Alex Rudenko added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 11 (Latest):
Alex Rudenko . resolved
added fixes for the rdb reporter (changed to use fetch and added a timeout + error reporting)
Related details
Attention is currently required from:
- Natallia Harshunova
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
7:43 AM (5 hours ago) 7:43 AM
to Alex Rudenko, Devtools-frontend LUCI CQ, Natallia Harshunova, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Natallia Harshunova
Simon Zünd voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Rudenko
- Natallia Harshunova
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
7:48 AM (5 hours ago) 7:48 AM
to Simon Zünd, Devtools-frontend LUCI CQ, Natallia Harshunova, devtools-rev...@chromium.org
Attention needed from Natallia Harshunova
Alex Rudenko voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Natallia Harshunova
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
8:14 AM (5 hours ago) 8:14 AM
to Alex Rudenko, Simon Zünd, Natallia Harshunova, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Move common unit tests to foundation
The only exception is the base64 decoder that requires the browser
runtime. The CL uses `@ts-expect-error` where tsc is missing types
coming from either DOM or node.js.
Bug: 451502260
Change-Id: Idc90ae547d13df490b622dcf36c58f60cecb01a6
Reviewed-by: Simon Zünd <szu...@chromium.org>
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Files:
- M front_end/BUILD.gn
- M front_end/core/common/BUILD.gn
- A front_end/core/common/Base64.browser.test.ts
- M front_end/core/common/Base64.test.ts
- M front_end/core/common/CharacterIdMap.test.ts
- M front_end/core/common/Debouncer.test.ts
- M front_end/core/common/Debouncer.ts
- M front_end/core/common/Gzip.test.ts
- M front_end/core/common/Gzip.ts
- M front_end/core/common/Mutex.test.ts
- M front_end/core/common/ResourceType.test.ts
- M front_end/core/common/SettingRegistration.test.ts
- M front_end/core/common/Throttler.test.ts
- M front_end/core/common/Throttler.ts
- M front_end/services/puppeteer/PuppeteerConnection.ts
- M test/conductor/resultsdb.ts
Change size: M
Delta: 16 files changed, 72 insertions(+), 46 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Simon Zünd
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages