Wire up JXL decoder. [chromium/src : main]

0 views
Skip to first unread message

Helmut Januschka (Gerrit)

unread,
Dec 25, 2025, 5:19:26 PM (15 hours ago) Dec 25
to Helmut Januschka, ccameron chromium, Vladimir Levin, Dave Tapuska, Luca Versari, Hans Wennborg, Łukasz Anforowicz, Dale Curtis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, kinuko+...@chromium.org, jmedle...@chromium.org, asvitki...@chromium.org, jshin...@chromium.org, fserb...@chromium.org, asvitkine...@chromium.org, drott+bl...@chromium.org, csharris...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, cc-...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org
Attention needed from Dave Tapuska, Hans Wennborg, Luca Versari, Philip Jägenstedt, ccameron chromium and mmenke

Helmut Januschka added 1 comment

Patchset-level comments
File-level comment, Patchset 55:
ccameron chromium . resolved

I would also highly recommend breaking this into a couple CLs.

Like -- you can land a CL that just adds the flags and various enum values for JXL, while not actually adding the codec right now, cause that stuff is mostly mechanical.

Then a second CL could add the codec decoder itself (which would need more scrutiny). And also, if there is any build breakage, the revert would be less painful.

Helmut Januschka

thanks, did it now, feel free to tell me if the split you had in mind was different!

Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
  • Hans Wennborg
  • Luca Versari
  • Philip Jägenstedt
  • ccameron chromium
  • mmenke
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0e3570202b06cf3fbbc1c5dc13f3109b21648f30
Gerrit-Change-Number: 7184969
Gerrit-PatchSet: 67
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Hans Wennborg <ha...@chromium.org>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Luca Versari <vel...@google.com>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
Gerrit-Reviewer: mmenke <mme...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dale Curtis <dalec...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Philip Jägenstedt <foo...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-Attention: Hans Wennborg <ha...@chromium.org>
Gerrit-Attention: mmenke <mme...@chromium.org>
Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Attention: Luca Versari <vel...@google.com>
Gerrit-Comment-Date: Thu, 25 Dec 2025 22:19:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ccameron chromium <ccam...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages