Remove TrackingProtectionSettings references outside of PS directory [chromium/src : main]

1 view
Skip to first unread message

Fiona Macintosh (Gerrit)

unread,
Dec 18, 2025, 2:30:36 PM (3 days ago) Dec 18
to chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, amaliev+...@chromium.org, cfredri...@chromium.org, dullweb...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, njeunje+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org

Fiona Macintosh voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If1ee80e79c5ec2d043f141f2328fe2a0da3ed8f2
Gerrit-Change-Number: 7275851
Gerrit-PatchSet: 1
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 19:30:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fiona Macintosh (Gerrit)

unread,
Dec 18, 2025, 2:35:26 PM (3 days ago) Dec 18
to Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, amaliev+...@chromium.org, cfredri...@chromium.org, dullweb...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, njeunje+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org

Fiona Macintosh voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If1ee80e79c5ec2d043f141f2328fe2a0da3ed8f2
Gerrit-Change-Number: 7275851
Gerrit-PatchSet: 2
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 19:35:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fiona Macintosh (Gerrit)

unread,
Dec 18, 2025, 2:43:38 PM (3 days ago) Dec 18
to Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, amaliev+...@chromium.org, cfredri...@chromium.org, dullweb...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, njeunje+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org

Fiona Macintosh voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If1ee80e79c5ec2d043f141f2328fe2a0da3ed8f2
Gerrit-Change-Number: 7275851
Gerrit-PatchSet: 3
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 19:43:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fiona Macintosh (Gerrit)

unread,
Dec 18, 2025, 2:53:38 PM (3 days ago) Dec 18
to Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, amaliev+...@chromium.org, cfredri...@chromium.org, dullweb...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, njeunje+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org

Fiona Macintosh voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If1ee80e79c5ec2d043f141f2328fe2a0da3ed8f2
Gerrit-Change-Number: 7275851
Gerrit-PatchSet: 4
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 19:53:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fiona Macintosh (Gerrit)

unread,
Dec 19, 2025, 8:53:12 AM (2 days ago) Dec 19
to Ryan Sultanem, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, amaliev+...@chromium.org, cfredri...@chromium.org, dullweb...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, njeunje+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org

Fiona Macintosh voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If1ee80e79c5ec2d043f141f2328fe2a0da3ed8f2
Gerrit-Change-Number: 7275851
Gerrit-PatchSet: 5
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Ryan Sultanem <rs...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 13:53:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fiona Macintosh (Gerrit)

unread,
Dec 19, 2025, 10:07:07 AM (2 days ago) Dec 19
to Ryan Sultanem, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, amaliev+...@chromium.org, cfredri...@chromium.org, dullweb...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, njeunje+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org

Fiona Macintosh voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If1ee80e79c5ec2d043f141f2328fe2a0da3ed8f2
Gerrit-Change-Number: 7275851
Gerrit-PatchSet: 6
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Ryan Sultanem <rs...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 15:07:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fiona Macintosh (Gerrit)

unread,
Dec 19, 2025, 10:23:07 AM (2 days ago) Dec 19
to Ryan Sultanem, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, amaliev+...@chromium.org, cfredri...@chromium.org, dullweb...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, njeunje+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org

Fiona Macintosh voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If1ee80e79c5ec2d043f141f2328fe2a0da3ed8f2
Gerrit-Change-Number: 7275851
Gerrit-PatchSet: 7
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Ryan Sultanem <rs...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 15:23:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Josh Karlin (Gerrit)

unread,
Dec 19, 2025, 12:02:54 PM (2 days ago) Dec 19
to Fiona Macintosh, Josh Karlin, Christian Dullweber, Avi Drissman, Ryan Sultanem, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, amaliev+...@chromium.org, cfredri...@chromium.org, dullweb...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, njeunje+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org
Attention needed from Avi Drissman, Christian Dullweber and Fiona Macintosh

Josh Karlin voted and added 1 comment

Votes added by Josh Karlin

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Josh Karlin . resolved

topics and subresource_filter lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
  • Christian Dullweber
  • Fiona Macintosh
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If1ee80e79c5ec2d043f141f2328fe2a0da3ed8f2
    Gerrit-Change-Number: 7275851
    Gerrit-PatchSet: 8
    Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
    Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-CC: Ryan Sultanem <rs...@google.com>
    Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Attention: Christian Dullweber <dull...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 17:02:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    Dec 19, 2025, 12:18:54 PM (2 days ago) Dec 19
    to Fiona Macintosh, Avi Drissman, Josh Karlin, Christian Dullweber, Ryan Sultanem, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, amaliev+...@chromium.org, cfredri...@chromium.org, dullweb...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, njeunje+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org
    Attention needed from Christian Dullweber and Fiona Macintosh

    Avi Drissman voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christian Dullweber
    • Fiona Macintosh
    Gerrit-Attention: Christian Dullweber <dull...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 17:18:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    gwsq (Gerrit)

    unread,
    Dec 20, 2025, 10:17:39 AM (yesterday) Dec 20
    to Fiona Macintosh, Chrome Signin Team, Mihai Sardarescu, Avi Drissman, Josh Karlin, Christian Dullweber, Ryan Sultanem, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, amaliev+...@chromium.org, cfredri...@chromium.org, dullweb...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, liu+wa...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, njeunje+...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org
    Attention needed from Christian Dullweber and Mihai Sardarescu

    Message from gwsq

    Reviewer source(s):
    msa...@chromium.org is from context(googleclient/chrome/chromium_gwsq/components/signin/config.gwsq)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christian Dullweber
    • Mihai Sardarescu
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If1ee80e79c5ec2d043f141f2328fe2a0da3ed8f2
      Gerrit-Change-Number: 7275851
      Gerrit-PatchSet: 9
      Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
      Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
      Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
      Gerrit-Reviewer: Mihai Sardarescu <msa...@chromium.org>
      Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-CC: Ryan Sultanem <rs...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Mihai Sardarescu <msa...@chromium.org>
      Gerrit-Attention: Christian Dullweber <dull...@chromium.org>
      Gerrit-Comment-Date: Sat, 20 Dec 2025 15:16:54 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages