Use Luci env for detecting bots [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Nikolay Vitkov (Gerrit)

unread,
5:05 AM (7 hours ago) 5:05 AM
to Wolfgang Beyer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Wolfgang Beyer

Nikolay Vitkov voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Wolfgang Beyer
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I7d8398439aee2011235f444c469e149b1a624963
Gerrit-Change-Number: 7562071
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Wolfgang Beyer <wo...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Wolfgang Beyer <wo...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Feb 2026 10:05:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Wolfgang Beyer (Gerrit)

unread,
5:11 AM (7 hours ago) 5:11 AM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov

Wolfgang Beyer voted and added 1 comment

Votes added by Wolfgang Beyer

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Wolfgang Beyer . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Nikolay Vitkov
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I7d8398439aee2011235f444c469e149b1a624963
    Gerrit-Change-Number: 7562071
    Gerrit-PatchSet: 1
    Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-Reviewer: Wolfgang Beyer <wo...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 10:11:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Wolfgang Beyer (Gerrit)

    unread,
    6:02 AM (6 hours ago) 6:02 AM
    to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
    Attention needed from Nikolay Vitkov

    Wolfgang Beyer voted

    Code-Review+1
    Commit-Queue+2
    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nikolay Vitkov
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I7d8398439aee2011235f444c469e149b1a624963
    Gerrit-Change-Number: 7562071
    Gerrit-PatchSet: 2
    Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-Reviewer: Wolfgang Beyer <wo...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 11:02:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Devtools-frontend LUCI CQ (Gerrit)

    unread,
    6:25 AM (6 hours ago) 6:25 AM
    to Nikolay Vitkov, Wolfgang Beyer, devtools-rev...@chromium.org

    Devtools-frontend LUCI CQ submitted the change

    Change information

    Commit message:
    Use Luci env for detecting bots

    Like other places we try to look up the LUCI_CONTEXT env to know
    if we are running on a bot. Then disable all caches and add more logs.
    Bug: none
    Change-Id: I7d8398439aee2011235f444c469e149b1a624963
    Auto-Submit: Nikolay Vitkov <nvi...@chromium.org>
    Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
    Commit-Queue: Wolfgang Beyer <wo...@chromium.org>
    Reviewed-by: Wolfgang Beyer <wo...@chromium.org>
    Owners-Override: Wolfgang Beyer <wo...@chromium.org>
    Files:
    • M scripts/test/run_lint_check.mjs
    Change size: XS
    Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Wolfgang Beyer
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I7d8398439aee2011235f444c469e149b1a624963
    Gerrit-Change-Number: 7562071
    Gerrit-PatchSet: 3
    Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
    Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages