[PATCH 3/4] Revert "compute pressure: Add OwnContributionEstimate to API." [chromium/src : main]
1 view
Skip to first unread message
Reilly Grant (Gerrit)
May 20, 2026, 2:09:25 PM (4 days ago) May 20
to Wang, Wei4, Reilly Grant, Matt Reynolds, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Matt Reynolds and Wang, Wei4
Reilly Grant voted and added 1 comment![]( "Open in Gerrit")
Votes added by Reilly Grant
| Code-Review | +1 |
Related details
Attention is currently required from:
- Matt Reynolds
- Wang, Wei4
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reynolds (Gerrit)
May 20, 2026, 2:21:15 PM (4 days ago) May 20
to Wang, Wei4, Reilly Grant, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Wang, Wei4
Matt Reynolds voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matt Reynolds
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Wang, Wei4
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
May 21, 2026, 2:07:58 AM (4 days ago) May 21
to Wang, Wei4, Philip Jägenstedt, Matt Reynolds, Reilly Grant, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Philip Jägenstedt and Wang, Wei4
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Philip Jägenstedt
- Wang, Wei4
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Jägenstedt (Gerrit)
May 22, 2026, 8:50:06 AM (2 days ago) May 22
to Wang, Wei4, Ian Vollick, Alex Rudenko, Matt Reynolds, Reilly Grant, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Ian Vollick and Wang, Wei4
Philip Jägenstedt voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Jägenstedt
| Code-Review | +1 |
1 comment
Patchset-level comments
Philip Jägenstedt . resolved
third_party/blink/renderer/platform/runtime_enabled_features.json5 LGTM
Related details
Attention is currently required from:
- Ian Vollick
- Wang, Wei4
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Vollick (Gerrit)
May 22, 2026, 10:52:07 AM (2 days ago) May 22
to Wang, Wei4, Philip Jägenstedt, Alex Rudenko, Matt Reynolds, Reilly Grant, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Wang, Wei4
Ian Vollick voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Wang, Wei4
Chromium LUCI CQ (Gerrit)
May 23, 2026, 7:13:58 AM (yesterday) May 23
to Wang, Wei4, Ian Vollick, Philip Jägenstedt, Alex Rudenko, Matt Reynolds, Reilly Grant, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[PATCH 3/4] Revert "compute pressure: Add OwnContributionEstimate to API."
This reverts commit 07a693411a90509f07cc0cc59c93684262c5d902.
This feature is creating information leak. There is no active
development on this feature anymore, therefore it was decided to
revert the patches related to this feature.
Bug: 513009005
Change-Id: I3e57e1fb6d4160539c6c46ca5bd96bbd4468dbb2
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Wang, Wei4 <wei4...@intel.com>
Reviewed-by: Reilly Grant <rei...@chromium.org>
Reviewed-by: Matt Reynolds <mattre...@chromium.org>
Reviewed-by: Philip Jägenstedt <foo...@chromium.org>
Reviewed-by: Ian Vollick <vol...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1635414}
Files:
- M chrome/test/chromedriver/client/chromedriver.py
- M chrome/test/chromedriver/session_commands.cc
- M chrome/test/chromedriver/test/run_py_tests.py
- M content/browser/devtools/protocol/emulation_handler.cc
- M content/browser/devtools/protocol/emulation_handler.h
- M content/browser/devtools/protocol_config.json
- M third_party/blink/public/devtools_protocol/domains/Emulation.pdl
- M third_party/blink/renderer/modules/compute_pressure/pressure_client_impl.cc
- M third_party/blink/renderer/modules/compute_pressure/pressure_observer.cc
- M third_party/blink/renderer/modules/compute_pressure/pressure_observer.h
- M third_party/blink/renderer/modules/compute_pressure/pressure_record.cc
- M third_party/blink/renderer/modules/compute_pressure/pressure_record.h
- M third_party/blink/renderer/modules/compute_pressure/pressure_record.idl
- M third_party/blink/renderer/modules/compute_pressure/testing/internals_compute_pressure.cc
- M third_party/blink/renderer/modules/compute_pressure/testing/internals_compute_pressure.h
- M third_party/blink/renderer/modules/compute_pressure/testing/internals_compute_pressure.idl
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/FlagSpecificConfig
- M third_party/blink/web_tests/external/wpt/compute-pressure/compute_pressure_basic.https.window.js
- M third_party/blink/web_tests/external/wpt/compute-pressure/compute_pressure_duplicate_updates.https.window.js
- M third_party/blink/web_tests/external/wpt/compute-pressure/resources/worker-support.js
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/pressure-override-dedicated-worker-basics-expected.txt
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/pressure-override-dedicated-worker-basics.js
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/pressure-override-enabled-false-print-info-message-expected.txt
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/pressure-override-enabled-false-print-info-message.js
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/pressure-override-multiple-updates-delivery-expected.txt
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/pressure-override-multiple-updates-delivery.js
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/pressure-override-update-delivery-expected.txt
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/pressure-override-update-delivery.js
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/pressure-override-update-not-overridden.js
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/pressure-overrides-persist-across-navigations-expected.txt
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/pressure-overrides-persist-across-navigations.js
- M third_party/blink/web_tests/http/tests/inspector-protocol/emulation/resources/pressure-observer-worker.js
- M third_party/blink/web_tests/resources/testdriver-vendor.js
- M third_party/blink/web_tests/resources/testdriver.js
- M third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
- M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
- M third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
Change size: L
Delta: 38 files changed, 59 insertions(+), 204 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Philip Jägenstedt, +1 by Ian Vollick, +1 by Reilly Grant, +1 by Alex Rudenko, +1 by Matt Reynolds
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages