Make the "DPR" label visible/invisible along with the device scale factor dropdown. [devtools/devtools-frontend : main]

0 views

Skip to first unread message

Danil Somsikov (Gerrit)

unread,

Apr 13, 2026, 10:32:24 AM (6 days ago) Apr 13

to android-bu...@system.gserviceaccount.com, Philip Pfaffe, devtools-rev...@chromium.org

Attention needed from Philip Pfaffe

Danil Somsikov voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Philip Pfaffe

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Philip Pfaffe (Gerrit)

unread,

Apr 14, 2026, 3:51:35 AM (5 days ago) Apr 14

to Danil Somsikov, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org

Attention needed from Danil Somsikov

Philip Pfaffe voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Apr 14, 2026, 3:53:47 AM (5 days ago) Apr 14

to Danil Somsikov, Philip Pfaffe, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org

devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

Make the "DPR" label visible/invisible along with the device scale factor dropdown.

The device scale factor setting consists of a "DPR" label and a combobox. Previously, only the combobox's visibility was controlled by the setting. This change ensures that both the label and the combobox are hidden or shown together when the "Show device pixel ratio" setting is toggled.

This will be much more elegant once we migrate to the declarative rendering.

Bug: 502114194

Change-Id: I45214d4b934d9fab89611618a54552e766b6c4ef

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7751831

Auto-Submit: Danil Somsikov <d...@chromium.org>

Commit-Queue: Philip Pfaffe <pfa...@chromium.org>

Reviewed-by: Philip Pfaffe <pfa...@chromium.org>

Files:

M front_end/panels/emulation/DeviceModeToolbar.ts

Change size: S

Delta: 1 file changed, 13 insertions(+), 4 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Philip Pfaffe

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages