Make screen reader announce expanded/colllapsed state for recorder replay settings [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Sylvester Elorm Coch (Gerrit)

unread,
Dec 23, 2025, 3:04:45 AM (3 days ago) Dec 23
to Jack Franklin, devtools-rev...@chromium.org
Attention needed from Jack Franklin

Sylvester Elorm Coch added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Sylvester Elorm Coch . resolved

@jacktf...@chromium.org Could you ptal? Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I40860490ac321a44d70caa5af0421f68ae25fc25
Gerrit-Change-Number: 7298546
Gerrit-PatchSet: 3
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Dec 2025 08:04:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Jack Franklin (Gerrit)

unread,
Dec 23, 2025, 4:24:58 AM (3 days ago) Dec 23
to Sylvester Elorm Coch, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Sylvester Elorm Coch

Jack Franklin voted and added 1 comment

Votes added by Jack Franklin

Code-Review+1

1 comment

Patchset-level comments
Jack Franklin . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Sylvester Elorm Coch
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I40860490ac321a44d70caa5af0421f68ae25fc25
Gerrit-Change-Number: 7298546
Gerrit-PatchSet: 3
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 09:24:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sylvester Elorm Coch (Gerrit)

unread,
Dec 23, 2025, 2:03:48 PM (3 days ago) Dec 23
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Sylvester Elorm Coch voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I40860490ac321a44d70caa5af0421f68ae25fc25
Gerrit-Change-Number: 7298546
Gerrit-PatchSet: 3
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 19:03:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
Dec 24, 2025, 5:44:55 AM (2 days ago) Dec 24
to Sylvester Elorm Coch, Jack Franklin, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Make screen reader announce expanded/colllapsed state for recorder replay settings

Issue:

When navigating to the 'Replay settings' control using a screen reader,
the state information (such as expanded or collapsed) is not announced.
Users are unaware whether the control is currently expanded or collapsed
after interaction.
Bug: 471098226
Change-Id: I40860490ac321a44d70caa5af0421f68ae25fc25
Reviewed-by: Jack Franklin <jacktf...@chromium.org>
Commit-Queue: Sylvester Elorm Coch <elor...@microsoft.com>
Files:
  • M front_end/panels/recorder/components/RecordingView.ts
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jack Franklin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I40860490ac321a44d70caa5af0421f68ae25fc25
Gerrit-Change-Number: 7298546
Gerrit-PatchSet: 4
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages