DevTools: Buffer error response body in DevToolsStreamConsumer [chromium/src : main]
1 view
Skip to first unread message
Jack Franklin (Gerrit)
May 14, 2026, 6:50:48 AMMay 14
to Yang Guo, Andrey Kosyakov, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Andrey Kosyakov, Liviu Rau and Yang Guo
Jack Franklin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Jack Franklin . resolved
PTAL. The motivation here is to improve the errors we see in DevTools which have an empty `detail` field:
```
{detail: '', error: 'Request failed', netError: 0, netErrorName: 'net::OK', statusCode: 400}
```
Which makes it nearly impossible to debug.
I am not familiar with the workings of this code and I used AI to help me put the fix together. It makes sense to me but please push back and tell me if we should be approaching this differently.
Related details
Attention is currently required from:
- Andrey Kosyakov
- Liviu Rau
- Yang Guo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
May 14, 2026, 12:37:14 PMMay 14
to Jack Franklin, Yang Guo, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Jack Franklin, Liviu Rau and Yang Guo
Andrey Kosyakov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jack Franklin
- Liviu Rau
- Yang Guo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yang Guo (Gerrit)
May 15, 2026, 1:23:54 AMMay 15
to Jack Franklin, Andrey Kosyakov, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Jack Franklin and Liviu Rau
Yang Guo voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jack Franklin
- Liviu Rau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
May 19, 2026, 11:26:23 AMMay 19
to Yang Guo, Andrey Kosyakov, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Liviu Rau
Jack Franklin voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Liviu Rau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
May 20, 2026, 12:39:34 AMMay 20
to Chromium LUCI CQ, Yang Guo, Andrey Kosyakov, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Andrey Kosyakov, Liviu Rau and Yang Guo
Jack Franklin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Jack Franklin . resolved
PTanotherL - the test failures highlighted that we can't access the headers on the response during the streaming as it might not be complete.
This is not my area of expertise so feedback welcome on better approaches if there is a more conventional way to deal with this.
Related details
Attention is currently required from:
- Andrey Kosyakov
- Liviu Rau
- Yang Guo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yang Guo (Gerrit)
May 20, 2026, 2:59:05 AMMay 20
to Jack Franklin, Danil Somsikov, Chromium LUCI CQ, Andrey Kosyakov, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Andrey Kosyakov, Danil Somsikov, Jack Franklin and Liviu Rau
Yang Guo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Andrey Kosyakov
- Danil Somsikov
- Jack Franklin
- Liviu Rau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
May 20, 2026, 3:24:20 AMMay 20
to Jack Franklin, Chromium LUCI CQ, Yang Guo, Andrey Kosyakov, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Andrey Kosyakov, Jack Franklin and Liviu Rau
Danil Somsikov added 1 comment![]( "Open in Gerrit")
File chrome/browser/devtools/devtools_http_service_handler.cc
Line 56, Patchset 7 (Latest):
size_t bytes_to_append = std::min(Danil Somsikov . unresolved
Consider adding `#include <algorithm>` at the top of the file since `std::min` is used here. While it likely compiles due to transitive includes from other headers, it's generally a good practice to include it explicitly.
Related details
Attention is currently required from:
- Andrey Kosyakov
- Jack Franklin
- Liviu Rau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
May 20, 2026, 3:24:53 AMMay 20
to Jack Franklin, Chromium LUCI CQ, Yang Guo, Andrey Kosyakov, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Andrey Kosyakov, Jack Franklin and Liviu Rau
Danil Somsikov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andrey Kosyakov
- Jack Franklin
- Liviu Rau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
May 21, 2026, 11:25:12 AMMay 21
to Danil Somsikov, Chromium LUCI CQ, Yang Guo, Andrey Kosyakov, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Andrey Kosyakov, Danil Somsikov and Liviu Rau
Jack Franklin added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File chrome/browser/devtools/devtools_http_service_handler.cc
Consider adding `#include <algorithm>` at the top of the file since `std::min` is used here. While it likely compiles due to transitive includes from other headers, it's generally a good practice to include it explicitly.
Attention is currently required from:
- Andrey Kosyakov
- Danil Somsikov
- Liviu Rau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
May 21, 2026, 8:49:40 PMMay 21
to Jack Franklin, Danil Somsikov, Chromium LUCI CQ, Yang Guo, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Danil Somsikov, Jack Franklin and Liviu Rau
Andrey Kosyakov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
2 comments
Patchset-level comments
Andrey Kosyakov . resolved
re-stamping with a nit
File chrome/browser/devtools/devtools_http_service_handler.cc
Line 246, Patchset 8 (Latest):
request.consumer->GetWeakPtr()));Andrey Kosyakov . unresolved
nit: I imagine we don't really need a week ptr here, as the request would be retaining consumer until at least the response has started :-)
Related details
Attention is currently required from:
- Danil Somsikov
- Jack Franklin
- Liviu Rau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
May 22, 2026, 1:18:31 PMMay 22
to Andrey Kosyakov, Danil Somsikov, Chromium LUCI CQ, Yang Guo, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Andrey Kosyakov, Danil Somsikov and Liviu Rau
Jack Franklin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jack Franklin
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Jack Franklin . resolved
Thank you for the feedback - PTanotherL 😊
File chrome/browser/devtools/devtools_http_service_handler.cc
nit: I imagine we don't really need a week ptr here, as the request would be retaining consumer until at least the response has started :-)
Attention is currently required from:
- Andrey Kosyakov
- Danil Somsikov
- Liviu Rau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
May 22, 2026, 1:20:31 PMMay 22
to Jack Franklin, Danil Somsikov, Chromium LUCI CQ, Yang Guo, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Danil Somsikov, Jack Franklin and Liviu Rau
Andrey Kosyakov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Danil Somsikov
- Jack Franklin
- Liviu Rau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
May 22, 2026, 3:18:18 PMMay 22
to Jack Franklin, Danil Somsikov, Chromium LUCI CQ, Yang Guo, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Danil Somsikov, Jack Franklin and Liviu Rau
Andrey Kosyakov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Danil Somsikov
- Jack Franklin
- Liviu Rau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
May 27, 2026, 10:38:16 AMMay 27
to Jack Franklin, Code Review Nudger, Andrey Kosyakov, Danil Somsikov, Chromium LUCI CQ, Yang Guo, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Danil Somsikov, Jack Franklin and Liviu Rau
Nikolay Vitkov voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Danil Somsikov
- Jack Franklin
- Liviu Rau
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mathias Bynens (Gerrit)
May 27, 2026, 10:48:09 AMMay 27
to Jack Franklin, Nikolay Vitkov, Code Review Nudger, Andrey Kosyakov, Danil Somsikov, Chromium LUCI CQ, Yang Guo, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Danil Somsikov, Jack Franklin, Liviu Rau and Nikolay Vitkov
Mathias Bynens voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Danil Somsikov
- Jack Franklin
- Liviu Rau
- Nikolay Vitkov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
May 27, 2026, 11:50:14 AMMay 27
to Mathias Bynens, Nikolay Vitkov, Code Review Nudger, Andrey Kosyakov, Danil Somsikov, Chromium LUCI CQ, Yang Guo, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Andrey Kosyakov, Danil Somsikov, Liviu Rau, Mathias Bynens and Nikolay Vitkov
Jack Franklin voted![]( "Open in Gerrit")
Attention is currently required from:
- Andrey Kosyakov
- Danil Somsikov
- Liviu Rau
- Mathias Bynens
- Nikolay Vitkov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
May 28, 2026, 2:06:34 AMMay 28
to Jack Franklin, Mathias Bynens, Nikolay Vitkov, Code Review Nudger, Andrey Kosyakov, Danil Somsikov, Chromium LUCI CQ, Yang Guo, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Andrey Kosyakov, Danil Somsikov, Jack Franklin, Liviu Rau, Mathias Bynens and Nikolay Vitkov
Alex Rudenko voted![]( "Open in Gerrit")
Attention is currently required from:
- Andrey Kosyakov
- Danil Somsikov
- Jack Franklin
- Liviu Rau
- Mathias Bynens
- Nikolay Vitkov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
May 28, 2026, 4:48:57 AMMay 28
to Jack Franklin, Alex Rudenko, Mathias Bynens, Code Review Nudger, Andrey Kosyakov, Danil Somsikov, Chromium LUCI CQ, Yang Guo, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Attention needed from Andrey Kosyakov, Danil Somsikov, Jack Franklin, Liviu Rau and Mathias Bynens
Nikolay Vitkov voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Andrey Kosyakov
- Danil Somsikov
- Jack Franklin
- Liviu Rau
- Mathias Bynens
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 28, 2026, 4:52:06 AMMay 28
to Jack Franklin, Nikolay Vitkov, Alex Rudenko, Mathias Bynens, Code Review Nudger, Andrey Kosyakov, Danil Somsikov, Yang Guo, Liviu Rau, android-bu...@system.gserviceaccount.com, devtools...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
DevTools: Buffer error response body in DevToolsStreamConsumer
When a streaming HTTP request dispatched via DispatchHttpRequestClient
fails (e.g., with a 400 error), the error response body was not being
captured by DevToolsStreamConsumer. This led to an empty "detail" field
in the error object logged on the DevTools frontend.
This CL updates DevToolsStreamConsumer to accumulate response chunks
when the status code represents an HTTP error. Upon completion, this
accumulated body is assigned to `result->response_body`. This makes
error payloads available under the "detail" field in the frontend,
matching the existing behavior of non-streamed requests.
Bug: 511084296
Change-Id: I7aeebffa894f33532ce441bf00047af9febb4496
Auto-Submit: Jack Franklin <jacktf...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Nikolay Vitkov <nvi...@chromium.org>
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1637548}
Files:
- M chrome/browser/devtools/devtools_http_service_handler.cc
- M chrome/browser/devtools/devtools_http_service_handler_unittest.cc
Change size: S
Delta: 2 files changed, 38 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nikolay Vitkov, +1 by Alex Rudenko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages