[Contextual Tasks] Hide the lens button when in full tab [chromium/src : main]

0 views
Skip to first unread message

Josiah Kiehl (Gerrit)

unread,
Dec 22, 2025, 8:20:36 PM (3 days ago) Dec 22
to James Maclean, David Bokan, Kevin Babbitt, Chromium Metrics Reviews, Wang, Wei4, Christian Biesinger, Victor Tan, Simon Hangl, Ian Vollick, Peter Williamson, Ryan Sultanem, Jiewei Qian, Olga Gerchikov, Nate Chapin, Stephen Chenney, Menard, Alexis, Urvang Joshi, Avi Drissman, srirama chandra sekhar, Mirko Bonadei, Yoav Weiss (@Shopify), Javier Fernandez, Hans Wennborg, Rijubrata Bhaumik, Nikhil Nayunigari, Hu, Ningxin, Hiroki Nakagawa, Mike Taylor, Daniel Cheng, Kaan Icer, Peter Beverloo, Dirk Schulze, Andrew Rayskiy, Sadrul Chowdhury, Zijie He, Kenneth R Christiansen, Dirk Pranke, Raphael Kubo da Costa, Arnaud Mandy, Kentaro Hara, James Su, Enterprise Policy Reviews, Hongchan Choi, Jerome Jiang, (Julie)Jeongeun Kim, AyeAye, Juan Mojica, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, feature-me...@chromium.org, mpdento...@chromium.org, jdeblas...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, iwells...@chromium.org, extension...@chromium.org, sky+...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, gavin...@chromium.org, srahim...@chromium.org, erickun...@chromium.org, fdoray...@chromium.org, cros-setti...@google.com, xinghui...@chromium.org, jackshira+w...@google.com, rginda...@chromium.org, fenced-fra...@chromium.org, halliwe...@chromium.org, jiajunz+wat...@google.com, prerenderi...@chromium.org, nyquis...@chromium.org, derinel+wat...@google.com, ios-web-view...@google.com, martijn...@martijnc.be, ios-revie...@chromium.org, alexmo...@chromium.org, hanxi...@chromium.org, ashleynewson+w...@chromium.org, francisjp...@google.com, blink-rev...@chromium.org, webapks-...@chromium.org, liu+wa...@chromium.org, jbauma...@chromium.org, kuragin+web-ap...@chromium.org, tluk+...@chromium.org, penghu...@chromium.org, filesapp...@chromium.org, dmurph+watch...@chromium.org, vakh+safe_br...@chromium.org, print-rev...@chromium.org, tgupta...@chromium.org, blink-re...@chromium.org, dcheng+c...@chromium.org, crmulli...@chromium.org, cbe-cep-eng...@google.com, jorgel...@chromium.org, chromium-a...@chromium.org, yhanad...@chromium.org, shgar+aut...@google.com, ios-rev...@chromium.org, eme-r...@chromium.org, asumane...@google.com, ortuno+w...@chromium.org, cros-report...@google.com, yuezhang...@chromium.org, ajwong...@chromium.org, dtapuska+ch...@chromium.org, rrsilva+wat...@google.com, jmedle...@chromium.org, donnd...@chromium.org, lwinston+watc...@google.com, kmg+...@google.com, ejcaruso+wa...@chromium.org, speed-metr...@chromium.org, njeunje+...@chromium.org, kenok...@google.com, croissant-...@chromium.org, loyso...@chromium.org, jeffreycohen+watc...@chromium.org, creis...@chromium.org, headless...@chromium.org, cwalle...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, chrome-waff...@google.com, siyua+aut...@chromium.org, spang...@chromium.org, siashah+au...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, marimatthew+watc...@google.com, armalhotra+a...@google.com, chrome-intelligence-te...@google.com, jshin...@chromium.org, core-timi...@chromium.org, jatapiaro+wat...@google.com, subresource-f...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, feature-v...@chromium.org, shimazu...@chromium.org, davidj...@chromium.org, cros-enterpris...@chromium.org, chromeos-kio...@google.com, blink-reviews-p...@chromium.org, devtools...@chromium.org, niharm...@google.com, grt+...@chromium.org, apavlo...@chromium.org, jophba...@chromium.org, edgesto...@microsoft.com, tranbaod...@chromium.org, druber...@chromium.org, zol...@webkit.org, hirokisa...@chromium.org, chrome-intell...@chromium.org, toyosh...@chromium.org, gavinp...@chromium.org, kainin...@chromium.org, ayman...@chromium.org, yhiran...@chromium.org, dfried...@chromium.org, jackshira+wa...@google.com, chlily...@chromium.org, dewitt...@chromium.org, lens-chrome...@google.com, jdh+wa...@chromium.org, eic+...@google.com, penghuan...@chromium.org, bmcquad...@chromium.org, mercer...@google.com, giovax...@chromium.org, dmurph+wat...@chromium.org, lizeb...@chromium.org, mar...@chromium.org, chrome-tab-group-en...@google.com, rmcelra...@chromium.org, lighthouse-eng-extern...@google.com, permissio...@chromium.org, peilinwa...@google.com, jessemcke...@google.com, borealis-re...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, moqati-team+chr...@google.com, katie...@chromium.org, dtapuska+...@chromium.org, khorimoto+wa...@chromium.org, drott+bl...@chromium.org, petewi...@chromium.org, kouhei...@chromium.org, dmurph+wa...@chromium.org, jz...@chromium.org, asvitkine...@chromium.org, apaselti...@chromium.org, nwoked...@chromium.org, npm+...@chromium.org, stanfie...@google.com, enne...@chromium.org, thefro...@chromium.org, keithle...@chromium.org, roagarw...@chromium.org, blink-revi...@chromium.org, anastas...@google.com, crostin...@chromium.org, fuzzin...@chromium.org, tracing...@chromium.org, cblume...@chromium.org, jdonnel...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, sloboda...@chromium.org, blink-rev...@chromium.org, pkotwic...@chromium.org, chromotin...@chromium.org, dtraino...@chromium.org, harringt...@chromium.org, jonmann+wa...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, blink-revi...@chromium.org, ffred...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, twifka...@chromium.org, zackha...@chromium.org, cfredri...@chromium.org, jasonrobe...@google.com, scheduler...@chromium.org, ramyagopa...@google.com, csharris...@chromium.org, chromiumme...@microsoft.com, ydago...@chromium.org, tbarzi...@chromium.org, scheduler-...@chromium.org, horo+...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, olka+...@chromium.org, dominicc+...@chromium.org, ricea...@chromium.org, fmalit...@chromium.org, hsuregan+wat...@chromium.org, kinuko+ser...@chromium.org, yusufo...@chromium.org, ozone-...@chromium.org, michaelchec...@google.com, dmurph+watc...@chromium.org, rkgibso...@chromium.org, gogeral...@chromium.org, shannc...@chromium.org, chadduffin+w...@chromium.org, chadduffin+wa...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, yuzo+...@chromium.org, shimazu+se...@chromium.org, twelling...@chromium.org, chfreme...@chromium.org, aleventh...@chromium.org, omnibox-...@chromium.org, blink-...@chromium.org, amaliev+...@chromium.org, cros-print...@google.com, marinacio...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, torne...@chromium.org, meilian...@chromium.org, osaul+aut...@google.com, droger+w...@chromium.org, boujan...@google.com, johnche...@chromium.org, svend+w...@chromium.org, net-r...@chromium.org, estali...@chromium.org, thegreenf...@chromium.org, webauthn...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, ntp-dev...@chromium.org, rsesek...@chromium.org, abigailbk...@google.com, bcb+watch-pl...@chromium.org, dibyapal+wa...@chromium.org, gangwu...@chromium.org, pasko...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, ananyasee...@google.com, phoglun...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, knollr+wat...@chromium.org, yigu+...@chromium.org, jkeitel+watch-...@google.com, kenjibah...@chromium.org, dullweb...@chromium.org, chrome-gr...@chromium.org, blink-re...@chromium.org, dmurph+watching...@chromium.org, tmartino+tran...@chromium.org, mfoltz+wa...@chromium.org, hansberry+wa...@chromium.org, chromeos-ca...@google.com, max+watc...@igalia.com, shuche...@chromium.org, nicolas...@chromium.org, estaab...@chromium.org, web-schedulin...@chromium.org, bnc+...@chromium.org, mickeybu...@chromium.org, christia...@chromium.org, cambickel...@google.com, roblia...@chromium.org, gavin...@chromium.org, mattreyno...@chromium.org, stevenjb+wa...@chromium.org, nona+...@chromium.org, gab+...@chromium.org, webap...@microsoft.com, yongshun+...@google.com, dmurph+watchi...@chromium.org, mreichhoff+watc...@chromium.org, bartek...@chromium.org, vasilii+watchlis...@chromium.org, yfriedm...@chromium.org, browser-comp...@chromium.org, ender...@chromium.org, hiroshig...@chromium.org, mdjone...@chromium.org, nickdiego+wa...@igalia.com, pdf-r...@chromium.org, fgal...@chromium.org, asvitki...@chromium.org, lucasrada...@google.com, tburkar...@chromium.org, peter+watch...@chromium.org, chrstn...@google.com, media-cro...@chromium.org, blink-revie...@chromium.org, devtools-re...@chromium.org, gavinp+p...@chromium.org, dom+...@chromium.org, khorimoto+w...@chromium.org, minap+watch-p...@google.com, nator...@chromium.org, hayato...@chromium.org, fuchsia...@chromium.org, trewin...@google.com, yhanada+...@chromium.org, blink-re...@chromium.org, rayanka...@chromium.org, translat...@chromium.org, hsuregan+wa...@chromium.org, media-wi...@chromium.org, nikhilcn+wat...@google.com, jiajunz+wa...@google.com, mgiuca...@chromium.org, philli...@chromium.org, josiah...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, agriev...@chromium.org, vinnypersky+...@google.com, speed-metrics...@chromium.org, yhanada+...@chromium.org, storage...@chromium.org, marq+...@chromium.org, hashimo...@chromium.org, blink-revi...@chromium.org, zelin+watch-we...@chromium.org, language...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, oshima...@chromium.org
Attention needed from Juan Mojica

Josiah Kiehl added 1 comment

File ui/webui/resources/cr_components/composebox/composebox.ts
Line 91, Patchset 10: lensButtonTriggersOverlay: {type: Boolean},
Juan Mojica . unresolved

I don't think we ever expect this button not to trigger the overlay.

Josiah Kiehl

I thought it triggers a file upload in NTP and Omnibox?

Open in Gerrit

Related details

Attention is currently required from:
  • Juan Mojica
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I543f504c6632fad4e2c72bf20d7093857818a164
Gerrit-Change-Number: 7264491
Gerrit-PatchSet: 11
Gerrit-Owner: Josiah Kiehl <ki...@google.com>
Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
Gerrit-Reviewer: Juan Mojica <juanm...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Pranke <dpr...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Ryan Sultanem <rs...@google.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Urvang Joshi <urv...@chromium.org>
Gerrit-CC: Victor Tan <vict...@chromium.org>
Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Juan Mojica <juanm...@google.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 01:20:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Juan Mojica <juanm...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Josiah Kiehl (Gerrit)

unread,
Dec 22, 2025, 8:20:51 PM (3 days ago) Dec 22
to James Maclean, David Bokan, Kevin Babbitt, Chromium Metrics Reviews, Wang, Wei4, Christian Biesinger, Victor Tan, Simon Hangl, Ian Vollick, Peter Williamson, Ryan Sultanem, Jiewei Qian, Olga Gerchikov, Nate Chapin, Stephen Chenney, Menard, Alexis, Urvang Joshi, Avi Drissman, srirama chandra sekhar, Mirko Bonadei, Yoav Weiss (@Shopify), Javier Fernandez, Hans Wennborg, Rijubrata Bhaumik, Nikhil Nayunigari, Hu, Ningxin, Hiroki Nakagawa, Mike Taylor, Daniel Cheng, Kaan Icer, Peter Beverloo, Dirk Schulze, Andrew Rayskiy, Sadrul Chowdhury, Zijie He, Kenneth R Christiansen, Dirk Pranke, Raphael Kubo da Costa, Arnaud Mandy, Kentaro Hara, James Su, Enterprise Policy Reviews, Hongchan Choi, Jerome Jiang, (Julie)Jeongeun Kim, AyeAye, Juan Mojica, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, feature-me...@chromium.org, mpdento...@chromium.org, jdeblas...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, iwells...@chromium.org, extension...@chromium.org, sky+...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, gavin...@chromium.org, srahim...@chromium.org, erickun...@chromium.org, fdoray...@chromium.org, cros-setti...@google.com, xinghui...@chromium.org, jackshira+w...@google.com, rginda...@chromium.org, fenced-fra...@chromium.org, halliwe...@chromium.org, jiajunz+wat...@google.com, prerenderi...@chromium.org, nyquis...@chromium.org, derinel+wat...@google.com, ios-web-view...@google.com, martijn...@martijnc.be, ios-revie...@chromium.org, alexmo...@chromium.org, hanxi...@chromium.org, ashleynewson+w...@chromium.org, francisjp...@google.com, blink-rev...@chromium.org, webapks-...@chromium.org, liu+wa...@chromium.org, jbauma...@chromium.org, kuragin+web-ap...@chromium.org, tluk+...@chromium.org, penghu...@chromium.org, filesapp...@chromium.org, dmurph+watch...@chromium.org, vakh+safe_br...@chromium.org, print-rev...@chromium.org, tgupta...@chromium.org, blink-re...@chromium.org, dcheng+c...@chromium.org, crmulli...@chromium.org, cbe-cep-eng...@google.com, jorgel...@chromium.org, chromium-a...@chromium.org, yhanad...@chromium.org, shgar+aut...@google.com, ios-rev...@chromium.org, eme-r...@chromium.org, asumane...@google.com, ortuno+w...@chromium.org, cros-report...@google.com, yuezhang...@chromium.org, ajwong...@chromium.org, dtapuska+ch...@chromium.org, rrsilva+wat...@google.com, jmedle...@chromium.org, donnd...@chromium.org, lwinston+watc...@google.com, kmg+...@google.com, ejcaruso+wa...@chromium.org, speed-metr...@chromium.org, njeunje+...@chromium.org, kenok...@google.com, croissant-...@chromium.org, loyso...@chromium.org, jeffreycohen+watc...@chromium.org, creis...@chromium.org, headless...@chromium.org, cwalle...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, chrome-waff...@google.com, siyua+aut...@chromium.org, spang...@chromium.org, siashah+au...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, marimatthew+watc...@google.com, armalhotra+a...@google.com, chrome-intelligence-te...@google.com, jshin...@chromium.org, core-timi...@chromium.org, jatapiaro+wat...@google.com, subresource-f...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, feature-v...@chromium.org, shimazu...@chromium.org, davidj...@chromium.org, cros-enterpris...@chromium.org, chromeos-kio...@google.com, blink-reviews-p...@chromium.org, devtools...@chromium.org, niharm...@google.com, grt+...@chromium.org, apavlo...@chromium.org, jophba...@chromium.org, edgesto...@microsoft.com, tranbaod...@chromium.org, druber...@chromium.org, zol...@webkit.org, hirokisa...@chromium.org, chrome-intell...@chromium.org, toyosh...@chromium.org, gavinp...@chromium.org, kainin...@chromium.org, ayman...@chromium.org, yhiran...@chromium.org, dfried...@chromium.org, jackshira+wa...@google.com, chlily...@chromium.org, dewitt...@chromium.org, lens-chrome...@google.com, jdh+wa...@chromium.org, eic+...@google.com, penghuan...@chromium.org, bmcquad...@chromium.org, mercer...@google.com, giovax...@chromium.org, dmurph+wat...@chromium.org, lizeb...@chromium.org, mar...@chromium.org, chrome-tab-group-en...@google.com, rmcelra...@chromium.org, lighthouse-eng-extern...@google.com, permissio...@chromium.org, peilinwa...@google.com, jessemcke...@google.com, borealis-re...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, moqati-team+chr...@google.com, katie...@chromium.org, dtapuska+...@chromium.org, khorimoto+wa...@chromium.org, drott+bl...@chromium.org, petewi...@chromium.org, kouhei...@chromium.org, dmurph+wa...@chromium.org, jz...@chromium.org, asvitkine...@chromium.org, apaselti...@chromium.org, nwoked...@chromium.org, npm+...@chromium.org, stanfie...@google.com, enne...@chromium.org, thefro...@chromium.org, keithle...@chromium.org, roagarw...@chromium.org, blink-revi...@chromium.org, anastas...@google.com, crostin...@chromium.org, fuzzin...@chromium.org, tracing...@chromium.org, cblume...@chromium.org, jdonnel...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, sloboda...@chromium.org, blink-rev...@chromium.org, pkotwic...@chromium.org, chromotin...@chromium.org, dtraino...@chromium.org, harringt...@chromium.org, jonmann+wa...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, blink-revi...@chromium.org, ffred...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, twifka...@chromium.org, zackha...@chromium.org, cfredri...@chromium.org, jasonrobe...@google.com, scheduler...@chromium.org, ramyagopa...@google.com, csharris...@chromium.org, chromiumme...@microsoft.com, ydago...@chromium.org, tbarzi...@chromium.org, scheduler-...@chromium.org, horo+...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, olka+...@chromium.org, dominicc+...@chromium.org, ricea...@chromium.org, fmalit...@chromium.org, hsuregan+wat...@chromium.org, kinuko+ser...@chromium.org, yusufo...@chromium.org, ozone-...@chromium.org, michaelchec...@google.com, dmurph+watc...@chromium.org, rkgibso...@chromium.org, gogeral...@chromium.org, shannc...@chromium.org, chadduffin+w...@chromium.org, chadduffin+wa...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, yuzo+...@chromium.org, shimazu+se...@chromium.org, twelling...@chromium.org, chfreme...@chromium.org, aleventh...@chromium.org, omnibox-...@chromium.org, blink-...@chromium.org, amaliev+...@chromium.org, cros-print...@google.com, marinacio...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, torne...@chromium.org, meilian...@chromium.org, osaul+aut...@google.com, droger+w...@chromium.org, boujan...@google.com, johnche...@chromium.org, svend+w...@chromium.org, net-r...@chromium.org, estali...@chromium.org, thegreenf...@chromium.org, webauthn...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, ntp-dev...@chromium.org, rsesek...@chromium.org, abigailbk...@google.com, bcb+watch-pl...@chromium.org, dibyapal+wa...@chromium.org, gangwu...@chromium.org, pasko...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, ananyasee...@google.com, phoglun...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, knollr+wat...@chromium.org, yigu+...@chromium.org, jkeitel+watch-...@google.com, kenjibah...@chromium.org, dullweb...@chromium.org, chrome-gr...@chromium.org, blink-re...@chromium.org, dmurph+watching...@chromium.org, tmartino+tran...@chromium.org, mfoltz+wa...@chromium.org, hansberry+wa...@chromium.org, chromeos-ca...@google.com, max+watc...@igalia.com, shuche...@chromium.org, nicolas...@chromium.org, estaab...@chromium.org, web-schedulin...@chromium.org, bnc+...@chromium.org, mickeybu...@chromium.org, christia...@chromium.org, cambickel...@google.com, roblia...@chromium.org, gavin...@chromium.org, mattreyno...@chromium.org, stevenjb+wa...@chromium.org, nona+...@chromium.org, gab+...@chromium.org, webap...@microsoft.com, yongshun+...@google.com, dmurph+watchi...@chromium.org, mreichhoff+watc...@chromium.org, bartek...@chromium.org, vasilii+watchlis...@chromium.org, yfriedm...@chromium.org, browser-comp...@chromium.org, ender...@chromium.org, hiroshig...@chromium.org, mdjone...@chromium.org, nickdiego+wa...@igalia.com, pdf-r...@chromium.org, fgal...@chromium.org, asvitki...@chromium.org, lucasrada...@google.com, tburkar...@chromium.org, peter+watch...@chromium.org, chrstn...@google.com, media-cro...@chromium.org, blink-revie...@chromium.org, devtools-re...@chromium.org, gavinp+p...@chromium.org, dom+...@chromium.org, khorimoto+w...@chromium.org, minap+watch-p...@google.com, nator...@chromium.org, hayato...@chromium.org, fuchsia...@chromium.org, trewin...@google.com, yhanada+...@chromium.org, blink-re...@chromium.org, rayanka...@chromium.org, translat...@chromium.org, hsuregan+wa...@chromium.org, media-wi...@chromium.org, nikhilcn+wat...@google.com, jiajunz+wa...@google.com, mgiuca...@chromium.org, philli...@chromium.org, josiah...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, agriev...@chromium.org, vinnypersky+...@google.com, speed-metrics...@chromium.org, yhanada+...@chromium.org, storage...@chromium.org, marq+...@chromium.org, hashimo...@chromium.org, blink-revi...@chromium.org, zelin+watch-we...@chromium.org, language...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, oshima...@chromium.org
Attention needed from Juan Mojica

Josiah Kiehl added 1 comment

File ui/webui/resources/cr_components/composebox/composebox.ts
Line 91, Patchset 10: lensButtonTriggersOverlay: {type: Boolean},
Juan Mojica . unresolved

I don't think we ever expect this button not to trigger the overlay.

Josiah Kiehl

I thought it triggers a file upload in NTP and Omnibox?

Josiah Kiehl

Or perhaps just NTP?

Gerrit-Comment-Date: Tue, 23 Dec 2025 01:20:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Juan Mojica <juanm...@google.com>
Comment-In-Reply-To: Josiah Kiehl <ki...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Juan Mojica (Gerrit)

unread,
Dec 22, 2025, 8:30:36 PM (3 days ago) Dec 22
to Josiah Kiehl, James Maclean, David Bokan, Kevin Babbitt, Chromium Metrics Reviews, Wang, Wei4, Christian Biesinger, Victor Tan, Simon Hangl, Ian Vollick, Peter Williamson, Ryan Sultanem, Jiewei Qian, Olga Gerchikov, Nate Chapin, Stephen Chenney, Menard, Alexis, Urvang Joshi, Avi Drissman, srirama chandra sekhar, Mirko Bonadei, Yoav Weiss (@Shopify), Javier Fernandez, Hans Wennborg, Rijubrata Bhaumik, Nikhil Nayunigari, Hu, Ningxin, Hiroki Nakagawa, Mike Taylor, Daniel Cheng, Kaan Icer, Peter Beverloo, Dirk Schulze, Andrew Rayskiy, Sadrul Chowdhury, Zijie He, Kenneth R Christiansen, Dirk Pranke, Raphael Kubo da Costa, Arnaud Mandy, Kentaro Hara, James Su, Enterprise Policy Reviews, Hongchan Choi, Jerome Jiang, (Julie)Jeongeun Kim, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, feature-me...@chromium.org, mpdento...@chromium.org, jdeblas...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, iwells...@chromium.org, extension...@chromium.org, sky+...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, gavin...@chromium.org, srahim...@chromium.org, erickun...@chromium.org, fdoray...@chromium.org, cros-setti...@google.com, xinghui...@chromium.org, jackshira+w...@google.com, rginda...@chromium.org, fenced-fra...@chromium.org, halliwe...@chromium.org, jiajunz+wat...@google.com, prerenderi...@chromium.org, nyquis...@chromium.org, derinel+wat...@google.com, ios-web-view...@google.com, martijn...@martijnc.be, ios-revie...@chromium.org, alexmo...@chromium.org, hanxi...@chromium.org, ashleynewson+w...@chromium.org, francisjp...@google.com, blink-rev...@chromium.org, webapks-...@chromium.org, liu+wa...@chromium.org, jbauma...@chromium.org, kuragin+web-ap...@chromium.org, tluk+...@chromium.org, penghu...@chromium.org, filesapp...@chromium.org, dmurph+watch...@chromium.org, vakh+safe_br...@chromium.org, print-rev...@chromium.org, tgupta...@chromium.org, blink-re...@chromium.org, dcheng+c...@chromium.org, crmulli...@chromium.org, cbe-cep-eng...@google.com, jorgel...@chromium.org, chromium-a...@chromium.org, yhanad...@chromium.org, shgar+aut...@google.com, ios-rev...@chromium.org, eme-r...@chromium.org, asumane...@google.com, ortuno+w...@chromium.org, cros-report...@google.com, yuezhang...@chromium.org, ajwong...@chromium.org, dtapuska+ch...@chromium.org, rrsilva+wat...@google.com, jmedle...@chromium.org, donnd...@chromium.org, lwinston+watc...@google.com, kmg+...@google.com, ejcaruso+wa...@chromium.org, speed-metr...@chromium.org, njeunje+...@chromium.org, kenok...@google.com, croissant-...@chromium.org, loyso...@chromium.org, jeffreycohen+watc...@chromium.org, creis...@chromium.org, headless...@chromium.org, cwalle...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, chrome-waff...@google.com, siyua+aut...@chromium.org, spang...@chromium.org, siashah+au...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, marimatthew+watc...@google.com, armalhotra+a...@google.com, chrome-intelligence-te...@google.com, jshin...@chromium.org, core-timi...@chromium.org, jatapiaro+wat...@google.com, subresource-f...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, feature-v...@chromium.org, shimazu...@chromium.org, davidj...@chromium.org, cros-enterpris...@chromium.org, chromeos-kio...@google.com, blink-reviews-p...@chromium.org, devtools...@chromium.org, niharm...@google.com, grt+...@chromium.org, apavlo...@chromium.org, jophba...@chromium.org, edgesto...@microsoft.com, tranbaod...@chromium.org, druber...@chromium.org, zol...@webkit.org, hirokisa...@chromium.org, chrome-intell...@chromium.org, toyosh...@chromium.org, gavinp...@chromium.org, kainin...@chromium.org, ayman...@chromium.org, yhiran...@chromium.org, dfried...@chromium.org, jackshira+wa...@google.com, chlily...@chromium.org, dewitt...@chromium.org, lens-chrome...@google.com, jdh+wa...@chromium.org, eic+...@google.com, penghuan...@chromium.org, bmcquad...@chromium.org, mercer...@google.com, giovax...@chromium.org, dmurph+wat...@chromium.org, lizeb...@chromium.org, mar...@chromium.org, chrome-tab-group-en...@google.com, rmcelra...@chromium.org, lighthouse-eng-extern...@google.com, permissio...@chromium.org, peilinwa...@google.com, jessemcke...@google.com, borealis-re...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, moqati-team+chr...@google.com, katie...@chromium.org, dtapuska+...@chromium.org, khorimoto+wa...@chromium.org, drott+bl...@chromium.org, petewi...@chromium.org, kouhei...@chromium.org, dmurph+wa...@chromium.org, jz...@chromium.org, asvitkine...@chromium.org, apaselti...@chromium.org, nwoked...@chromium.org, npm+...@chromium.org, stanfie...@google.com, enne...@chromium.org, thefro...@chromium.org, keithle...@chromium.org, roagarw...@chromium.org, blink-revi...@chromium.org, anastas...@google.com, crostin...@chromium.org, fuzzin...@chromium.org, tracing...@chromium.org, cblume...@chromium.org, jdonnel...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, sloboda...@chromium.org, blink-rev...@chromium.org, pkotwic...@chromium.org, chromotin...@chromium.org, dtraino...@chromium.org, harringt...@chromium.org, jonmann+wa...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, blink-revi...@chromium.org, ffred...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, twifka...@chromium.org, zackha...@chromium.org, cfredri...@chromium.org, jasonrobe...@google.com, scheduler...@chromium.org, ramyagopa...@google.com, csharris...@chromium.org, chromiumme...@microsoft.com, ydago...@chromium.org, tbarzi...@chromium.org, scheduler-...@chromium.org, horo+...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, olka+...@chromium.org, dominicc+...@chromium.org, ricea...@chromium.org, fmalit...@chromium.org, hsuregan+wat...@chromium.org, kinuko+ser...@chromium.org, yusufo...@chromium.org, ozone-...@chromium.org, michaelchec...@google.com, dmurph+watc...@chromium.org, rkgibso...@chromium.org, gogeral...@chromium.org, shannc...@chromium.org, chadduffin+w...@chromium.org, chadduffin+wa...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, yuzo+...@chromium.org, shimazu+se...@chromium.org, twelling...@chromium.org, chfreme...@chromium.org, aleventh...@chromium.org, omnibox-...@chromium.org, blink-...@chromium.org, amaliev+...@chromium.org, cros-print...@google.com, marinacio...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, torne...@chromium.org, meilian...@chromium.org, osaul+aut...@google.com, droger+w...@chromium.org, boujan...@google.com, johnche...@chromium.org, svend+w...@chromium.org, net-r...@chromium.org, estali...@chromium.org, thegreenf...@chromium.org, webauthn...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, ntp-dev...@chromium.org, rsesek...@chromium.org, abigailbk...@google.com, bcb+watch-pl...@chromium.org, dibyapal+wa...@chromium.org, gangwu...@chromium.org, pasko...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, ananyasee...@google.com, phoglun...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, knollr+wat...@chromium.org, yigu+...@chromium.org, jkeitel+watch-...@google.com, kenjibah...@chromium.org, dullweb...@chromium.org, chrome-gr...@chromium.org, blink-re...@chromium.org, dmurph+watching...@chromium.org, tmartino+tran...@chromium.org, mfoltz+wa...@chromium.org, hansberry+wa...@chromium.org, chromeos-ca...@google.com, max+watc...@igalia.com, shuche...@chromium.org, nicolas...@chromium.org, estaab...@chromium.org, web-schedulin...@chromium.org, bnc+...@chromium.org, mickeybu...@chromium.org, christia...@chromium.org, cambickel...@google.com, roblia...@chromium.org, gavin...@chromium.org, mattreyno...@chromium.org, stevenjb+wa...@chromium.org, nona+...@chromium.org, gab+...@chromium.org, webap...@microsoft.com, yongshun+...@google.com, dmurph+watchi...@chromium.org, mreichhoff+watc...@chromium.org, bartek...@chromium.org, vasilii+watchlis...@chromium.org, yfriedm...@chromium.org, browser-comp...@chromium.org, ender...@chromium.org, hiroshig...@chromium.org, mdjone...@chromium.org, nickdiego+wa...@igalia.com, pdf-r...@chromium.org, fgal...@chromium.org, asvitki...@chromium.org, lucasrada...@google.com, tburkar...@chromium.org, peter+watch...@chromium.org, chrstn...@google.com, media-cro...@chromium.org, blink-revie...@chromium.org, devtools-re...@chromium.org, gavinp+p...@chromium.org, dom+...@chromium.org, khorimoto+w...@chromium.org, minap+watch-p...@google.com, nator...@chromium.org, hayato...@chromium.org, fuchsia...@chromium.org, trewin...@google.com, yhanada+...@chromium.org, blink-re...@chromium.org, rayanka...@chromium.org, translat...@chromium.org, hsuregan+wa...@chromium.org, media-wi...@chromium.org, nikhilcn+wat...@google.com, jiajunz+wa...@google.com, mgiuca...@chromium.org, philli...@chromium.org, josiah...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, agriev...@chromium.org, vinnypersky+...@google.com, speed-metrics...@chromium.org, yhanada+...@chromium.org, storage...@chromium.org, marq+...@chromium.org, hashimo...@chromium.org, blink-revi...@chromium.org, zelin+watch-we...@chromium.org, language...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, oshima...@chromium.org
Attention needed from Josiah Kiehl

Juan Mojica voted and added 1 comment

Votes added by Juan Mojica

Code-Review+1

1 comment

File ui/webui/resources/cr_components/composebox/composebox.ts
Line 91, Patchset 10: lensButtonTriggersOverlay: {type: Boolean},
Juan Mojica . resolved

I don't think we ever expect this button not to trigger the overlay.

Josiah Kiehl

I thought it triggers a file upload in NTP and Omnibox?

Josiah Kiehl

Or perhaps just NTP?

Juan Mojica

Oh you may be right. Sorry I am not familiar with those flows.

Open in Gerrit

Related details

Attention is currently required from:
  • Josiah Kiehl
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Josiah Kiehl <ki...@google.com>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 01:30:21 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ananya Seelam (Gerrit)

    unread,
    Dec 23, 2025, 9:54:40 AM (3 days ago) Dec 23
    to Josiah Kiehl, James Maclean, David Bokan, Kevin Babbitt, Chromium Metrics Reviews, Wang, Wei4, Christian Biesinger, Victor Tan, Simon Hangl, Ian Vollick, Peter Williamson, Ryan Sultanem, Jiewei Qian, Olga Gerchikov, Nate Chapin, Stephen Chenney, Menard, Alexis, Urvang Joshi, Avi Drissman, srirama chandra sekhar, Mirko Bonadei, Yoav Weiss (@Shopify), Javier Fernandez, Hans Wennborg, Rijubrata Bhaumik, Nikhil Nayunigari, Hu, Ningxin, Hiroki Nakagawa, Mike Taylor, Daniel Cheng, Kaan Icer, Peter Beverloo, Dirk Schulze, Andrew Rayskiy, Sadrul Chowdhury, Zijie He, Kenneth R Christiansen, Dirk Pranke, Raphael Kubo da Costa, Arnaud Mandy, Kentaro Hara, James Su, Enterprise Policy Reviews, Hongchan Choi, Jerome Jiang, (Julie)Jeongeun Kim, AyeAye, Juan Mojica, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, feature-me...@chromium.org, mpdento...@chromium.org, jdeblas...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, iwells...@chromium.org, extension...@chromium.org, sky+...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, gavin...@chromium.org, srahim...@chromium.org, erickun...@chromium.org, fdoray...@chromium.org, cros-setti...@google.com, xinghui...@chromium.org, jackshira+w...@google.com, rginda...@chromium.org, fenced-fra...@chromium.org, halliwe...@chromium.org, jiajunz+wat...@google.com, prerenderi...@chromium.org, nyquis...@chromium.org, derinel+wat...@google.com, ios-web-view...@google.com, martijn...@martijnc.be, ios-revie...@chromium.org, alexmo...@chromium.org, hanxi...@chromium.org, ashleynewson+w...@chromium.org, francisjp...@google.com, blink-rev...@chromium.org, webapks-...@chromium.org, liu+wa...@chromium.org, jbauma...@chromium.org, kuragin+web-ap...@chromium.org, tluk+...@chromium.org, penghu...@chromium.org, filesapp...@chromium.org, dmurph+watch...@chromium.org, vakh+safe_br...@chromium.org, print-rev...@chromium.org, tgupta...@chromium.org, blink-re...@chromium.org, dcheng+c...@chromium.org, crmulli...@chromium.org, cbe-cep-eng...@google.com, jorgel...@chromium.org, chromium-a...@chromium.org, yhanad...@chromium.org, shgar+aut...@google.com, ios-rev...@chromium.org, eme-r...@chromium.org, asumane...@google.com, ortuno+w...@chromium.org, cros-report...@google.com, yuezhang...@chromium.org, ajwong...@chromium.org, dtapuska+ch...@chromium.org, rrsilva+wat...@google.com, jmedle...@chromium.org, donnd...@chromium.org, lwinston+watc...@google.com, kmg+...@google.com, ejcaruso+wa...@chromium.org, speed-metr...@chromium.org, njeunje+...@chromium.org, kenok...@google.com, croissant-...@chromium.org, loyso...@chromium.org, jeffreycohen+watc...@chromium.org, creis...@chromium.org, headless...@chromium.org, cwalle...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, chrome-waff...@google.com, siyua+aut...@chromium.org, spang...@chromium.org, siashah+au...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, marimatthew+watc...@google.com, armalhotra+a...@google.com, chrome-intelligence-te...@google.com, jshin...@chromium.org, core-timi...@chromium.org, jatapiaro+wat...@google.com, subresource-f...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, feature-v...@chromium.org, shimazu...@chromium.org, davidj...@chromium.org, cros-enterpris...@chromium.org, chromeos-kio...@google.com, blink-reviews-p...@chromium.org, devtools...@chromium.org, niharm...@google.com, grt+...@chromium.org, apavlo...@chromium.org, jophba...@chromium.org, edgesto...@microsoft.com, tranbaod...@chromium.org, druber...@chromium.org, zol...@webkit.org, hirokisa...@chromium.org, chrome-intell...@chromium.org, toyosh...@chromium.org, gavinp...@chromium.org, kainin...@chromium.org, ayman...@chromium.org, yhiran...@chromium.org, dfried...@chromium.org, jackshira+wa...@google.com, chlily...@chromium.org, dewitt...@chromium.org, lens-chrome...@google.com, jdh+wa...@chromium.org, eic+...@google.com, penghuan...@chromium.org, bmcquad...@chromium.org, mercer...@google.com, giovax...@chromium.org, dmurph+wat...@chromium.org, lizeb...@chromium.org, mar...@chromium.org, chrome-tab-group-en...@google.com, rmcelra...@chromium.org, lighthouse-eng-extern...@google.com, permissio...@chromium.org, peilinwa...@google.com, jessemcke...@google.com, borealis-re...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, moqati-team+chr...@google.com, katie...@chromium.org, dtapuska+...@chromium.org, khorimoto+wa...@chromium.org, drott+bl...@chromium.org, petewi...@chromium.org, kouhei...@chromium.org, dmurph+wa...@chromium.org, jz...@chromium.org, asvitkine...@chromium.org, apaselti...@chromium.org, nwoked...@chromium.org, npm+...@chromium.org, stanfie...@google.com, enne...@chromium.org, thefro...@chromium.org, keithle...@chromium.org, roagarw...@chromium.org, blink-revi...@chromium.org, anastas...@google.com, crostin...@chromium.org, fuzzin...@chromium.org, tracing...@chromium.org, cblume...@chromium.org, jdonnel...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, sloboda...@chromium.org, blink-rev...@chromium.org, pkotwic...@chromium.org, chromotin...@chromium.org, dtraino...@chromium.org, harringt...@chromium.org, jonmann+wa...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, blink-revi...@chromium.org, ffred...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, twifka...@chromium.org, zackha...@chromium.org, cfredri...@chromium.org, jasonrobe...@google.com, scheduler...@chromium.org, ramyagopa...@google.com, csharris...@chromium.org, chromiumme...@microsoft.com, ydago...@chromium.org, tbarzi...@chromium.org, scheduler-...@chromium.org, horo+...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, olka+...@chromium.org, dominicc+...@chromium.org, ricea...@chromium.org, fmalit...@chromium.org, hsuregan+wat...@chromium.org, kinuko+ser...@chromium.org, yusufo...@chromium.org, ozone-...@chromium.org, michaelchec...@google.com, dmurph+watc...@chromium.org, rkgibso...@chromium.org, gogeral...@chromium.org, shannc...@chromium.org, chadduffin+w...@chromium.org, chadduffin+wa...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, yuzo+...@chromium.org, shimazu+se...@chromium.org, twelling...@chromium.org, chfreme...@chromium.org, aleventh...@chromium.org, omnibox-...@chromium.org, blink-...@chromium.org, amaliev+...@chromium.org, cros-print...@google.com, marinacio...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, torne...@chromium.org, meilian...@chromium.org, osaul+aut...@google.com, droger+w...@chromium.org, boujan...@google.com, johnche...@chromium.org, svend+w...@chromium.org, net-r...@chromium.org, estali...@chromium.org, thegreenf...@chromium.org, webauthn...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, ntp-dev...@chromium.org, rsesek...@chromium.org, abigailbk...@google.com, bcb+watch-pl...@chromium.org, dibyapal+wa...@chromium.org, gangwu...@chromium.org, pasko...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, ananyasee...@google.com, phoglun...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, knollr+wat...@chromium.org, yigu+...@chromium.org, jkeitel+watch-...@google.com, kenjibah...@chromium.org, dullweb...@chromium.org, chrome-gr...@chromium.org, blink-re...@chromium.org, dmurph+watching...@chromium.org, tmartino+tran...@chromium.org, mfoltz+wa...@chromium.org, hansberry+wa...@chromium.org, chromeos-ca...@google.com, max+watc...@igalia.com, shuche...@chromium.org, nicolas...@chromium.org, estaab...@chromium.org, web-schedulin...@chromium.org, bnc+...@chromium.org, mickeybu...@chromium.org, christia...@chromium.org, cambickel...@google.com, roblia...@chromium.org, gavin...@chromium.org, mattreyno...@chromium.org, stevenjb+wa...@chromium.org, nona+...@chromium.org, gab+...@chromium.org, webap...@microsoft.com, yongshun+...@google.com, dmurph+watchi...@chromium.org, mreichhoff+watc...@chromium.org, bartek...@chromium.org, vasilii+watchlis...@chromium.org, yfriedm...@chromium.org, browser-comp...@chromium.org, ender...@chromium.org, hiroshig...@chromium.org, mdjone...@chromium.org, nickdiego+wa...@igalia.com, pdf-r...@chromium.org, fgal...@chromium.org, asvitki...@chromium.org, lucasrada...@google.com, tburkar...@chromium.org, peter+watch...@chromium.org, chrstn...@google.com, media-cro...@chromium.org, blink-revie...@chromium.org, devtools-re...@chromium.org, gavinp+p...@chromium.org, dom+...@chromium.org, khorimoto+w...@chromium.org, minap+watch-p...@google.com, nator...@chromium.org, hayato...@chromium.org, fuchsia...@chromium.org, trewin...@google.com, yhanada+...@chromium.org, blink-re...@chromium.org, rayanka...@chromium.org, translat...@chromium.org, hsuregan+wa...@chromium.org, media-wi...@chromium.org, nikhilcn+wat...@google.com, jiajunz+wa...@google.com, mgiuca...@chromium.org, philli...@chromium.org, josiah...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, agriev...@chromium.org, vinnypersky+...@google.com, speed-metrics...@chromium.org, yhanada+...@chromium.org, storage...@chromium.org, marq+...@chromium.org, hashimo...@chromium.org, blink-revi...@chromium.org, zelin+watch-we...@chromium.org, language...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, oshima...@chromium.org
    Attention needed from Josiah Kiehl

    Ananya Seelam voted and added 3 comments

    Votes added by Ananya Seelam

    Code-Review+1

    3 comments

    Patchset-level comments
    File-level comment, Patchset 12 (Latest):
    Ananya Seelam . resolved

    LGTM!

    File chrome/test/data/webui/contextual_tasks/composebox_test.ts
    Line 166, Patchset 12 (Latest): // Check property
    Ananya Seelam . unresolved

    super nit: we should have periods at the end of a comment.

    Line 169, Patchset 12 (Latest): // Click lens button
    Ananya Seelam . unresolved

    super nit: we should have periods at the end of a comment.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Josiah Kiehl
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I543f504c6632fad4e2c72bf20d7093857818a164
    Gerrit-Change-Number: 7264491
    Gerrit-PatchSet: 12
    Gerrit-Owner: Josiah Kiehl <ki...@google.com>
    Gerrit-Reviewer: Ananya Seelam <ananya...@google.com>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 14:54:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Josiah Kiehl (Gerrit)

    unread,
    Dec 23, 2025, 1:39:23 PM (3 days ago) Dec 23
    to Ananya Seelam, James Maclean, David Bokan, Kevin Babbitt, Chromium Metrics Reviews, Wang, Wei4, Christian Biesinger, Victor Tan, Simon Hangl, Ian Vollick, Peter Williamson, Ryan Sultanem, Jiewei Qian, Olga Gerchikov, Nate Chapin, Stephen Chenney, Menard, Alexis, Urvang Joshi, Avi Drissman, srirama chandra sekhar, Mirko Bonadei, Yoav Weiss (@Shopify), Javier Fernandez, Hans Wennborg, Rijubrata Bhaumik, Nikhil Nayunigari, Hu, Ningxin, Hiroki Nakagawa, Mike Taylor, Daniel Cheng, Kaan Icer, Peter Beverloo, Dirk Schulze, Andrew Rayskiy, Sadrul Chowdhury, Zijie He, Kenneth R Christiansen, Dirk Pranke, Raphael Kubo da Costa, Arnaud Mandy, Kentaro Hara, James Su, Enterprise Policy Reviews, Hongchan Choi, Jerome Jiang, (Julie)Jeongeun Kim, AyeAye, Juan Mojica, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, feature-me...@chromium.org, mpdento...@chromium.org, jdeblas...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, iwells...@chromium.org, extension...@chromium.org, sky+...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, gavin...@chromium.org, srahim...@chromium.org, erickun...@chromium.org, fdoray...@chromium.org, cros-setti...@google.com, xinghui...@chromium.org, jackshira+w...@google.com, rginda...@chromium.org, fenced-fra...@chromium.org, halliwe...@chromium.org, jiajunz+wat...@google.com, prerenderi...@chromium.org, nyquis...@chromium.org, derinel+wat...@google.com, ios-web-view...@google.com, martijn...@martijnc.be, ios-revie...@chromium.org, alexmo...@chromium.org, hanxi...@chromium.org, ashleynewson+w...@chromium.org, francisjp...@google.com, blink-rev...@chromium.org, webapks-...@chromium.org, liu+wa...@chromium.org, jbauma...@chromium.org, kuragin+web-ap...@chromium.org, tluk+...@chromium.org, penghu...@chromium.org, filesapp...@chromium.org, dmurph+watch...@chromium.org, vakh+safe_br...@chromium.org, print-rev...@chromium.org, tgupta...@chromium.org, blink-re...@chromium.org, dcheng+c...@chromium.org, crmulli...@chromium.org, cbe-cep-eng...@google.com, jorgel...@chromium.org, chromium-a...@chromium.org, yhanad...@chromium.org, shgar+aut...@google.com, ios-rev...@chromium.org, eme-r...@chromium.org, asumane...@google.com, ortuno+w...@chromium.org, cros-report...@google.com, yuezhang...@chromium.org, ajwong...@chromium.org, dtapuska+ch...@chromium.org, rrsilva+wat...@google.com, jmedle...@chromium.org, donnd...@chromium.org, lwinston+watc...@google.com, kmg+...@google.com, ejcaruso+wa...@chromium.org, speed-metr...@chromium.org, njeunje+...@chromium.org, kenok...@google.com, croissant-...@chromium.org, loyso...@chromium.org, jeffreycohen+watc...@chromium.org, creis...@chromium.org, headless...@chromium.org, cwalle...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, chrome-waff...@google.com, siyua+aut...@chromium.org, spang...@chromium.org, siashah+au...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, marimatthew+watc...@google.com, armalhotra+a...@google.com, chrome-intelligence-te...@google.com, jshin...@chromium.org, core-timi...@chromium.org, jatapiaro+wat...@google.com, subresource-f...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, feature-v...@chromium.org, shimazu...@chromium.org, davidj...@chromium.org, cros-enterpris...@chromium.org, chromeos-kio...@google.com, blink-reviews-p...@chromium.org, devtools...@chromium.org, niharm...@google.com, grt+...@chromium.org, apavlo...@chromium.org, jophba...@chromium.org, edgesto...@microsoft.com, tranbaod...@chromium.org, druber...@chromium.org, zol...@webkit.org, hirokisa...@chromium.org, chrome-intell...@chromium.org, toyosh...@chromium.org, gavinp...@chromium.org, kainin...@chromium.org, ayman...@chromium.org, yhiran...@chromium.org, dfried...@chromium.org, jackshira+wa...@google.com, chlily...@chromium.org, dewitt...@chromium.org, lens-chrome...@google.com, jdh+wa...@chromium.org, eic+...@google.com, penghuan...@chromium.org, bmcquad...@chromium.org, mercer...@google.com, giovax...@chromium.org, dmurph+wat...@chromium.org, lizeb...@chromium.org, mar...@chromium.org, chrome-tab-group-en...@google.com, rmcelra...@chromium.org, lighthouse-eng-extern...@google.com, permissio...@chromium.org, peilinwa...@google.com, jessemcke...@google.com, borealis-re...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, moqati-team+chr...@google.com, katie...@chromium.org, dtapuska+...@chromium.org, khorimoto+wa...@chromium.org, drott+bl...@chromium.org, petewi...@chromium.org, kouhei...@chromium.org, dmurph+wa...@chromium.org, jz...@chromium.org, asvitkine...@chromium.org, apaselti...@chromium.org, nwoked...@chromium.org, npm+...@chromium.org, stanfie...@google.com, enne...@chromium.org, thefro...@chromium.org, keithle...@chromium.org, roagarw...@chromium.org, blink-revi...@chromium.org, anastas...@google.com, crostin...@chromium.org, fuzzin...@chromium.org, tracing...@chromium.org, cblume...@chromium.org, jdonnel...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, sloboda...@chromium.org, blink-rev...@chromium.org, pkotwic...@chromium.org, chromotin...@chromium.org, dtraino...@chromium.org, harringt...@chromium.org, jonmann+wa...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, blink-revi...@chromium.org, ffred...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, twifka...@chromium.org, zackha...@chromium.org, cfredri...@chromium.org, jasonrobe...@google.com, scheduler...@chromium.org, ramyagopa...@google.com, csharris...@chromium.org, chromiumme...@microsoft.com, ydago...@chromium.org, tbarzi...@chromium.org, scheduler-...@chromium.org, horo+...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, olka+...@chromium.org, dominicc+...@chromium.org, ricea...@chromium.org, fmalit...@chromium.org, hsuregan+wat...@chromium.org, kinuko+ser...@chromium.org, yusufo...@chromium.org, ozone-...@chromium.org, michaelchec...@google.com, dmurph+watc...@chromium.org, rkgibso...@chromium.org, gogeral...@chromium.org, shannc...@chromium.org, chadduffin+w...@chromium.org, chadduffin+wa...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, yuzo+...@chromium.org, shimazu+se...@chromium.org, twelling...@chromium.org, chfreme...@chromium.org, aleventh...@chromium.org, omnibox-...@chromium.org, blink-...@chromium.org, amaliev+...@chromium.org, cros-print...@google.com, marinacio...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, torne...@chromium.org, meilian...@chromium.org, osaul+aut...@google.com, droger+w...@chromium.org, boujan...@google.com, johnche...@chromium.org, svend+w...@chromium.org, net-r...@chromium.org, estali...@chromium.org, thegreenf...@chromium.org, webauthn...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, ntp-dev...@chromium.org, rsesek...@chromium.org, abigailbk...@google.com, bcb+watch-pl...@chromium.org, dibyapal+wa...@chromium.org, gangwu...@chromium.org, pasko...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, ananyasee...@google.com, phoglun...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, knollr+wat...@chromium.org, yigu+...@chromium.org, jkeitel+watch-...@google.com, kenjibah...@chromium.org, dullweb...@chromium.org, chrome-gr...@chromium.org, blink-re...@chromium.org, dmurph+watching...@chromium.org, tmartino+tran...@chromium.org, mfoltz+wa...@chromium.org, hansberry+wa...@chromium.org, chromeos-ca...@google.com, max+watc...@igalia.com, shuche...@chromium.org, nicolas...@chromium.org, estaab...@chromium.org, web-schedulin...@chromium.org, bnc+...@chromium.org, mickeybu...@chromium.org, christia...@chromium.org, cambickel...@google.com, roblia...@chromium.org, gavin...@chromium.org, mattreyno...@chromium.org, stevenjb+wa...@chromium.org, nona+...@chromium.org, gab+...@chromium.org, webap...@microsoft.com, yongshun+...@google.com, dmurph+watchi...@chromium.org, mreichhoff+watc...@chromium.org, bartek...@chromium.org, vasilii+watchlis...@chromium.org, yfriedm...@chromium.org, browser-comp...@chromium.org, ender...@chromium.org, hiroshig...@chromium.org, mdjone...@chromium.org, nickdiego+wa...@igalia.com, pdf-r...@chromium.org, fgal...@chromium.org, asvitki...@chromium.org, lucasrada...@google.com, tburkar...@chromium.org, peter+watch...@chromium.org, chrstn...@google.com, media-cro...@chromium.org, blink-revie...@chromium.org, devtools-re...@chromium.org, gavinp+p...@chromium.org, dom+...@chromium.org, khorimoto+w...@chromium.org, minap+watch-p...@google.com, nator...@chromium.org, hayato...@chromium.org, fuchsia...@chromium.org, trewin...@google.com, yhanada+...@chromium.org, blink-re...@chromium.org, rayanka...@chromium.org, translat...@chromium.org, hsuregan+wa...@chromium.org, media-wi...@chromium.org, nikhilcn+wat...@google.com, jiajunz+wa...@google.com, mgiuca...@chromium.org, philli...@chromium.org, josiah...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, agriev...@chromium.org, vinnypersky+...@google.com, speed-metrics...@chromium.org, yhanada+...@chromium.org, storage...@chromium.org, marq+...@chromium.org, hashimo...@chromium.org, blink-revi...@chromium.org, zelin+watch-we...@chromium.org, language...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, oshima...@chromium.org

    Josiah Kiehl voted and added 2 comments

    Votes added by Josiah Kiehl

    Auto-Submit+1
    Commit-Queue+2

    2 comments

    File chrome/test/data/webui/contextual_tasks/composebox_test.ts
    Line 166, Patchset 12: // Check property
    Ananya Seelam . resolved

    super nit: we should have periods at the end of a comment.

    Josiah Kiehl

    Done

    Line 169, Patchset 12: // Click lens button
    Ananya Seelam . resolved

    super nit: we should have periods at the end of a comment.

    Josiah Kiehl

    Even better... I've just deleted the mostly useless comments. 😄

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I543f504c6632fad4e2c72bf20d7093857818a164
      Gerrit-Change-Number: 7264491
      Gerrit-PatchSet: 14
      Gerrit-Comment-Date: Tue, 23 Dec 2025 18:39:08 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Ananya Seelam <ananya...@google.com>
      satisfied_requirement
      open
      diffy

      Josiah Kiehl (Gerrit)

      unread,
      Dec 23, 2025, 9:07:04 PM (2 days ago) Dec 23
      to Ananya Seelam, James Maclean, David Bokan, Kevin Babbitt, Chromium Metrics Reviews, Wang, Wei4, Christian Biesinger, Victor Tan, Simon Hangl, Ian Vollick, Peter Williamson, Ryan Sultanem, Jiewei Qian, Olga Gerchikov, Nate Chapin, Stephen Chenney, Menard, Alexis, Urvang Joshi, Avi Drissman, srirama chandra sekhar, Mirko Bonadei, Yoav Weiss (@Shopify), Javier Fernandez, Hans Wennborg, Rijubrata Bhaumik, Nikhil Nayunigari, Hu, Ningxin, Hiroki Nakagawa, Mike Taylor, Daniel Cheng, Kaan Icer, Peter Beverloo, Dirk Schulze, Andrew Rayskiy, Sadrul Chowdhury, Zijie He, Kenneth R Christiansen, Dirk Pranke, Raphael Kubo da Costa, Arnaud Mandy, Kentaro Hara, James Su, Enterprise Policy Reviews, Hongchan Choi, Jerome Jiang, (Julie)Jeongeun Kim, AyeAye, Juan Mojica, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, feature-me...@chromium.org, mpdento...@chromium.org, jdeblas...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, iwells...@chromium.org, extension...@chromium.org, sky+...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, gavin...@chromium.org, srahim...@chromium.org, erickun...@chromium.org, fdoray...@chromium.org, cros-setti...@google.com, xinghui...@chromium.org, jackshira+w...@google.com, rginda...@chromium.org, fenced-fra...@chromium.org, halliwe...@chromium.org, jiajunz+wat...@google.com, prerenderi...@chromium.org, nyquis...@chromium.org, derinel+wat...@google.com, ios-web-view...@google.com, martijn...@martijnc.be, ios-revie...@chromium.org, alexmo...@chromium.org, hanxi...@chromium.org, ashleynewson+w...@chromium.org, francisjp...@google.com, blink-rev...@chromium.org, webapks-...@chromium.org, liu+wa...@chromium.org, jbauma...@chromium.org, kuragin+web-ap...@chromium.org, tluk+...@chromium.org, penghu...@chromium.org, filesapp...@chromium.org, dmurph+watch...@chromium.org, vakh+safe_br...@chromium.org, print-rev...@chromium.org, tgupta...@chromium.org, blink-re...@chromium.org, dcheng+c...@chromium.org, crmulli...@chromium.org, cbe-cep-eng...@google.com, jorgel...@chromium.org, chromium-a...@chromium.org, yhanad...@chromium.org, shgar+aut...@google.com, ios-rev...@chromium.org, eme-r...@chromium.org, asumane...@google.com, ortuno+w...@chromium.org, cros-report...@google.com, yuezhang...@chromium.org, ajwong...@chromium.org, dtapuska+ch...@chromium.org, rrsilva+wat...@google.com, jmedle...@chromium.org, donnd...@chromium.org, lwinston+watc...@google.com, kmg+...@google.com, ejcaruso+wa...@chromium.org, speed-metr...@chromium.org, njeunje+...@chromium.org, kenok...@google.com, croissant-...@chromium.org, loyso...@chromium.org, jeffreycohen+watc...@chromium.org, creis...@chromium.org, headless...@chromium.org, cwalle...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, chrome-waff...@google.com, siyua+aut...@chromium.org, spang...@chromium.org, siashah+au...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, marimatthew+watc...@google.com, armalhotra+a...@google.com, chrome-intelligence-te...@google.com, jshin...@chromium.org, core-timi...@chromium.org, jatapiaro+wat...@google.com, subresource-f...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, feature-v...@chromium.org, shimazu...@chromium.org, davidj...@chromium.org, cros-enterpris...@chromium.org, chromeos-kio...@google.com, blink-reviews-p...@chromium.org, devtools...@chromium.org, niharm...@google.com, grt+...@chromium.org, apavlo...@chromium.org, jophba...@chromium.org, edgesto...@microsoft.com, tranbaod...@chromium.org, druber...@chromium.org, zol...@webkit.org, hirokisa...@chromium.org, chrome-intell...@chromium.org, toyosh...@chromium.org, gavinp...@chromium.org, kainin...@chromium.org, ayman...@chromium.org, yhiran...@chromium.org, dfried...@chromium.org, jackshira+wa...@google.com, chlily...@chromium.org, dewitt...@chromium.org, lens-chrome...@google.com, jdh+wa...@chromium.org, eic+...@google.com, penghuan...@chromium.org, bmcquad...@chromium.org, mercer...@google.com, giovax...@chromium.org, dmurph+wat...@chromium.org, lizeb...@chromium.org, mar...@chromium.org, chrome-tab-group-en...@google.com, rmcelra...@chromium.org, lighthouse-eng-extern...@google.com, permissio...@chromium.org, peilinwa...@google.com, jessemcke...@google.com, borealis-re...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, moqati-team+chr...@google.com, katie...@chromium.org, dtapuska+...@chromium.org, khorimoto+wa...@chromium.org, drott+bl...@chromium.org, petewi...@chromium.org, kouhei...@chromium.org, dmurph+wa...@chromium.org, jz...@chromium.org, asvitkine...@chromium.org, apaselti...@chromium.org, nwoked...@chromium.org, npm+...@chromium.org, stanfie...@google.com, enne...@chromium.org, thefro...@chromium.org, keithle...@chromium.org, roagarw...@chromium.org, blink-revi...@chromium.org, anastas...@google.com, crostin...@chromium.org, fuzzin...@chromium.org, tracing...@chromium.org, cblume...@chromium.org, jdonnel...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, sloboda...@chromium.org, blink-rev...@chromium.org, pkotwic...@chromium.org, chromotin...@chromium.org, dtraino...@chromium.org, harringt...@chromium.org, jonmann+wa...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, blink-revi...@chromium.org, ffred...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, twifka...@chromium.org, zackha...@chromium.org, cfredri...@chromium.org, jasonrobe...@google.com, scheduler...@chromium.org, ramyagopa...@google.com, csharris...@chromium.org, chromiumme...@microsoft.com, ydago...@chromium.org, tbarzi...@chromium.org, scheduler-...@chromium.org, horo+...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, olka+...@chromium.org, dominicc+...@chromium.org, ricea...@chromium.org, fmalit...@chromium.org, hsuregan+wat...@chromium.org, kinuko+ser...@chromium.org, yusufo...@chromium.org, ozone-...@chromium.org, michaelchec...@google.com, dmurph+watc...@chromium.org, rkgibso...@chromium.org, gogeral...@chromium.org, shannc...@chromium.org, chadduffin+w...@chromium.org, chadduffin+wa...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, yuzo+...@chromium.org, shimazu+se...@chromium.org, twelling...@chromium.org, chfreme...@chromium.org, aleventh...@chromium.org, omnibox-...@chromium.org, blink-...@chromium.org, amaliev+...@chromium.org, cros-print...@google.com, marinacio...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, torne...@chromium.org, meilian...@chromium.org, osaul+aut...@google.com, droger+w...@chromium.org, boujan...@google.com, johnche...@chromium.org, svend+w...@chromium.org, net-r...@chromium.org, estali...@chromium.org, thegreenf...@chromium.org, webauthn...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, ntp-dev...@chromium.org, rsesek...@chromium.org, abigailbk...@google.com, bcb+watch-pl...@chromium.org, dibyapal+wa...@chromium.org, gangwu...@chromium.org, pasko...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, ananyasee...@google.com, phoglun...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, knollr+wat...@chromium.org, yigu+...@chromium.org, jkeitel+watch-...@google.com, kenjibah...@chromium.org, dullweb...@chromium.org, chrome-gr...@chromium.org, blink-re...@chromium.org, dmurph+watching...@chromium.org, tmartino+tran...@chromium.org, mfoltz+wa...@chromium.org, hansberry+wa...@chromium.org, chromeos-ca...@google.com, max+watc...@igalia.com, shuche...@chromium.org, nicolas...@chromium.org, estaab...@chromium.org, web-schedulin...@chromium.org, bnc+...@chromium.org, mickeybu...@chromium.org, christia...@chromium.org, cambickel...@google.com, roblia...@chromium.org, gavin...@chromium.org, mattreyno...@chromium.org, stevenjb+wa...@chromium.org, nona+...@chromium.org, gab+...@chromium.org, webap...@microsoft.com, yongshun+...@google.com, dmurph+watchi...@chromium.org, mreichhoff+watc...@chromium.org, bartek...@chromium.org, vasilii+watchlis...@chromium.org, yfriedm...@chromium.org, browser-comp...@chromium.org, ender...@chromium.org, hiroshig...@chromium.org, mdjone...@chromium.org, nickdiego+wa...@igalia.com, pdf-r...@chromium.org, fgal...@chromium.org, asvitki...@chromium.org, lucasrada...@google.com, tburkar...@chromium.org, peter+watch...@chromium.org, chrstn...@google.com, media-cro...@chromium.org, blink-revie...@chromium.org, devtools-re...@chromium.org, gavinp+p...@chromium.org, dom+...@chromium.org, khorimoto+w...@chromium.org, minap+watch-p...@google.com, nator...@chromium.org, hayato...@chromium.org, fuchsia...@chromium.org, trewin...@google.com, yhanada+...@chromium.org, blink-re...@chromium.org, rayanka...@chromium.org, translat...@chromium.org, hsuregan+wa...@chromium.org, media-wi...@chromium.org, nikhilcn+wat...@google.com, jiajunz+wa...@google.com, mgiuca...@chromium.org, philli...@chromium.org, josiah...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, agriev...@chromium.org, vinnypersky+...@google.com, speed-metrics...@chromium.org, yhanada+...@chromium.org, storage...@chromium.org, marq+...@chromium.org, hashimo...@chromium.org, blink-revi...@chromium.org, zelin+watch-we...@chromium.org, language...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, oshima...@chromium.org

      Josiah Kiehl voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I543f504c6632fad4e2c72bf20d7093857818a164
      Gerrit-Change-Number: 7264491
      Gerrit-PatchSet: 17
      Gerrit-Comment-Date: Wed, 24 Dec 2025 02:06:49 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Josiah Kiehl (Gerrit)

      unread,
      Dec 24, 2025, 3:49:46 PM (2 days ago) Dec 24
      to Ananya Seelam, James Maclean, David Bokan, Kevin Babbitt, Chromium Metrics Reviews, Wang, Wei4, Christian Biesinger, Victor Tan, Simon Hangl, Ian Vollick, Peter Williamson, Ryan Sultanem, Jiewei Qian, Olga Gerchikov, Nate Chapin, Stephen Chenney, Menard, Alexis, Urvang Joshi, Avi Drissman, srirama chandra sekhar, Mirko Bonadei, Yoav Weiss (@Shopify), Javier Fernandez, Hans Wennborg, Rijubrata Bhaumik, Nikhil Nayunigari, Hu, Ningxin, Hiroki Nakagawa, Mike Taylor, Daniel Cheng, Kaan Icer, Peter Beverloo, Dirk Schulze, Andrew Rayskiy, Sadrul Chowdhury, Zijie He, Kenneth R Christiansen, Dirk Pranke, Raphael Kubo da Costa, Arnaud Mandy, Kentaro Hara, James Su, Enterprise Policy Reviews, Hongchan Choi, Jerome Jiang, (Julie)Jeongeun Kim, AyeAye, Juan Mojica, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, feature-me...@chromium.org, mpdento...@chromium.org, jdeblas...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, iwells...@chromium.org, extension...@chromium.org, sky+...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, gavin...@chromium.org, srahim...@chromium.org, erickun...@chromium.org, fdoray...@chromium.org, cros-setti...@google.com, xinghui...@chromium.org, jackshira+w...@google.com, rginda...@chromium.org, fenced-fra...@chromium.org, halliwe...@chromium.org, jiajunz+wat...@google.com, prerenderi...@chromium.org, nyquis...@chromium.org, derinel+wat...@google.com, ios-web-view...@google.com, martijn...@martijnc.be, ios-revie...@chromium.org, alexmo...@chromium.org, hanxi...@chromium.org, ashleynewson+w...@chromium.org, francisjp...@google.com, blink-rev...@chromium.org, webapks-...@chromium.org, liu+wa...@chromium.org, jbauma...@chromium.org, kuragin+web-ap...@chromium.org, tluk+...@chromium.org, penghu...@chromium.org, filesapp...@chromium.org, dmurph+watch...@chromium.org, vakh+safe_br...@chromium.org, print-rev...@chromium.org, tgupta...@chromium.org, blink-re...@chromium.org, dcheng+c...@chromium.org, crmulli...@chromium.org, cbe-cep-eng...@google.com, jorgel...@chromium.org, chromium-a...@chromium.org, yhanad...@chromium.org, shgar+aut...@google.com, ios-rev...@chromium.org, eme-r...@chromium.org, asumane...@google.com, ortuno+w...@chromium.org, cros-report...@google.com, yuezhang...@chromium.org, ajwong...@chromium.org, dtapuska+ch...@chromium.org, rrsilva+wat...@google.com, jmedle...@chromium.org, donnd...@chromium.org, lwinston+watc...@google.com, kmg+...@google.com, ejcaruso+wa...@chromium.org, speed-metr...@chromium.org, njeunje+...@chromium.org, kenok...@google.com, croissant-...@chromium.org, loyso...@chromium.org, jeffreycohen+watc...@chromium.org, creis...@chromium.org, headless...@chromium.org, cwalle...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, chrome-waff...@google.com, siyua+aut...@chromium.org, spang...@chromium.org, siashah+au...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, marimatthew+watc...@google.com, armalhotra+a...@google.com, chrome-intelligence-te...@google.com, jshin...@chromium.org, core-timi...@chromium.org, jatapiaro+wat...@google.com, subresource-f...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, feature-v...@chromium.org, shimazu...@chromium.org, davidj...@chromium.org, cros-enterpris...@chromium.org, chromeos-kio...@google.com, blink-reviews-p...@chromium.org, devtools...@chromium.org, niharm...@google.com, grt+...@chromium.org, apavlo...@chromium.org, jophba...@chromium.org, edgesto...@microsoft.com, tranbaod...@chromium.org, druber...@chromium.org, zol...@webkit.org, hirokisa...@chromium.org, chrome-intell...@chromium.org, toyosh...@chromium.org, gavinp...@chromium.org, kainin...@chromium.org, ayman...@chromium.org, yhiran...@chromium.org, dfried...@chromium.org, jackshira+wa...@google.com, chlily...@chromium.org, dewitt...@chromium.org, lens-chrome...@google.com, jdh+wa...@chromium.org, eic+...@google.com, penghuan...@chromium.org, bmcquad...@chromium.org, mercer...@google.com, giovax...@chromium.org, dmurph+wat...@chromium.org, lizeb...@chromium.org, mar...@chromium.org, chrome-tab-group-en...@google.com, rmcelra...@chromium.org, lighthouse-eng-extern...@google.com, permissio...@chromium.org, peilinwa...@google.com, jessemcke...@google.com, borealis-re...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, moqati-team+chr...@google.com, katie...@chromium.org, dtapuska+...@chromium.org, khorimoto+wa...@chromium.org, drott+bl...@chromium.org, petewi...@chromium.org, kouhei...@chromium.org, dmurph+wa...@chromium.org, jz...@chromium.org, asvitkine...@chromium.org, apaselti...@chromium.org, nwoked...@chromium.org, npm+...@chromium.org, stanfie...@google.com, enne...@chromium.org, thefro...@chromium.org, keithle...@chromium.org, roagarw...@chromium.org, blink-revi...@chromium.org, anastas...@google.com, crostin...@chromium.org, fuzzin...@chromium.org, tracing...@chromium.org, cblume...@chromium.org, jdonnel...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, sloboda...@chromium.org, blink-rev...@chromium.org, pkotwic...@chromium.org, chromotin...@chromium.org, dtraino...@chromium.org, harringt...@chromium.org, jonmann+wa...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, blink-revi...@chromium.org, ffred...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, twifka...@chromium.org, zackha...@chromium.org, cfredri...@chromium.org, jasonrobe...@google.com, scheduler...@chromium.org, ramyagopa...@google.com, csharris...@chromium.org, chromiumme...@microsoft.com, ydago...@chromium.org, tbarzi...@chromium.org, scheduler-...@chromium.org, horo+...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, olka+...@chromium.org, dominicc+...@chromium.org, ricea...@chromium.org, fmalit...@chromium.org, hsuregan+wat...@chromium.org, kinuko+ser...@chromium.org, yusufo...@chromium.org, ozone-...@chromium.org, michaelchec...@google.com, dmurph+watc...@chromium.org, rkgibso...@chromium.org, gogeral...@chromium.org, shannc...@chromium.org, chadduffin+w...@chromium.org, chadduffin+wa...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, yuzo+...@chromium.org, shimazu+se...@chromium.org, twelling...@chromium.org, chfreme...@chromium.org, aleventh...@chromium.org, omnibox-...@chromium.org, blink-...@chromium.org, amaliev+...@chromium.org, cros-print...@google.com, marinacio...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, torne...@chromium.org, meilian...@chromium.org, osaul+aut...@google.com, droger+w...@chromium.org, boujan...@google.com, johnche...@chromium.org, svend+w...@chromium.org, net-r...@chromium.org, estali...@chromium.org, thegreenf...@chromium.org, webauthn...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, ntp-dev...@chromium.org, rsesek...@chromium.org, abigailbk...@google.com, bcb+watch-pl...@chromium.org, dibyapal+wa...@chromium.org, gangwu...@chromium.org, pasko...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, ananyasee...@google.com, phoglun...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, knollr+wat...@chromium.org, yigu+...@chromium.org, jkeitel+watch-...@google.com, kenjibah...@chromium.org, dullweb...@chromium.org, chrome-gr...@chromium.org, blink-re...@chromium.org, dmurph+watching...@chromium.org, tmartino+tran...@chromium.org, mfoltz+wa...@chromium.org, hansberry+wa...@chromium.org, chromeos-ca...@google.com, max+watc...@igalia.com, shuche...@chromium.org, nicolas...@chromium.org, estaab...@chromium.org, web-schedulin...@chromium.org, bnc+...@chromium.org, mickeybu...@chromium.org, christia...@chromium.org, cambickel...@google.com, roblia...@chromium.org, gavin...@chromium.org, mattreyno...@chromium.org, stevenjb+wa...@chromium.org, nona+...@chromium.org, gab+...@chromium.org, webap...@microsoft.com, yongshun+...@google.com, dmurph+watchi...@chromium.org, mreichhoff+watc...@chromium.org, bartek...@chromium.org, vasilii+watchlis...@chromium.org, yfriedm...@chromium.org, browser-comp...@chromium.org, ender...@chromium.org, hiroshig...@chromium.org, mdjone...@chromium.org, nickdiego+wa...@igalia.com, pdf-r...@chromium.org, fgal...@chromium.org, asvitki...@chromium.org, lucasrada...@google.com, tburkar...@chromium.org, peter+watch...@chromium.org, chrstn...@google.com, media-cro...@chromium.org, blink-revie...@chromium.org, devtools-re...@chromium.org, gavinp+p...@chromium.org, dom+...@chromium.org, khorimoto+w...@chromium.org, minap+watch-p...@google.com, nator...@chromium.org, hayato...@chromium.org, fuchsia...@chromium.org, trewin...@google.com, yhanada+...@chromium.org, blink-re...@chromium.org, rayanka...@chromium.org, translat...@chromium.org, hsuregan+wa...@chromium.org, media-wi...@chromium.org, nikhilcn+wat...@google.com, jiajunz+wa...@google.com, mgiuca...@chromium.org, philli...@chromium.org, josiah...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, agriev...@chromium.org, vinnypersky+...@google.com, speed-metrics...@chromium.org, yhanada+...@chromium.org, storage...@chromium.org, marq+...@chromium.org, hashimo...@chromium.org, blink-revi...@chromium.org, zelin+watch-we...@chromium.org, language...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, oshima...@chromium.org

      Josiah Kiehl voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I543f504c6632fad4e2c72bf20d7093857818a164
      Gerrit-Change-Number: 7264491
      Gerrit-PatchSet: 18
      Gerrit-Comment-Date: Wed, 24 Dec 2025 20:49:32 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Dec 24, 2025, 4:20:29 PM (2 days ago) Dec 24
      to Josiah Kiehl, Ananya Seelam, James Maclean, David Bokan, Kevin Babbitt, Chromium Metrics Reviews, Wang, Wei4, Christian Biesinger, Victor Tan, Simon Hangl, Ian Vollick, Peter Williamson, Ryan Sultanem, Jiewei Qian, Olga Gerchikov, Nate Chapin, Stephen Chenney, Menard, Alexis, Urvang Joshi, Akihiro Ota, Avi Drissman, srirama chandra sekhar, Mirko Bonadei, Yoav Weiss (@Shopify), Javier Fernandez, Hans Wennborg, Rijubrata Bhaumik, Nikhil Nayunigari, Hu, Ningxin, Hiroki Nakagawa, Mike Taylor, Daniel Cheng, Kaan Icer, Peter Beverloo, Dirk Schulze, Andrew Rayskiy, Sadrul Chowdhury, Zijie He, Kenneth R Christiansen, Dirk Pranke, Raphael Kubo da Costa, Arnaud Mandy, Kentaro Hara, James Su, Enterprise Policy Reviews, Hongchan Choi, Jerome Jiang, (Julie)Jeongeun Kim, AyeAye, Juan Mojica, chromium...@chromium.org, Sophie Chang, feature-me...@chromium.org, mpdento...@chromium.org, jdeblas...@chromium.org, fserb...@chromium.org, dmurph+watch...@chromium.org, iwells...@chromium.org, extension...@chromium.org, sky+...@chromium.org, aashna...@google.com, blink-rev...@chromium.org, network-ser...@chromium.org, kinuko...@chromium.org, gavin...@chromium.org, srahim...@chromium.org, erickun...@chromium.org, fdoray...@chromium.org, cros-setti...@google.com, xinghui...@chromium.org, jackshira+w...@google.com, rginda...@chromium.org, fenced-fra...@chromium.org, halliwe...@chromium.org, jiajunz+wat...@google.com, prerenderi...@chromium.org, nyquis...@chromium.org, derinel+wat...@google.com, ios-web-view...@google.com, martijn...@martijnc.be, ios-revie...@chromium.org, alexmo...@chromium.org, hanxi...@chromium.org, ashleynewson+w...@chromium.org, francisjp...@google.com, blink-rev...@chromium.org, webapks-...@chromium.org, liu+wa...@chromium.org, jbauma...@chromium.org, kuragin+web-ap...@chromium.org, tluk+...@chromium.org, penghu...@chromium.org, filesapp...@chromium.org, dmurph+watch...@chromium.org, vakh+safe_br...@chromium.org, print-rev...@chromium.org, tgupta...@chromium.org, blink-re...@chromium.org, dcheng+c...@chromium.org, crmulli...@chromium.org, cbe-cep-eng...@google.com, jorgel...@chromium.org, chromium-a...@chromium.org, yhanad...@chromium.org, shgar+aut...@google.com, ios-rev...@chromium.org, eme-r...@chromium.org, asumane...@google.com, ortuno+w...@chromium.org, cros-report...@google.com, yuezhang...@chromium.org, ajwong...@chromium.org, dtapuska+ch...@chromium.org, rrsilva+wat...@google.com, jmedle...@chromium.org, donnd...@chromium.org, lwinston+watc...@google.com, kmg+...@google.com, ejcaruso+wa...@chromium.org, speed-metr...@chromium.org, njeunje+...@chromium.org, kenok...@google.com, croissant-...@chromium.org, loyso...@chromium.org, jeffreycohen+watc...@chromium.org, creis...@chromium.org, headless...@chromium.org, cwalle...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, chrome-waff...@google.com, siyua+aut...@chromium.org, spang...@chromium.org, siashah+au...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, marimatthew+watc...@google.com, armalhotra+a...@google.com, chrome-intelligence-te...@google.com, jshin...@chromium.org, core-timi...@chromium.org, jatapiaro+wat...@google.com, subresource-f...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org, feature-v...@chromium.org, shimazu...@chromium.org, davidj...@chromium.org, cros-enterpris...@chromium.org, chromeos-kio...@google.com, blink-reviews-p...@chromium.org, devtools...@chromium.org, niharm...@google.com, grt+...@chromium.org, apavlo...@chromium.org, jophba...@chromium.org, edgesto...@microsoft.com, tranbaod...@chromium.org, druber...@chromium.org, zol...@webkit.org, hirokisa...@chromium.org, chrome-intell...@chromium.org, toyosh...@chromium.org, gavinp...@chromium.org, kainin...@chromium.org, ayman...@chromium.org, yhiran...@chromium.org, dfried...@chromium.org, jackshira+wa...@google.com, chlily...@chromium.org, dewitt...@chromium.org, lens-chrome...@google.com, jdh+wa...@chromium.org, eic+...@google.com, penghuan...@chromium.org, bmcquad...@chromium.org, mercer...@google.com, giovax...@chromium.org, dmurph+wat...@chromium.org, lizeb...@chromium.org, mar...@chromium.org, chrome-tab-group-en...@google.com, rmcelra...@chromium.org, lighthouse-eng-extern...@google.com, permissio...@chromium.org, peilinwa...@google.com, jessemcke...@google.com, borealis-re...@google.com, chikamu...@chromium.org, gcasto+w...@chromium.org, moqati-team+chr...@google.com, katie...@chromium.org, dtapuska+...@chromium.org, khorimoto+wa...@chromium.org, drott+bl...@chromium.org, petewi...@chromium.org, kouhei...@chromium.org, dmurph+wa...@chromium.org, jz...@chromium.org, asvitkine...@chromium.org, apaselti...@chromium.org, nwoked...@chromium.org, npm+...@chromium.org, stanfie...@google.com, enne...@chromium.org, thefro...@chromium.org, keithle...@chromium.org, roagarw...@chromium.org, blink-revi...@chromium.org, anastas...@google.com, crostin...@chromium.org, fuzzin...@chromium.org, tracing...@chromium.org, cblume...@chromium.org, jdonnel...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, sloboda...@chromium.org, blink-rev...@chromium.org, pkotwic...@chromium.org, chromotin...@chromium.org, dtraino...@chromium.org, harringt...@chromium.org, jonmann+wa...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, blink-revi...@chromium.org, ffred...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, twifka...@chromium.org, zackha...@chromium.org, cfredri...@chromium.org, jasonrobe...@google.com, scheduler...@chromium.org, ramyagopa...@google.com, csharris...@chromium.org, chromiumme...@microsoft.com, ydago...@chromium.org, tbarzi...@chromium.org, scheduler-...@chromium.org, horo+...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, olka+...@chromium.org, dominicc+...@chromium.org, ricea...@chromium.org, fmalit...@chromium.org, hsuregan+wat...@chromium.org, kinuko+ser...@chromium.org, yusufo...@chromium.org, ozone-...@chromium.org, michaelchec...@google.com, dmurph+watc...@chromium.org, rkgibso...@chromium.org, gogeral...@chromium.org, shannc...@chromium.org, chadduffin+w...@chromium.org, chadduffin+wa...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, yuzo+...@chromium.org, shimazu+se...@chromium.org, twelling...@chromium.org, chfreme...@chromium.org, aleventh...@chromium.org, omnibox-...@chromium.org, blink-...@chromium.org, amaliev+...@chromium.org, cros-print...@google.com, marinacio...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, torne...@chromium.org, meilian...@chromium.org, osaul+aut...@google.com, droger+w...@chromium.org, boujan...@google.com, johnche...@chromium.org, svend+w...@chromium.org, net-r...@chromium.org, estali...@chromium.org, thegreenf...@chromium.org, webauthn...@chromium.org, lizeb+watch...@chromium.org, servicewor...@chromium.org, ntp-dev...@chromium.org, rsesek...@chromium.org, abigailbk...@google.com, bcb+watch-pl...@chromium.org, dibyapal+wa...@chromium.org, gangwu...@chromium.org, pasko...@chromium.org, blink-work...@chromium.org, mattsimm...@chromium.org, ananyasee...@google.com, phoglun...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, knollr+wat...@chromium.org, yigu+...@chromium.org, jkeitel+watch-...@google.com, kenjibah...@chromium.org, dullweb...@chromium.org, chrome-gr...@chromium.org, blink-re...@chromium.org, dmurph+watching...@chromium.org, tmartino+tran...@chromium.org, mfoltz+wa...@chromium.org, hansberry+wa...@chromium.org, chromeos-ca...@google.com, max+watc...@igalia.com, shuche...@chromium.org, nicolas...@chromium.org, estaab...@chromium.org, web-schedulin...@chromium.org, bnc+...@chromium.org, mickeybu...@chromium.org, christia...@chromium.org, cambickel...@google.com, roblia...@chromium.org, gavin...@chromium.org, mattreyno...@chromium.org, stevenjb+wa...@chromium.org, nona+...@chromium.org, gab+...@chromium.org, webap...@microsoft.com, yongshun+...@google.com, dmurph+watchi...@chromium.org, mreichhoff+watc...@chromium.org, bartek...@chromium.org, vasilii+watchlis...@chromium.org, yfriedm...@chromium.org, browser-comp...@chromium.org, ender...@chromium.org, hiroshig...@chromium.org, mdjone...@chromium.org, nickdiego+wa...@igalia.com, pdf-r...@chromium.org, fgal...@chromium.org, asvitki...@chromium.org, lucasrada...@google.com, tburkar...@chromium.org, peter+watch...@chromium.org, chrstn...@google.com, media-cro...@chromium.org, blink-revie...@chromium.org, devtools-re...@chromium.org, gavinp+p...@chromium.org, dom+...@chromium.org, khorimoto+w...@chromium.org, minap+watch-p...@google.com, nator...@chromium.org, hayato...@chromium.org, fuchsia...@chromium.org, trewin...@google.com, yhanada+...@chromium.org, blink-re...@chromium.org, rayanka...@chromium.org, translat...@chromium.org, hsuregan+wa...@chromium.org, media-wi...@chromium.org, nikhilcn+wat...@google.com, jiajunz+wa...@google.com, mgiuca...@chromium.org, philli...@chromium.org, josiah...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, agriev...@chromium.org, vinnypersky+...@google.com, speed-metrics...@chromium.org, yhanada+...@chromium.org, storage...@chromium.org, marq+...@chromium.org, hashimo...@chromium.org, blink-revi...@chromium.org, zelin+watch-we...@chromium.org, language...@chromium.org, wfh+...@chromium.org, wychen...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, oshima...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      12 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: chrome/test/data/webui/contextual_tasks/composebox_test.ts
      Insertions: 1, Deletions: 4.

      The diff is too large to show. Please review the diff.
      ```

      Change information

      Commit message:
      [Contextual Tasks] Hide the lens button when in full tab

      Hide the Lens button in the composebox when Contextual Tasks UI is in the full tab (rather than in a side panel).
      Fixed: b:467361672
      Change-Id: I543f504c6632fad4e2c72bf20d7093857818a164
      Auto-Submit: Josiah Kiehl <ki...@google.com>
      Commit-Queue: Josiah Kiehl <ki...@google.com>
      Reviewed-by: Ananya Seelam <ananya...@google.com>
      Reviewed-by: Juan Mojica <juanm...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1562528}
      Files:
      • M chrome/browser/resources/contextual_tasks/composebox.html.ts
      • M chrome/test/data/webui/contextual_tasks/composebox_test.ts
      • M ui/webui/resources/cr_components/composebox/composebox.html.ts
      • M ui/webui/resources/cr_components/composebox/composebox.ts
      Change size: S
      Delta: 4 files changed, 32 insertions(+), 4 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Juan Mojica, +1 by Ananya Seelam
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I543f504c6632fad4e2c72bf20d7093857818a164
      Gerrit-Change-Number: 7264491
      Gerrit-PatchSet: 19
      Gerrit-Owner: Josiah Kiehl <ki...@google.com>
      Gerrit-Reviewer: Ananya Seelam <ananya...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
      Gerrit-Reviewer: Juan Mojica <juanm...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
      Gerrit-CC: Avi Drissman <a...@chromium.org>
      Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages