[DBSC] Fix request deferral logic for non-initiating requests [chromium/src : main]

[Alex Ilin (Gerrit)]

Attention needed from Andrey Kosyakov, Chromium IPC Reviews and Daniel Rubery

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Chromium IPC Reviews
• Daniel Rubery

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia9d1a71a3f45708df80b1ea39f2c0438e2dacc47

Gerrit-Change-Number: 7747885

Gerrit-PatchSet: 2

Gerrit-Owner: Alex Ilin <alex...@chromium.org>

Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>

Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-Attention: Daniel Rubery <dru...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 16:55:14 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[gwsq (Gerrit)]

Attention needed from Andrey Kosyakov, Daniel Rubery and Mike West

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mk...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): mk...@chromium.org

Reviewer source(s):
mk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Daniel Rubery
• Mike West

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia9d1a71a3f45708df80b1ea39f2c0438e2dacc47

Gerrit-Change-Number: 7747885

Gerrit-PatchSet: 2

Gerrit-Owner: Alex Ilin <alex...@chromium.org>

Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>

Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>

Gerrit-Reviewer: Mike West <mk...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: gwsq

Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Attention: Mike West <mk...@chromium.org>

Gerrit-Attention: Daniel Rubery <dru...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 16:57:03 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Andrey Kosyakov (Gerrit)]

Attention needed from Alex Ilin, Daniel Rubery and Mike West

Andrey Kosyakov voted and added 1 comment

Votes added by Andrey Kosyakov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Andrey Kosyakov . resolved

devtools rslgtm

Open in Gerrit

Related details

Attention is currently required from:

• Alex Ilin
• Daniel Rubery
• Mike West

Gerrit-Attention: Alex Ilin <alex...@chromium.org>

Gerrit-Attention: Mike West <mk...@chromium.org>

Gerrit-Attention: Daniel Rubery <dru...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 17:11:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Mike West (Gerrit)]

Attention needed from Alex Ilin and Daniel Rubery

Mike West voted and added 1 comment

Votes added by Mike West

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Mike West . resolved

mojo lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Alex Ilin
• Daniel Rubery

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia9d1a71a3f45708df80b1ea39f2c0438e2dacc47

Gerrit-Change-Number: 7747885

Gerrit-PatchSet: 2

Gerrit-Owner: Alex Ilin <alex...@chromium.org>

Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>

Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>

Gerrit-Reviewer: Mike West <mk...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: gwsq

Gerrit-Attention: Alex Ilin <alex...@chromium.org>

Gerrit-Attention: Daniel Rubery <dru...@chromium.org>

Gerrit-Comment-Date: Tue, 14 Apr 2026 08:48:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Alex Ilin (Gerrit)]

Attention needed from Daniel Rubery

Alex Ilin voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Rubery

Gerrit-Attention: Daniel Rubery <dru...@chromium.org>

Gerrit-Comment-Date: Tue, 14 Apr 2026 13:00:33 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)]

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

[DBSC] Fix request deferral logic for non-initiating requests

When multiple requests are deferred waiting for a DBSC session refresh,
the refresh context might be different from a waiting request's context
and thus the refresh might not set all of the required cookies.

Previously, all requests in the batch would be released after a refresh
completes, even if a bound cookie is still missing for some of them.
This CL changes that by allowing deferred requests to trigger a refresh
again if this request wasn't initiating a refresh initially.

Fixed: 500417358

Change-Id: Ia9d1a71a3f45708df80b1ea39f2c0438e2dacc47

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7747885

Reviewed-by: Daniel Rubery <dru...@chromium.org>

Commit-Queue: Alex Ilin <alex...@chromium.org>

Reviewed-by: Andrey Kosyakov <ca...@chromium.org>

Reviewed-by: Mike West <mk...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1614415}

Files:

• M content/browser/devtools/protocol/network_handler.cc
• M net/device_bound_sessions/refresh_result.h
• M net/device_bound_sessions/session_service_impl.cc
• M net/device_bound_sessions/session_service_impl.h
• M net/device_bound_sessions/session_service_impl_unittest.cc
• M services/network/public/cpp/device_bound_sessions_mojom_traits.cc
• M services/network/public/mojom/device_bound_sessions.mojom
• M third_party/blink/public/devtools_protocol/domains/Network.pdl
• M tools/metrics/histograms/metadata/net/enums.xml

Change size: M

Delta: 9 files changed, 101 insertions(+), 6 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Andrey Kosyakov, +1 by Daniel Rubery, +1 by Mike West

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia9d1a71a3f45708df80b1ea39f2c0438e2dacc47

Gerrit-Change-Number: 7747885

Gerrit-PatchSet: 3

Gerrit-Owner: Alex Ilin <alex...@chromium.org>

Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>

Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>

Gerrit-Reviewer: Mike West <mk...@chromium.org>

Gerrit-Reviewer: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq