[security] Render the origin display with Lit [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Hojeong Park (Gerrit)
Jun 25, 2026, 12:37:26 PM (9 days ago) Jun 25
to Danil Somsikov, devtools-rev...@chromium.org
Attention needed from Danil Somsikov
Hojeong Park added 1 comment![]( "Open in Gerrit")
File front_end/panels/security/SecurityPanel.ts
Line 535, Patchset 1:
export function createHighlightedUrl(url: Platform.DevToolsPath.UrlString, securityState: string): Element {Danil Somsikov . resolved
Hojeong ParkWhy don't we use the new function right away? It is only used in tests and at single point in this file. There you can simply do
```
render(
renderHighlightedUrl(createHighlightedUrl(origin, originState.securityState),
originDisplay);
```
Thanks. Done for the origin view.
But I kept createHighlightedUrl since SecurityPanelSidebar also uses it and needs an Element there. SettingsUI.createControlForSetting follows the same pattern. What do you think?
Related details
Attention is currently required from:
- Danil Somsikov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
Jun 25, 2026, 12:55:55 PM (9 days ago) Jun 25
to Hojeong Park, devtools-rev...@chromium.org
Attention needed from Hojeong Park
Danil Somsikov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hojeong Park
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alina Varkki (Gerrit)
Jun 30, 2026, 5:37:34 AM (4 days ago) Jun 30
to Hojeong Park, Danil Somsikov, devtools-rev...@chromium.org
Attention needed from Hojeong Park
Alina Varkki voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hojeong Park
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hojeong Park (Gerrit)
Jun 30, 2026, 9:51:57 AM (4 days ago) Jun 30
to Alina Varkki, Danil Somsikov, devtools-rev...@chromium.org
Hojeong Park added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Hojeong Park . resolved
Thanks for the review. This is ready to submit, but I don't have permission. Could you submit this for me?
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
Jun 30, 2026, 9:54:21 AM (4 days ago) Jun 30
to Hojeong Park, Alina Varkki, devtools-rev...@chromium.org
Attention needed from Hojeong Park
Danil Somsikov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Hojeong Park
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hojeong Park (Gerrit)
Jun 30, 2026, 1:47:58 PM (4 days ago) Jun 30
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, Danil Somsikov, Alina Varkki, devtools-rev...@chromium.org
Attention needed from Danil Somsikov
Hojeong Park added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hojeong Park . resolved
The failing checks are DevTools web tests that dump the deep DOM.
This seems to need a Chromium-side rebaseline. What do you think?
Related details
Attention is currently required from:
- Danil Somsikov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
Jul 2, 2026, 4:35:13 AM (2 days ago) Jul 2
to Hojeong Park, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, Alina Varkki, devtools-rev...@chromium.org
Attention needed from Hojeong Park
Danil Somsikov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hojeong Park . unresolved
The failing checks are DevTools web tests that dump the deep DOM.
This seems to need a Chromium-side rebaseline. What do you think?
Danil Somsikov
Yup. Disable the chromium test first (in the TestExpectations file), land this, wait for the roll, and rebaseline and re-enable then.
Related details
Attention is currently required from:
- Hojeong Park
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hojeong Park (Gerrit)
Jul 3, 2026, 1:49:38 AM (yesterday) Jul 3
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, Danil Somsikov, Alina Varkki, devtools-rev...@chromium.org
Attention needed from Alina Varkki and Danil Somsikov
Hojeong Park added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Danil SomsikovThe failing checks are DevTools web tests that dump the deep DOM.
This seems to need a Chromium-side rebaseline. What do you think?
Yup. Disable the chromium test first (in the TestExpectations file), land this, wait for the roll, and rebaseline and re-enable then.
Hojeong Park
Thanks for explaining. I made a CL to disable the Chromium tests: crrev.com/c/8038580
Related details
Attention is currently required from:
- Alina Varkki
- Danil Somsikov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
Jul 3, 2026, 4:34:21 AM (yesterday) Jul 3
to Hojeong Park, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, Alina Varkki, devtools-rev...@chromium.org
Attention needed from Alina Varkki and Hojeong Park
Danil Somsikov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alina Varkki
- Hojeong Park
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alina Varkki (Gerrit)
Jul 3, 2026, 5:07:49 AM (yesterday) Jul 3
to Hojeong Park, Danil Somsikov, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Hojeong Park
Alina Varkki voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hojeong Park
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hojeong Park (Gerrit)
Jul 3, 2026, 10:03:37 AM (yesterday) Jul 3
to Alina Varkki, Danil Somsikov, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Hojeong Park added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Hojeong Park . resolved
Since CL 8038580 has landed, would it be okay to land this CL?
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
Jul 3, 2026, 10:39:36 AM (yesterday) Jul 3
to Hojeong Park, Alina Varkki, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Hojeong Park
Danil Somsikov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Hojeong Park
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 3, 2026, 11:10:40 AM (yesterday) Jul 3
to Hojeong Park, Danil Somsikov, Alina Varkki, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[security] Render the origin display with Lit
`SecurityOriginView` renders its security-state icon and highlighted URL
with Lit in `#renderOriginDisplay`, called on construction and on
security state changes. `createHighlightedUrl` is kept for
`SecurityPanelSidebar`.
Bug: None
Change-Id: I3e848731515f51efe4e989609a7604613fc8e986
Reviewed-by: Alina Varkki <alina...@chromium.org>
Reviewed-by: Danil Somsikov <d...@chromium.org>
Commit-Queue: Danil Somsikov <d...@chromium.org>
Files:
- M AUTHORS
- M front_end/panels/security/SecurityPanel.test.ts
- M front_end/panels/security/SecurityPanel.ts
Change size: M
Delta: 3 files changed, 63 insertions(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Danil Somsikov, +1 by Alina Varkki
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages