[contexutal tasks] Various fixes for zero state [chromium/src : main]

0 views

Skip to first unread message

Duncan Mercer (Gerrit)

unread,

Dec 23, 2025, 2:42:17 PM (3 days ago) Dec 23

to James Leung, Josiah Kiehl, AyeAye, Juan Mojica, chromium...@chromium.org, Sophie Chang, penghuan...@chromium.org, cblume...@chromium.org, devtools...@chromium.org

Attention needed from James Leung, Josiah Kiehl and Juan Mojica

Duncan Mercer added 2 comments

File chrome/browser/contextual_tasks/contextual_tasks_ui.cc

Line 723, Patchset 8 (Latest):

  if (!ui_service_->IsAiUrl(url)) {
    return;
  }

Duncan Mercer . unresolved

remove

File chrome/browser/resources/contextual_tasks/zero_state_overlay.ts

Line 44, Patchset 8 (Latest):

    this.$.opaqueOverlay.classList.remove('fade-animation');
    /* Requesting offsetWidth forces css re-render (synchronous reflow)
     * since browser wants to be accurate awhen giving current measurement
     * of offsetWidth. Otherwise, browser is lazy and considers adding
     * then removing class as not a renderable css change.
     */
    void this.$.opaqueOverlay.offsetWidth;
    this.$.opaqueOverlay.classList.add('fade-animation');

Duncan Mercer . unresolved

Should we use Javascript animation API instead?

https://developer.mozilla.org/en-US/docs/Web/API/Element/animate
Example: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/lens/overlay/post_selection_renderer.ts;drc=d5676105bb69e27fef735d74d556f288d937c4db;l=670

Open in Gerrit

Related details

Attention is currently required from:

James Leung
Josiah Kiehl
Juan Mojica

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages