[Sheriff]: Fix a couple of flaky tests. [devtools/devtools-frontend : main]
Finnur Thorarinsson (Gerrit)
Finnur Thorarinsson voted and added 3 comments![]( "Open in Gerrit")
Votes added by Finnur Thorarinsson
| Auto-Submit | +1 |
3 comments
As I mentioned, I wrote a simple skill to fetch the flaky tests from the hotlist and try repro'ing, investigating and suggesting a fix. Here's the outcome for two of those. Please take a look and see if the fixes make sense.
await Promise.all([This (and the next one) is an AI-suggested fix with the comment:
"This is a known anti-pattern in DevTools e2e tests because page navigations trigger `Main.targetNavigated` events that can reset or interrupt DevTools UI states (such as closing the Command Menu mid-keystroke)."
Do you agree?
await devToolsPage.click('.link-swatch-link');This one I managed to repro locally and after this AI suggested fix was unable to repro again (ran it 250 times).
"The test was using `devToolsPage.click('.link-swatch-link')`, which globally searches for the first matching element on the page. Due to asynchronous rendering, this sometimes matched the wrong swatch link, causing the subsequent event assertions to fail."
Related details
- Alex Rudenko
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |