Network: ensure too large images are linked [devtools/devtools-frontend : main]

1 view
Skip to first unread message

Jack Franklin (Gerrit)

unread,
May 14, 2026, 10:20:12β€―AMΒ (10 days ago)Β May 14
to Kim-Anh Tran, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran

Jack Franklin added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jack Franklin . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Kim-Anh Tran
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Id10126101598f881dce5cdbdb3714a45bc211113
Gerrit-Change-Number: 7849515
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Attention: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Comment-Date: Thu, 14 May 2026 14:20:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kim-Anh Tran (Gerrit)

unread,
May 18, 2026, 2:41:32β€―AMΒ (7 days ago)Β May 18
to Jack Franklin, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Jack Franklin

Kim-Anh Tran added 2 comments

Patchset-level comments
Kim-Anh Tran . resolved

Hi Jack, generally LGTM, but I want to double check the icon colors etc. could you please provide me with the correct link 😊?

Commit Message
Line 16, Patchset 1 (Latest):screen/8MG9aA6ov9CcM4U
Kim-Anh Tran . unresolved

This link doesn't seem to work for me?

Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Id10126101598f881dce5cdbdb3714a45bc211113
    Gerrit-Change-Number: 7849515
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
    Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 May 2026 06:41:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kim-Anh Tran (Gerrit)

    unread,
    May 18, 2026, 2:57:25β€―AMΒ (7 days ago)Β May 18
    to Jack Franklin, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
    Attention needed from Jack Franklin

    Kim-Anh Tran added 2 comments

    Commit Message
    Line 16, Patchset 1 (Latest):screen/8MG9aA6ov9CcM4U
    Kim-Anh Tran . resolved

    This link doesn't seem to work for me?

    Kim-Anh Tran

    I tried go/screen/.. before, my bad!

    but got it now 😊.

    File front_end/ui/legacy/components/source_frame/ImageView.ts
    Line 135, Patchset 1 (Latest): this.imageUnavailableElement = this.container.createChild('div', 'resource-image-unavailable');
    Kim-Anh Tran . unresolved

    Can we use `devtools-link` here?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jack Franklin
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Id10126101598f881dce5cdbdb3714a45bc211113
    Gerrit-Change-Number: 7849515
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
    Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 May 2026 06:57:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Kim-Anh Tran <kim...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jack Franklin (Gerrit)

    unread,
    May 22, 2026, 2:16:44β€―PMΒ (2 days ago)Β May 22
    to Kim-Anh Tran, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
    Attention needed from Kim-Anh Tran

    Jack Franklin voted and added 2 comments

    Votes added by Jack Franklin

    Auto-Submit+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Jack Franklin . resolved

    PTAL (sorry this took so long to get to!)

    File front_end/ui/legacy/components/source_frame/ImageView.ts
    Line 135, Patchset 1: this.imageUnavailableElement = this.container.createChild('div', 'resource-image-unavailable');
    Kim-Anh Tran . resolved

    Can we use `devtools-link` here?

    Jack Franklin

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kim-Anh Tran
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: Id10126101598f881dce5cdbdb3714a45bc211113
      Gerrit-Change-Number: 7849515
      Gerrit-PatchSet: 2
      Gerrit-Attention: Kim-Anh Tran <kim...@chromium.org>
      Gerrit-Comment-Date: Fri, 22 May 2026 18:16:42 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Kim-Anh Tran <kim...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages