Network: ensure too large images are linked [devtools/devtools-frontend : main]
1 view
Skip to first unread message
Jack Franklin (Gerrit)
May 14, 2026, 10:20:12β―AMΒ (10 days ago)Β May 14
to Kim-Anh Tran, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran
Jack Franklin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Kim-Anh Tran
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kim-Anh Tran (Gerrit)
May 18, 2026, 2:41:32β―AMΒ (7 days ago)Β May 18
to Jack Franklin, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Kim-Anh Tran added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Kim-Anh Tran . resolved
Hi Jack, generally LGTM, but I want to double check the icon colors etc. could you please provide me with the correct link π?
Commit Message
Line 16, Patchset 1 (Latest):
screen/8MG9aA6ov9CcM4UKim-Anh Tran . unresolved
This link doesn't seem to work for me?
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kim-Anh Tran (Gerrit)
May 18, 2026, 2:57:25β―AMΒ (7 days ago)Β May 18
to Jack Franklin, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Kim-Anh Tran added 2 comments![]( "Open in Gerrit")
Commit Message
Line 16, Patchset 1 (Latest):
screen/8MG9aA6ov9CcM4UKim-Anh Tran . resolved
This link doesn't seem to work for me?
Kim-Anh Tran
I tried go/screen/.. before, my bad!
but got it now π.
File front_end/ui/legacy/components/source_frame/ImageView.ts
Line 135, Patchset 1 (Latest):
this.imageUnavailableElement = this.container.createChild('div', 'resource-image-unavailable');Kim-Anh Tran . unresolved
Can we use `devtools-link` here?
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
May 22, 2026, 2:16:44β―PMΒ (2 days ago)Β May 22
to Kim-Anh Tran, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran
Jack Franklin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jack Franklin
| Auto-Submit | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Jack Franklin . resolved
PTAL (sorry this took so long to get to!)
File front_end/ui/legacy/components/source_frame/ImageView.ts
Line 135, Patchset 1:
this.imageUnavailableElement = this.container.createChild('div', 'resource-image-unavailable');Kim-Anh Tran . resolved
Can we use `devtools-link` here?
Attention is currently required from:
- Kim-Anh Tran
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages