Linkify links in the markdown response from LLM [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Nikolay Vitkov (Gerrit)
8:54 AM (6 hours ago) 8:54 AM
to Jack Franklin, Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Jack Franklin
Nikolay Vitkov voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alex Rudenko
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
8:56 AM (6 hours ago) 8:56 AM
to Jack Franklin, Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Jack Franklin
Nikolay Vitkov added 1 comment![]( "Open in Gerrit")
File front_end/models/ai_assistance/agents/ContextSelectionAgent.ts
Line 56, Patchset 6 (Latest):
* Use type \`#req\` for network request and \`#file\` for source files. Only use ID inside the link, never ask about user selecting by ID.Nikolay Vitkov . unresolved
Note here for some reason without the `#` in the types it start giving links like
[<text>](req-1). This seems to mitigate that.
Related details
Attention is currently required from:
- Alex Rudenko
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
9:00 AM (6 hours ago) 9:00 AM
to Nikolay Vitkov, Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin and Nikolay Vitkov
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jack Franklin
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
9:04 AM (6 hours ago) 9:04 AM
to Nikolay Vitkov, Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov
Jack Franklin voted and added 3 comments![]( "Open in Gerrit")
Votes added by Jack Franklin
| Code-Review | +1 |
3 comments
Patchset-level comments
File front_end/models/ai_assistance/agents/ContextSelectionAgent.ts
Line 56, Patchset 9 (Latest):
* Use type \`#req\` for network request and \`#file\` for source files. Only use ID inside the link, never ask about user selecting by ID.Jack Franklin . unresolved
this is quite unclearly phrased. do you mean to say never to ask the user to select an ID or tell it an ID?
File front_end/panels/ai_assistance/components/MarkdownRendererWithCodeBlock.ts
Line 28, Patchset 9 (Latest):
#revealableLink(revealable: unknown, label: string): Lit.LitTemplate {Jack Franklin . unresolved
should we update / add tests for this?
Related details
Attention is currently required from:
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
9:41 AM (5 hours ago) 9:41 AM
to Jack Franklin, Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Jack Franklin
Nikolay Vitkov voted and added 3 comments![]( "Open in Gerrit")
Votes added by Nikolay Vitkov
| Auto-Submit | +1 |
3 comments
File front_end/models/ai_assistance/agents/ContextSelectionAgent.ts
Line 56, Patchset 6:
* Use type \`#req\` for network request and \`#file\` for source files. Only use ID inside the link, never ask about user selecting by ID.Nikolay Vitkov . resolved
Note here for some reason without the `#` in the types it start giving links like
[<text>](req-1). This seems to mitigate that.
Nikolay Vitkov
Done
Line 56, Patchset 9:
* Use type \`#req\` for network request and \`#file\` for source files. Only use ID inside the link, never ask about user selecting by ID.Jack Franklin . resolved
this is quite unclearly phrased. do you mean to say never to ask the user to select an ID or tell it an ID?
Nikolay Vitkov
Acknowledged
File front_end/panels/ai_assistance/components/MarkdownRendererWithCodeBlock.ts
Line 28, Patchset 9:
#revealableLink(revealable: unknown, label: string): Lit.LitTemplate {Jack Franklin . resolved
should we update / add tests for this?
Attention is currently required from:
- Alex Rudenko
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
10:11 AM (5 hours ago) 10:11 AM
to Nikolay Vitkov, Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Nikolay Vitkov
Jack Franklin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jack Franklin
| Code-Review | +1 |
| Commit-Queue | +2 |
Jack Franklin . resolved
lgtm
Attention is currently required from:
- Alex Rudenko
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
12:09 PM (3 hours ago) 12:09 PM
to Nikolay Vitkov, Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin and Nikolay Vitkov
Alex Rudenko voted![]( "Open in Gerrit")
Attention is currently required from:
- Jack Franklin
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
12:15 PM (2 hours ago) 12:15 PM
to Nikolay Vitkov, Alex Rudenko, Jack Franklin, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Linkify links in the markdown response from LLM
We provide a simple mechanism to link from the Markdown LLM,
For network request we have uniqueId to use for that.
For source files we have to create our own, currently
kept around in the ContextSelectionAgent as a
WeakMap between SourceFile and Number.
If no resource is found the text is rendered as plain text.
Fixed: 486780335
Change-Id: I02f46ee2c97aa3d92993b7e8c7a8df5794900172
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Auto-Submit: Nikolay Vitkov <nvi...@chromium.org>
Reviewed-by: Jack Franklin <jacktf...@chromium.org>
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Files:
- M front_end/models/ai_assistance/AiConversation.test.ts
- M front_end/models/ai_assistance/agents/ContextSelectionAgent.snapshot.txt
- M front_end/models/ai_assistance/agents/ContextSelectionAgent.test.ts
- M front_end/models/ai_assistance/agents/ContextSelectionAgent.ts
- M front_end/panels/ai_assistance/components/MarkdownRendererWithCodeBlock.test.ts
- M front_end/panels/ai_assistance/components/MarkdownRendererWithCodeBlock.ts
Change size: L
Delta: 6 files changed, 237 insertions(+), 100 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko, +1 by Jack Franklin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages