compute pressure: Add virtual pressure source support to CDP [chromium/src : main]

0 views

Skip to first unread message

Reilly Grant (Gerrit)

unread,

Jul 2, 2024, 5:51:30 PM (12 hours ago) Jul 2

to Raphael Kubo Da Costa, Reilly Grant, Chromium LUCI CQ, Arnaud Mandy, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, Wei4 Wang, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org

Attention needed from Raphael Kubo Da Costa

Reilly Grant added 2 comments

File content/browser/compute_pressure/pressure_client_impl.cc

Line 52, Patchset 1 (Latest):

    if (auto* web_contents_pressure_manager_proxy =
            service_->web_contents_pressure_manager_proxy()) {

Reilly Grant . unresolved

This condition is always going to be true because you call `WebContentsPressureManagerProxy::GetOrCreate()`, which will create the object if it doesn't exist.

File content/browser/compute_pressure/pressure_service_for_frame.h

Line 29, Patchset 1 (Latest): WebContentsPressureManagerProxy* web_contents_pressure_manager_proxy()

Reilly Grant . unresolved

This isn't a trivial getter.

```suggestion
  WebContentsPressureManagerProxy* GetWebContentsPressureManagerProxy()
```

Open in Gerrit

Related details

Attention is currently required from:

Raphael Kubo Da Costa

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages