[DevTools][AI Assistant] Enable Drag-and-Drop Image Upload To Prompt Box. [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Emir D (Gerrit)
Jan 13, 2026, 3:26:42 PM (7 days ago) Jan 13
to Ergün Erdoğmuş, AyeAye, devtools-rev...@chromium.org
Attention needed from Ergün Erdoğmuş
Emir D voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Ergün Erdoğmuş
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ergün Erdoğmuş (Gerrit)
Jan 14, 2026, 7:40:38 AM (6 days ago) Jan 14
to Emir D, Jack Franklin, AyeAye, devtools-rev...@chromium.org
Attention needed from Emir D and Jack Franklin
Ergün Erdoğmuş added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Emir D
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emir D (Gerrit)
Jan 18, 2026, 6:16:08 AM (2 days ago) Jan 18
to Jack Franklin, Ergün Erdoğmuş, AyeAye, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Emir D added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
Jan 19, 2026, 9:39:56 AM (21 hours ago) Jan 19
to Emir D, Samiya Caur, Ergün Erdoğmuş, AyeAye, devtools-rev...@chromium.org
Attention needed from Emir D and Samiya Caur
Jack Franklin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jack Franklin
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Jack Franklin . resolved
lgtm thank you! Adding Samiya as external contributions need 2 reviews
Related details
Attention is currently required from:
- Emir D
- Samiya Caur
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samiya Caur (Gerrit)
Jan 19, 2026, 10:18:19 AM (20 hours ago) Jan 19
to Emir D, Devtools-frontend LUCI CQ, Jack Franklin, Ergün Erdoğmuş, AyeAye, devtools-rev...@chromium.org
Attention needed from Emir D and Jack Franklin
Samiya Caur added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Samiya Caur . resolved
Thank you for sending this CL! Left 1 small comment.
File front_end/panels/ai_assistance/components/ChatInput.ts
Line 591, Patchset 2 (Latest):
event.preventDefault();
const files = event.dataTransfer?.files;
if (!files || files.length === 0) {
return;
}
const imageFile = Array.from(files).find(file => file.type.startsWith('image/'));
if (!imageFile) {
return;
}
void this.#handleLoadImage(imageFile);Samiya Caur . unresolved
Since this block of code is similar to code in `#handleImagePaste`, maybe we can refactor this into a function like `#handleImageDataTransferEvent(dataTransfer: DataTransfer | null, event: Event)`?
Also, nit: add `;` at the end of `#handleImageDragOver` and `#handleImageDrop`.
Related details
Attention is currently required from:
- Emir D
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emir D (Gerrit)
Jan 19, 2026, 2:12:02 PM (16 hours ago) Jan 19
to Devtools-frontend LUCI CQ, Samiya Caur, Jack Franklin, Ergün Erdoğmuş, AyeAye, devtools-rev...@chromium.org
Attention needed from Jack Franklin and Samiya Caur
Emir D voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emir D
| Auto-Submit | +1 |
1 comment
File front_end/panels/ai_assistance/components/ChatInput.ts
Line 591, Patchset 2:
event.preventDefault();
const files = event.dataTransfer?.files;
if (!files || files.length === 0) {
return;
}
const imageFile = Array.from(files).find(file => file.type.startsWith('image/'));
if (!imageFile) {
return;
}
void this.#handleLoadImage(imageFile);Samiya Caur . resolved
Since this block of code is similar to code in `#handleImagePaste`, maybe we can refactor this into a function like `#handleImageDataTransferEvent(dataTransfer: DataTransfer | null, event: Event)`?
Also, nit: add `;` at the end of `#handleImageDragOver` and `#handleImageDrop`.
Emir D
The patchset 3 has been uploaded. Now, we are using handleImageDataTransferEvent to handle handleImageDragOver, handleImageDrop and handleImagePaste.
Related details
Attention is currently required from:
- Jack Franklin
- Samiya Caur
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samiya Caur (Gerrit)
2:20 AM (4 hours ago) 2:20 AM
to Emir D, Devtools-frontend LUCI CQ, Jack Franklin, Ergün Erdoğmuş, AyeAye, devtools-rev...@chromium.org
Attention needed from Emir D and Jack Franklin
Samiya Caur voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Emir D
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages