Migrate Build Scripts to ESM [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Nikolay Vitkov (Gerrit)
Dec 3, 2025, 9:23:50 AMDec 3
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Nikolay Vitkov added 1 comment![]( "Open in Gerrit")
File scripts/build/compress_files.js
Line 75, Patchset 1 (Latest):
let prevHash = '';Nikolay Vitkov . unresolved
I changed the code here as I found it hard to understand else.
Related details
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
Dec 3, 2025, 9:42:06 AMDec 3
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov
Simon Zünd voted and added 2 comments![]( "Open in Gerrit")
Votes added by Simon Zünd
| Code-Review | +1 |
2 comments
Patchset-level comments
File scripts/build/compress_files.js
Line 75, Patchset 1 (Latest):
let prevHash = '';Nikolay Vitkov . resolved
I changed the code here as I found it hard to understand else.
Attention is currently required from:
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Dec 3, 2025, 9:57:56 AMDec 3
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Nikolay Vitkov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Dec 3, 2025, 9:59:40 AMDec 3
to Nikolay Vitkov, Simon Zünd, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Migrate Build Scripts to ESM
This migrates all our scripts used in building DevTools to ESM.
Tested locally and works, we should monitor the roll to Chromium
to ensure we are doing this correctly.
Bug: 411053158
Change-Id: I4e320917609b3c37e7dccc8c2c197d0c7137cc70
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Reviewed-by: Simon Zünd <szu...@chromium.org>
Files:
- M scripts/build/compress_files.js
- M scripts/build/cross_reference_ninja_and_tsc.js
- M scripts/build/devtools_plugin.js
- M scripts/build/esbuild.js
- M scripts/build/generate_css_js_files.js
- M scripts/build/generate_html_entrypoint.js
- M scripts/build/ninja/copy-file.js
- M scripts/build/ninja/copy-files.js
- M scripts/build/ninja/generate-declaration.js
- M scripts/build/ninja/generate-tsconfig.js
- M scripts/build/ninja/minify-json-files.js
- M scripts/build/ninja/write-if-changed.js
- M scripts/build/tests/generate_css_js_files_test.js
- M scripts/build/tests/plugins_test.js
Change size: M
Delta: 14 files changed, 139 insertions(+), 89 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Simon Zünd
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noah Rose Ledesma (Gerrit)
7:03 PM (5 hours ago) 7:03 PM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, Simon Zünd, devtools-rev...@chromium.org
Noah Rose Ledesma added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Noah Rose Ledesma . unresolved
This change may be causing some flakiness in Chromium builds, e.g.:
and
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages