Migrate Build Scripts to ESM [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Nikolay Vitkov (Gerrit)

unread,
Dec 3, 2025, 9:23:50 AMDec 3
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd

Nikolay Vitkov added 1 comment

File scripts/build/compress_files.js
Line 75, Patchset 1 (Latest): let prevHash = '';
Nikolay Vitkov . unresolved

I changed the code here as I found it hard to understand else.

Open in Gerrit

Related details

Attention is currently required from:
  • Simon Zünd
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I4e320917609b3c37e7dccc8c2c197d0c7137cc70
Gerrit-Change-Number: 7222810
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Dec 2025 14:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Simon Zünd (Gerrit)

unread,
Dec 3, 2025, 9:42:06 AMDec 3
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov

Simon Zünd voted and added 2 comments

Votes added by Simon Zünd

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Simon Zünd . resolved

lgtm, thanks!

File scripts/build/compress_files.js
Nikolay Vitkov . resolved

I changed the code here as I found it hard to understand else.

Simon Zünd

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • Nikolay Vitkov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I4e320917609b3c37e7dccc8c2c197d0c7137cc70
Gerrit-Change-Number: 7222810
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Dec 2025 14:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nikolay Vitkov <nvi...@chromium.org>
satisfied_requirement
open
diffy

Nikolay Vitkov (Gerrit)

unread,
Dec 3, 2025, 9:57:56 AMDec 3
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Nikolay Vitkov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I4e320917609b3c37e7dccc8c2c197d0c7137cc70
Gerrit-Change-Number: 7222810
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 14:57:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
Dec 3, 2025, 9:59:40 AMDec 3
to Nikolay Vitkov, Simon Zünd, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Migrate Build Scripts to ESM

This migrates all our scripts used in building DevTools to ESM.
Tested locally and works, we should monitor the roll to Chromium
to ensure we are doing this correctly.
Bug: 411053158
Change-Id: I4e320917609b3c37e7dccc8c2c197d0c7137cc70
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Reviewed-by: Simon Zünd <szu...@chromium.org>
Files:
  • M scripts/build/compress_files.js
  • M scripts/build/cross_reference_ninja_and_tsc.js
  • M scripts/build/devtools_plugin.js
  • M scripts/build/esbuild.js
  • M scripts/build/generate_css_js_files.js
  • M scripts/build/generate_html_entrypoint.js
  • M scripts/build/ninja/copy-file.js
  • M scripts/build/ninja/copy-files.js
  • M scripts/build/ninja/generate-declaration.js
  • M scripts/build/ninja/generate-tsconfig.js
  • M scripts/build/ninja/minify-json-files.js
  • M scripts/build/ninja/write-if-changed.js
  • M scripts/build/tests/generate_css_js_files_test.js
  • M scripts/build/tests/plugins_test.js
Change size: M
Delta: 14 files changed, 139 insertions(+), 89 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Simon Zünd
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I4e320917609b3c37e7dccc8c2c197d0c7137cc70
Gerrit-Change-Number: 7222810
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement

Noah Rose Ledesma (Gerrit)

unread,
7:03 PM (5 hours ago) 7:03 PM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, Simon Zünd, devtools-rev...@chromium.org

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I4e320917609b3c37e7dccc8c2c197d0c7137cc70
Gerrit-Change-Number: 7222810
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Noah Rose Ledesma <noah...@google.com>
Gerrit-Comment-Date: Wed, 31 Dec 2025 00:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages