[cleanup] Fixed found by eslint-plugin-lit [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Nikolay Vitkov (Gerrit)

unread,
7:34 AM (3 hours ago) 7:34 AM
to Benedikt Meurer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer

Nikolay Vitkov voted and added 1 comment

Votes added by Nikolay Vitkov

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Nikolay Vitkov . resolved

PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Benedikt Meurer
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I213d71ae2a38bd873d349a2a9c292e998027c87e
Gerrit-Change-Number: 7120618
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Nov 2025 12:33:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Benedikt Meurer (Gerrit)

unread,
7:53 AM (3 hours ago) 7:53 AM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov

Benedikt Meurer voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Nikolay Vitkov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I213d71ae2a38bd873d349a2a9c292e998027c87e
Gerrit-Change-Number: 7120618
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Nov 2025 12:53:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
8:06 AM (3 hours ago) 8:06 AM
to Nikolay Vitkov, Benedikt Meurer, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
[cleanup] Fixed found by eslint-plugin-lit

Small issue found by the plugin
Bug: 457654458
Change-Id: I213d71ae2a38bd873d349a2a9c292e998027c87e
Auto-Submit: Nikolay Vitkov <nvi...@chromium.org>
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Commit-Queue: Benedikt Meurer <bme...@chromium.org>
Reviewed-by: Benedikt Meurer <bme...@chromium.org>
Files:
  • M front_end/panels/ai_assistance/PatchWidget.ts
  • M front_end/panels/ai_assistance/components/ChatView.ts
  • M front_end/panels/common/AiCodeCompletionDisclaimer.ts
  • M front_end/panels/common/AiCodeCompletionSummaryToolbar.ts
  • M front_end/panels/explain/components/ConsoleInsight.ts
  • M front_end/panels/protocol_monitor/JSONEditor.ts
  • M front_end/panels/settings/components/SyncSection.ts
  • M front_end/panels/sources/BreakpointsView.ts
  • M front_end/panels/timeline/components/FieldSettingsDialog.ts
  • M front_end/ui/components/expandable_list/ExpandableList.ts
  • M front_end/ui/components/tooltips/Tooltip.test.ts
  • M front_end/ui/legacy/components/data_grid/DataGridElement.test.ts
Change size: M
Delta: 12 files changed, 53 insertions(+), 43 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Benedikt Meurer
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I213d71ae2a38bd873d349a2a9c292e998027c87e
Gerrit-Change-Number: 7120618
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages