Devtools license presubmit check

[Patrick Meenan]

I have an in-flight CL that is failing presubmit for a license check but it looks like it it flagging an auto-generated file:


** Presubmit ERRORS: 1 **
License must match:
(?:.+ )?Copyright (\(c\) )?(2025|2024|2023|2022|2021|2020|2019|2018|2017|2016|2015|2014|2013|2012|2011|2010|2009|2008|2007|2006|2006-2008|2006-2009|2006-2010) The Chromium Authors(\. All rights reserved\.)?\n(?:.+ )?Use of this source code is governed by a BSD-style license that can be\n(?:.+ )?found in the LICENSE file\.(?: \*/)?\n
Found a bad license header in these files:
  node_modules/devtools-protocol/types/protocol.d.ts

Is there something I should be doing or is there an issue with the presubmit check and I'm just the first one to touch that file since it was added?

Thanks,

-Pat

[Mathias Bynens]

Looks like the presubmit checks were changed from warnings to errors here: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6852108

As a workaround, you can add "Bypass-Check-License: <reason>" to the CL footer for now.

We could change the presubmit check to ignore this file, but IMHO it’d be better to alter the script that generates the devtools-protocol npm package so that it outputs a proper license header. The source is here: https://github.com/ChromeDevTools/devtools-protocol

--
You received this message because you are subscribed to the Google Groups "devtools-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to devtools-dev...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/devtools-dev/CAPq58w5obeR6H1_G7YPLQKeLV8M6S%2BYEqMsBNgdXZ1N%2BnJkh%3Dw%40mail.gmail.com.

[Benedikt Meurer]

The license check shouldn't run on 3rd party code. I have https://crrev.com/c/6954329 in flight which should fix it.

cheers,

Benedikt

To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/devtools-dev/CADizRgZnOgtwQAOqDkU9mve3g_RCGCNsjZ%3DYuPUsBZVTQUgTjA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "devtools-googlers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to devtools-googl...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/devtools-googlers/CADizRgZnOgtwQAOqDkU9mve3g_RCGCNsjZ%3DYuPUsBZVTQUgTjA%40mail.gmail.com.
For more options, visit https://groups.google.com/a/chromium.org/d/optout.

--

Benedikt Meurer

Chromium Tooling TL

bme...@chromium.org

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls Sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. 

     

This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.

[Mathias Bynens]

Closing the loop here: this thread resulted in several improvements, each of which would have avoided the issue:

• License headers are added to the generated code in the `devtools-protocol` package: https://github.com/ChromeDevTools/devtools-protocol/pull/334
• The license check no longer runs on third-party code, thanks to Benedikt: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6954329
• Nikolay spotted the bigger issue of the initial CL treating node_modules code as dependencies rather than devDependencies: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6935311/comments/4eb9853a_abee20f5 This was then addressed in the patch.

Nice work everyone!