Process for adding and deleting net error codes with audits?

3 views
Skip to first unread message

Patrick Meenan

unread,
Apr 7, 2026, 5:15:03 AM (7 days ago) Apr 7
to devtools-dev
I'm working on a change to how compression dictionaries work with no-cors requests which will involve deleting one error and creating two new errors in the SharedDictionaryError enum and I'm not exactly sure of the order of changes I should make between the chrome side and dev tools side.

Do I do all of the work on the Chrome side first and then land the changes on the dev tools side after it is merged?

If so, do I map the new, unmapped error codes to something generic or just not map them or does the devtools side handle protocol errors that don't have audits yet?

I'm also a bit thrown off by some of the paths on the dev tools side and I'm not sure if they are auto-generated by the build, if I should generate them by running a tool manually as part of my cl or if they come from the chrome side automatically. Specifically the frontend/generated/* files and third_party/blink/public/devtools_protocol/* files.

If it helps, here is the revert of my first, failed attempt (sorry about that).

Thanks,

-Pat

Alex Rudenko

unread,
Apr 9, 2026, 5:57:00 AM (5 days ago) Apr 9
to devtools-dev, Patrick Meenan
Hi Patrick,

The recommended way to do it is to make the change on the Chrome side first.
We have a gardener rotation to address incoming Chrome rolls and fix breaking changes. CLs created by the auto-roller look like this https://crrev.com/c/7722903
If you are also working on updating the DevTools' side of the change, it might be a good idea to ping the current week's gardener (oncall/chrome-devtools-waterfall-gardener-emea)
and add the changes on top of the roll CL.

I believe both frontend/generated/* files and third_party/blink/public/devtools_protocol/* are auto-generated. The third_party/blink/public/devtools_protocol is copied from Chromium and frontend/generated is generated based on the copied changes.

Best regards,
Alex




Reply all
Reply to author
Forward
0 new messages