Contributing devtools changes as part of Chrome CL

[Patrick Meenan]

This is my first time working on something that also touches devtools (adds new error codes to some of the network events).

Is the chromium checkout method the best way to submit the combined set of changes?

The docs are a bit thin on the "git cl" and "gclient sync" side of things when doing that.

Would I create two separate CL's, one for the main chromium repo and one for the third_party/devtools-frontend/src changes?

Should I avoid running "gclient sync" if I have changes in-flight? If so, does that cause problems if I need to rebase the chrome-side of changes?

Thanks,

-Pat

[Benedikt Meurer]

Hey Patrick,

In your case, where you're working on combined frontend and backend changes, it makes sense to use the chromium checkout method. I'm going to improve the documentation for that.

Generally speaking, you'd need to create a branch in the git repository for chromium (in src), and a branch in the git repository for devtools-frontend (in src/third_party/devtools-frontend/src). Prior to running `gclient sync`, you need to switch src back to main (as usual), and checkout the DEPS'ed revision in third_party/devtools-frontend/src. (there might be an easier way to do this, I'll have a look now when updating the documentation).

HTH,

Benedikt

--
You received this message because you are subscribed to the Google Groups "devtools-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to devtools-dev...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/devtools-dev/CAPq58w4ah_SQi6ER%2BHw74so-G2uUuYRp6-tbj35S9oEhknXHJg%40mail.gmail.com.

--

Benedikt Meurer

Chromium Tooling TL

bme...@chromium.org

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls Sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. 

     

This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.