Feedback requested on proceeding with a change to the CORS URL loader

[Jayson Adams]

Hello,

While investigating ways to increase our Speedometer 3 score, I discovered the CORS URL loader clones a devtools connection on every resource request. As you may know, a resource request includes an optional devtools request id. The code in the CORS URL loader wasn't checking the optional before deciding to clone the connection.

Cloning only if requested increases our SP3 score slightly, so that's a win. However, there were some tests that depended on this connection being present. I landed a cl (https://crrev.com/c/5404918) to make this change and adjust the tests, but out of caution, the change is gated behind a flag. Adam Rice suggested I contact this group to see if there are any concerns or potential issues you all see with moving forward.

Best,

__jayson

[Benedikt Meurer]

Hey Jayson,

Thanks for reaching out. @Danil Somsikov and @Alex Rudenko are probably the right people to talk to about this.

cheers,

Benedikt

--
You received this message because you are subscribed to the Google Groups "devtools-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to devtools-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/devtools-dev/CA%2B4SKEJ0JkToPqo3R%3DQhx6h%2BvpcRQ7t4MybXwxW%2BFiirT_%2BtrA%40mail.gmail.com.

--

Benedikt Meurer

Chromium DevTools Manager

bme...@chromium.org

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls Sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. 

     

This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.

[Alex Rudenko]

thanks for reaching out! I see that both dsv@ and caseq@ have approved the change and it looks good to me too.

I also ran Puppeteer test suite with the feature enabled and it didn't cause any test failures.
I think it should be safe to try to enable this behavior by default and eventually remove the flag.

Best regards,

Alex

[Jayson Adams]

Great - thank you!