Updating DevTools build output for debugging DevTools

[Tim Van der Lippe]

Hey everyone,

As part of cleaning up the build system, we are removing numerous copies of the same files in the DevTools build output: crbug.com/1174013 This means that we will treat out/Default/gen/front_end as the sole source of truth and we will remove all other copies (which are out/Default/resources/inspector and out/Default/gen/devtools).

We will be removing the build output of resources/inspector next week. Therefore, you should update any command that relies on resources/inspector and update it to use gen/front_end instead. For example, as documented in our workflows.md, the --custom-devtools-frontend location will need to be updated. The new command will look like this:

<path-to-chrome>/chrome --custom-devtools-frontend=file://$(realpath out/Default/gen/front_end)

Please let us know if you run into any issues.

Cheers,

LON

[Tim Van der Lippe]

Hey everyone,

We are planning to start the removal of out/Default/resources/inspector on Wednesday February 10th 2021. Please make sure your commands/scripts are updated prior to that day, to avoid working with stale build artifacts. When the removal is starting, I will send out another reminder to suggest the removal of out/Default/resources/inspector to avoid accidental usages of the stale build output in the folder.

Please let us know if you run into any issues.

Cheers,

LON

[Rob Paveza]

Hi Tim,

 

Thanks for the update there. My recollection was that Blink web tests run with scripts (specifically the _test_runner scripts) from the resources/inspector path.

 

I see that chromium.src/third_party/blink/tools/blinkpy/web_tests/port/base.py still defines inspector_build_directory as pointing to out/Default/resources/inspector. As you note, it’s intended to debug web tests.

 

Can you respond back to this thread when you have the CL with the corresponding updates to the Python scripts?

 

Thanks,

Rob

--
You received this message because you are subscribed to the Google Groups "devtools-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to devtools-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/devtools-dev/CAKCakL5ZUW8Hts_-5A4AvMcGep0nLhBApMb9cHwDeAdC-CpFmw%40mail.gmail.com.

[Tim Van der Lippe]

Hello Rob,

Thanks for finding that usage. Yes we will clean these up as part of the process. To make things easier for everyone, I will make sure to update such scripts tomorrow (Tuesday) so that we can safely land the removal on Wednesday.

Thanks,

Tim

[Tim Van der Lippe]

Small update: we have hit some issues with non-determinism in the build system, which is blocking the removal of resources/inspector. As soon as these issues are resolved, the folder will be removed.

[Patrick Brosset]

Hello Tim and team,

 

Would you be able to share a quick status on this migration? Last I heard from you was that some issue had been hit, and I was wondering if progress had been made to resolve this.

 

Thanks a lot!

Patrick

 

De : Tim Van der Lippe <tvande...@chromium.org>
Envoyé : Thursday, February 11, 2021 1:00 PM
À : devtoo...@chromium.org
Objet : Re: [EXTERNAL] [devtools-dev] Re: Updating DevTools build output for debugging DevTools

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/devtools-dev/CAKCakL6e19_uZR5d4Qs-T5QGP7MSX9Rb%2Bo%3D9mHnNau0OMUmRkw%40mail.gmail.com.

[Tim Van der Lippe]

Hey Patrick,

Thanks for reaching out! At this point, you should be using `gen/front_end` as your source-of-truth, so any CLs that are landing should be noops for your debugging workflow. Let me know if that is not the case.

Sadly, we hit some issues upstream (e.g. breaking all DevTools layout tests in a race-condition between a sheriff revert and a DevTools roll crbug.com/1180967) and therefore we are waiting for branchpoint prior to relanding. The reland (https://chromium-review.googlesource.com/c/chromium/src/+/2714599) will be submitted on Monday. Then I will wait 2 days to remove the `resources/inspector` copy (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2721954). I will notify you when that CL is submitted and not reverted.

Cheers,

Tim

[Tim Van der Lippe]

https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2721954 has been submitted and the output in `resources/inspector` will no longer be usable to launch DevTools. To prevent accidental usage of stale build artifacts in this folder, we recommend pulling the commit and `rm rf out/Default/resources/inspector`.

Let us know if you are running into any issues.