Issue 1093848 in chromium: inspector-protocol/input/dispatchTouchEvent.js is flaky

22 views
Skip to first unread message

smcgruer via monorail

unread,
Jun 11, 2020, 11:25:09 AM6/11/20
to devtoo...@chromium.org
Status: Untriaged
Owner: ----
CC: devtoo...@chromium.org
Labels: Test-Flaky
Components: Platform>DevTools
OS: Chrome
Pri: 1
Type: Bug

New issue 1093848 by smcg...@chromium.org: inspector-protocol/input/dispatchTouchEvent.js is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1093848

Split from issue 1090455, where Findit filed multiple unrelated bugs.


Findit reports inspector-protocol/input/dispatchTouchEvent.js as flaky:

https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUgsSBUZsYWtlIkdjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAaW5zcGVjdG9yLXByb3RvY29sL2lucHV0L2Rpc3BhdGNoVG91Y2hFdmVudC5qcww

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

mathias via monorail

unread,
Jun 12, 2020, 2:50:30 AM6/12/20
to devtoo...@chromium.org
Updates:
Cc: sig...@chromium.org
Owner: jansch...@chromium.org
Status: Available

Comment #1 on issue 1093848 by mat...@chromium.org: inspector-protocol/input/dispatchTouchEvent.js is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1093848#c1

Jan, could you PTAL?

sheriffbot via monorail

unread,
Jun 14, 2021, 11:56:05 AM6/14/21
to devtoo...@chromium.org
Updates:
Labels: Hotlist-Recharge-Cold
Status: Untriaged

Comment #2 on issue 1093848 by sheriffbot: inspector-protocol/input/dispatchTouchEvent.js is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1093848#c2

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

mathias via monorail

unread,
Jun 15, 2021, 4:53:25 AM6/15/21
to devtoo...@chromium.org
Updates:
Status: Assigned

Comment #3 on issue 1093848 by mat...@chromium.org: inspector-protocol/input/dispatchTouchEvent.js is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1093848#c3

Jan, PTAL and re-enable this test as soon as possible :) Thanks!

Git Watcher via monorail

unread,
Jul 5, 2021, 3:54:08 AM7/5/21
to devtoo...@chromium.org
Updates:
Status: Fixed

Comment #4 on issue 1093848 by Git Watcher: inspector-protocol/input/dispatchTouchEvent.js is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1093848#c4

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/b5f6cc4bbca5f958c9f04a6f91e6ab5f4621a66b

commit b5f6cc4bbca5f958c9f04a6f91e6ab5f4621a66b
Author: Jan Scheffler <jansch...@chromium.org>
Date: Mon Jul 05 07:53:15 2021

Fixing flake by preventing race condition

Fixed: chromium:1093848
Change-Id: I5d39aeecd509c1fe6836ca38181424f693e71cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3000974
Reviewed-by: Mathias Bynens <mat...@chromium.org>
Commit-Queue: Jan Scheffler <jansch...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898544}

[modify] https://crrev.com/b5f6cc4bbca5f958c9f04a6f91e6ab5f4621a66b/third_party/blink/web_tests/inspector-protocol/input/dispatchTouchEvent-expected.txt
[modify] https://crrev.com/b5f6cc4bbca5f958c9f04a6f91e6ab5f4621a66b/third_party/blink/web_tests/inspector-protocol/input/dispatchTouchEvent.js
Reply all
Reply to author
Forward
0 new messages