Type-safe event listeners

4 views
Skip to first unread message

Simon Zünd

unread,
Jul 13, 2021, 5:44:52 AM7/13/21
to devtools-...@chromium.org
Hi all,

I recently played around with augmenting the `EventTarget` interface to become type-safe in a backwards compatible way. I documented the approach by extending Sigurds Design Doc: https://docs.google.com/document/d/1UEpqxukpE_W5tj4gACJxeiQ1Z_1Y_LRUKScsml8z8e4/edit?usp=sharing

Cheers, Simon

Simon Zünd

unread,
Sep 22, 2021, 7:34:06 AM9/22/21
to devtools-...@chromium.org
The migration to a type-safe event infrastructure is now completed, with the last CL currently in-flight. A huge thanks to everyone who contributed to this effort! In the end we clocked around 160 non-roll CLs on the bug, removed countless of 'as' casts that are no longer necessary and fixed a few bugs found by the compiler via the better types. Thanks again!

Yang Guo

unread,
Sep 22, 2021, 7:38:37 AM9/22/21
to Simon Zünd, devtools-...@chromium.org
That's an awesome achievement. Thanks a lot for contributing to make this possible!

Cheers,

Yang

--
You received this message because you are subscribed to the Google Groups "devtools-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to devtools-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/devtools-dev/CACswSC203LwVxJ0HyC97bsAFy_knD28jNKtgh-bL4Vb1y0g0-w%40mail.gmail.com.

Benedikt Meurer

unread,
Sep 22, 2021, 11:50:20 AM9/22/21
to Yang Guo, Simon Zünd, devtools-...@chromium.org
Yay, thanks a lot Simon, Sigurd, and Kateryna! You really did an outstanding job driving this forward and pushing it through.

cheers,
Benedikt



--

Benedikt Meurer

Chromium DevTools TL

bme...@chromium.org


Google Germany GmbH

Erika-Mann-Straße 33

80636 München


Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg


Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.

    

This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.

Reply all
Reply to author
Forward
0 new messages