Requesting Guidance on Using absl::StatusOr in Chromium

[Tsuyoshi Horo]

Dear cxx@ folks,

I'm working on some integration work of the third-party library "liburlpattern" into Chromium. The library's liburlpattern::Parse() method requires a function returning an absl::StatusOr type. To facilitate this, I've added a specific_include_rules entry to the components/url_pattern/DEPS file to include the necessary Abseil header ("third_party/abseil-cpp/absl/status/statusor.h") in this CL.

However, an OWNER of third_party/abseil-cpp/OWNERS has requested me to seek approval from the cxx group before proceeding. Could you please advise on the following:
 - Is using absl::StatusOr for this integration an acceptable practice within Chromium?
 - If so, are there any specific guidelines or recommendations I should be aware of?

Thanks.

[Peter Kasting]

In general, you can use disallowed types like this at the boundaries of third party code where necessary to integrate. You should use the disallowed type minimally (within reason), translating to an equivalent allowed type for any nontrivial chrome-side use. In this case, that would probably be base::expected<>.

PK

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CADk0S-Wwcbi18LM%2BsvsEDeAnq1ExqDGHQerVZeeAfWka9Kr4vA%40mail.gmail.com.

[Jeremy Roman]

+1. In addition, I think we discussed the particular case of liburlpattern (though if it was on this list, I can't immediately find it). This code is kinda weird in that it's pseudo-third-party, but we made a decision at the time to treat it like third-party code in this respect and not allow a dependency on base/ if we could help it.

I believe the relevant CL does translate immediately, as does the existing calling code.

[Alex Cooper]

> In general, you can use disallowed types like this at the boundaries of third party code where necessary to integrate. You should use the disallowed type minimally (within reason), translating to an equivalent allowed type for any nontrivial chrome-side use. 

I thought there was an explicit line in the chromium style guide or one of the adjacent docs that stated this, but I cannot find it now.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAAHOzFByFaE1dSVzz886CuTcVsXS0LHMxOAq%2BS%3DkYjMiUx87EA%40mail.gmail.com.

[Tsuyoshi Horo]

Thank you very much for answering my questions.

[Joe Mason]

I just put up a styleguide CL with this advice at https://crrev.com/c/5251128

On Tue, Jan 30, 2024 at 12:10 PM Alex Cooper <alco...@chromium.org> wrote:

> In general, you can use disallowed types like this at the boundaries of third party code where necessary to integrate. You should use the disallowed type minimally (within reason), translating to an equivalent allowed type for any nontrivial chrome-side use. 

I thought there was an explicit line in the chromium style guide or one of the adjacent docs that stated this, but I cannot find it now.

On Tue, Jan 30, 2024 at 8:00 AM 'Peter Kasting' via cxx <c...@chromium.org> wrote:

In general, you can use disallowed types like this at the boundaries of third party code where necessary to integrate. You should use the disallowed type minimally (within reason), translating to an equivalent allowed type for any nontrivial chrome-side use. In this case, that would probably be base::expected<>.

PK

On Tue, Jan 30, 2024, 7:48 AM Tsuyoshi Horo <ho...@chromium.org> wrote:

Dear cxx@ folks,

I'm working on some integration work of the third-party library "liburlpattern" into Chromium. The library's liburlpattern::Parse() method requires a function returning an absl::StatusOr type. To facilitate this, I've added a specific_include_rules entry to the components/url_pattern/DEPS file to include the necessary Abseil header ("third_party/abseil-cpp/absl/status/statusor.h") in this CL.

However, an OWNER of third_party/abseil-cpp/OWNERS has requested me to seek approval from the cxx group before proceeding. Could you please advise on the following:
 - Is using absl::StatusOr for this integration an acceptable practice within Chromium?
 - If so, are there any specific guidelines or recommendations I should be aware of?

Thanks.

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CADk0S-Wwcbi18LM%2BsvsEDeAnq1ExqDGHQerVZeeAfWka9Kr4vA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAAHOzFByFaE1dSVzz886CuTcVsXS0LHMxOAq%2BS%3DkYjMiUx87EA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAGOLbz2zF5FrxC50532Ld6H3ZRoUm%3DF-HjP%2BbgL9%2B%2B1EgYwVQA%40mail.gmail.com.