gmock and C++11

[Avi Drissman]

I'm working on moving autofill to use containers with owned pointers, but autofill heavily uses gmock, which seems to be rather unhappy about mocking out methods that have move-only types as parameters.

https://github.com/google/googlemock/blob/master/googlemock/docs/DesignDoc.md talks about the far-off world of C++0x, and there's an open issue https://github.com/google/googletest/issues/395 about exactly this.

Is there a new gmock we can bring in? The right way to proceed isn't obvious here to me.

Avi

[Avi Drissman]

OK, I may have found a way around the issue by using lambdas and captured references, which is too clever for my own good but might actually work... :(

[Daniel Cheng]

The usual idiom I see in Chromium code is to define a forwarding method which delegates to Gmock [1][2]:

class MockFoo : public Foo {

 public:

  void Method(std::unique_ptr<Bar>);

  MOCK_METHOD1(Method, Bar*);
};

Daniel

[1] https://cs.chromium.org/chromium/src/services/video_capture/mock_device_descriptor_receiver.h?rcl=0&l=18

[2] https://cs.chromium.org/chromium/src/chrome/browser/password_manager/password_store_x_unittest.cc?rcl=0&l=51

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To post to this group, send email to c...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CACWgwAYyPDXHPzkbbjkWCZ0fW-b43OfQQweU1E%3DpsLXP%3DdnW6g%40mail.gmail.com.

[dan...@chromium.org]

On Sun, Oct 9, 2016 at 8:40 PM, Daniel Cheng <dch...@chromium.org> wrote:

The usual idiom I see in Chromium code is to define a forwarding method which delegates to Gmock [1][2]:

class MockFoo : public Foo {

 public:

  void Method(std::unique_ptr<Bar>);

  MOCK_METHOD1(Method, Bar*);
};

Daniel

[1] https://cs.chromium.org/chromium/src/services/video_capture/mock_device_descriptor_receiver.h?rcl=0&l=18

[2] https://cs.chromium.org/chromium/src/chrome/browser/password_manager/password_store_x_unittest.cc?rcl=0&l=51

+1. More example: https://cs.chromium.org/chromium/src/cc/output/gl_renderer_unittest.cc?rcl=0&l=1487

Also, this has happened at one point: https://codereview.chromium.org/2174663002 for https://bugs.chromium.org/p/chromium/issues/detail?id=630299

But I think maybe gmock hasn't been rolled since that or something.. I'm not entirely sure where we're at.

 

On Sun, Oct 9, 2016 at 8:31 PM 'Avi Drissman' via cxx <c...@chromium.org> wrote:

OK, I may have found a way around the issue by using lambdas and captured references, which is too clever for my own good but might actually work... :(

On Sun, Oct 9, 2016 at 10:53 PM, Avi Drissman <a...@google.com> wrote:

I'm working on moving autofill to use containers with owned pointers, but autofill heavily uses gmock, which seems to be rather unhappy about mocking out methods that have move-only types as parameters.

https://github.com/google/googlemock/blob/master/googlemock/docs/DesignDoc.md talks about the far-off world of C++0x, and there's an open issue https://github.com/google/googletest/issues/395 about exactly this.

Is there a new gmock we can bring in? The right way to proceed isn't obvious here to me.

Avi

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To post to this group, send email to c...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CACWgwAYyPDXHPzkbbjkWCZ0fW-b43OfQQweU1E%3DpsLXP%3DdnW6g%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To post to this group, send email to c...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAF3XrKrxKkmGsx5feW8Ydr4H7gtvM-XoLYNvxg9cwXbTWRbN9Q%40mail.gmail.com.

[Xiaohan Wang (王消寒)]

I am also hitting this issue, for mock methods involving base::OnceCallback. Given we'll use base::OnceCallback more and more, it seems to me we should fix this gmock limitation instead of encouraging people to use the workaround.

There's actually a proposed patch in the github issue, and it seems to be working for somebody else. What's the proper way to get this fixed in gmock and roll gmock in chromium?

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAHtyhaTQoRwaeDcPR7qE_oAWPnTcT9vze3m%2B%3D0UK353Af6Ee7A%40mail.gmail.com.

[Xiaohan Wang (王消寒)]

+tzik