style reformatting: from "value /*arg*/" to "/*arg=*/value"

[Hiroshige Hayashizaki]

Hi cxx@,

I'm considering replacing "value /* arg */" style with "/*arg=*/value" (primarily to flush my backlog), and would like to have a guidance for how to proceed, given the large size of total changes (expecting ~3000 files if fully applied).

Design doc:

https://docs.google.com/document/d/1u4OI52VQtqjjDae6AAPfJADqT8UZkazqE44DYjF31kA/edit?usp=sharing

Particular questions are (see "Process" section at the bottom of the design doc):

- Should I go through the ordinal LSC process, or something else as a C++ Style Change?

- Or should we make this change in the first place?

Thanks!

[Takuto Ikuta (生田 拓人)]

Hi,

+1 for consistent style and following the Google style guide.

Repeating comment on your doc.

I think your proposal is cosmetic changes in https://chromium.googlesource.com/chromium/src/+/main/docs/process/lsc/large_scale_changes.md#what-is-it-not-good-for and fine to rely on OO+1 from global approvers if we get consensus in this thread.

Thanks.

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAOaYce7yJKZry8Uf0SgXMyk3m%3DZWdsKaKaQY8z__%3DVMHgn4kXw%40mail.gmail.com.

--

Takuto Ikuta

Software Engineer in Tokyo

Chrome Ops (chrome browser build team)