Proposing google-upgrade-googletest-case

[Julie Jeongeun Kim]

Hello folks,

I propose enabling the google-upgrade-googletest-case clang-tidy lint. A survey of existing instances is at here.

This is not related to code logic, but it helps to prevent additional deprecated test case APIs in chromium code.

Feedback appreciated! If there are no objections, I'll enable this in early January 2024.

Thanks,
Julie

[Peter Kasting]

+1 for automated tools to prevent backsliding on a conversion we've basically finished.

PK

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/9f6a5c26-6a3f-40fe-a38a-69073cae904an%40chromium.org.

[Peter Boström]

Since these are wrapped in #ifndef GTEST_REMOVE_LEGACY_TEST_CASEAPI_ would we also consider defining this so that we stop backsliding? If we could do so I'm assuming that the migration is fairly mechanical for the few remaining violations.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAAHOzFDxniNQE3CZM%3DOBMgBS6%3DyuYKm6Zc%3D_1fsda1L6u-SzaQ%40mail.gmail.com.

[Peter Kasting]

On Tue, Dec 19, 2023 at 9:46 AM Peter Boström <pb...@chromium.org> wrote:

Since these are wrapped in #ifndef GTEST_REMOVE_LEGACY_TEST_CASEAPI_ would we also consider defining this so that we stop backsliding? If we could do so I'm assuming that the migration is fairly mechanical for the few remaining violations.

Ah, if we can define something that makes this a compile error, that's even better than a clang-tidy pass.

PK 

[Julie Jeongeun Kim]

It seems that the issue, https://crbug.com/1474588, includes enabling GTEST_REMOVE_LEGACY_TEST_CASEAPI_.

If it's enough, I'll skip this check in Tricium.

Thanks,

[Peter Kasting]

On Wed, Jan 10, 2024 at 5:48 AM Julie Jeongeun Kim <jk...@igalia.com> wrote:

It seems that the issue, https://crbug.com/1474588, includes enabling GTEST_REMOVE_LEGACY_TEST_CASEAPI_.

If it's enough, I'll skip this check in Tricium.

That bug seems unowned. If we were likely going to complete it soon, I'd say this is unnecessary; but I don't know that we can say that.

Tentatively, I'd say we should either enable this check (and post on the bug that it can be removed when that conversion is finished) or else actively try to finish the conversion immediately.

PK

[Julie Jeongeun Kim]

Thanks for the suggestion. It sounds great. I prefer enabling this check and post on the bug.

If there is no objection, I'll work on it.

Julie