Switching from base::as_const to std::as_const

31 views
Skip to first unread message

Lei Zhang

unread,
Sep 27, 2022, 4:47:55 PM9/27/22
to cxx
Hi,

Does anyone have thoughts or concerns about switching from
base::as_const to std::as_const? https://crrev.com/719032 added it 2
years before C++17 became available.

dan...@chromium.org

unread,
Sep 27, 2022, 5:05:17 PM9/27/22
to Lei Zhang, cxx
As usual with the stdlib, the concern is header sizes :/

But anyhow switching lgtm, we don't have any intent to mirror stdlib at this time :)
 

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CACSHbcRqwt3qffu7L6JPsDdp%3DA6DsrVkLQ4T%2BtwAwStX%3DU%2BEgQ%40mail.gmail.com.

Lei Zhang

unread,
Sep 27, 2022, 5:21:31 PM9/27/22
to dan...@chromium.org, cxx
We should be ok on header sizes.
- Most of the base::as_const usage is in .cc files.
- The headers that use base::as_const already include <utility>.

Jan Wilken Dörrie

unread,
Sep 28, 2022, 3:25:57 AM9/28/22
to Lei Zhang, dan...@chromium.org, cxx
LGTM

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CACSHbcQCNctxeVnCFj9kjkNqkuhhdTpJ6vR9HqKLzAC-yKE9xA%40mail.gmail.com.

Anton Bikineev

unread,
Sep 28, 2022, 5:30:29 AM9/28/22
to Jan Wilken Dörrie, Lei Zhang, dan...@chromium.org, cxx
+1 for switching to the standard lib.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CALB5StbLo-HjuaDryw6f4t9R50fMMUhe3xZSXN3snvd0Roceew%40mail.gmail.com.

Lei Zhang

unread,
Oct 6, 2022, 7:17:15 PM10/6/22
to Anton Bikineev, Jan Wilken Dörrie, dan...@chromium.org, cxx
Done in https://crrev.com/1056054
Reply all
Reply to author
Forward
0 new messages