Proposal: Ban std::aligned_{storage,union}

[Peter Kasting]

I propose we ban std::aligned_storage and std::aligned_union.

These are part of C++11, but are deprecated in C++23 (i.e. will cause warnings, and thus errors, when we try to switch to C++23). I've removed all first-party use from the Chromium repo already and will be working on removing them from dependencies.

There's no real need for them (`alignas(T) char buf[sizeof(T)]` generally serves) and they are broken in a few ways, so I can't see this hurting anything.

PK

[Elly]

+1 :)

-- elly

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAAHOzFCQvOy_937vqs9ZRtngipOWL6Hv3m6ESH7YyEg-HLrh5Q%40mail.gmail.com.

[Alex Cooper]

+1

To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CADpj5oycbLSMp%3DxUwVUYEVuG_f_QqnMeh0PDTXaHqCkU8t_3rw%40mail.gmail.com.

[Peter Boström]

+1, getting onto C++23 at some point seems useful.

To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAGOLbz31rUPzCz-qq0ctDEXAhgGP9cot2wBUxHbB1fT2EvEjJg%40mail.gmail.com.

[Anton Bikineev]

+1, but perhaps we need a guideline to use aligned std::byte or (u)char instead.

To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAGFX3sHNoODbzAFRxnjhBng%2B_L81DbNfctOtQ5tUuPhWZZZF0g%40mail.gmail.com.

[Peter Kasting]

We ban std::byte, so char is the appropriate type. In the ban wording, I can direct people to this. 

PK

[Peter Kasting]

This seems unanimously supported, so I consider it approved.

PK