Groups
Sign in
Groups
cxx
Conversations
About
Send feedback
Help
cxx
1–30 of 517
Mark all as read
Report group
0 selected
Punith Nayak
, …
Alexei Svitkine
38
12:24 PM
Proposal for Adoption of C++20 [[likely]] and [[unlikely]] Attributes in Chromium Codebase
For this example: do { body(); } while (UNLIKELY(cond)); It seems unfortunate that the macro and/or
unread,
Proposal for Adoption of C++20 [[likely]] and [[unlikely]] Attributes in Chromium Codebase
For this example: do { body(); } while (UNLIKELY(cond)); It seems unfortunate that the macro and/or
12:24 PM
Devon Loehr
, …
Avi Drissman
6
Jul 11
Cleaning up implicit `this` captures
It seems to me that you are understating things. It's not just that the behavior is unintuitive (
unread,
Cleaning up implicit `this` captures
It seems to me that you are understating things. It's not just that the behavior is unintuitive (
Jul 11
Anton Bikineev
, …
Peter Kasting
8
Jul 3
Proposal: Allow std::hardware_(destructive|constructive)_interference_size
On Monday, June 10, 2024 at 5:09:30 PM UTC-7 Peter Kasting wrote: Update: The version of clang in
unread,
Proposal: Allow std::hardware_(destructive|constructive)_interference_size
On Monday, June 10, 2024 at 5:09:30 PM UTC-7 Peter Kasting wrote: Update: The version of clang in
Jul 3
Keren Zhu
, …
Sam Clegg
12
Jul 3
Linker bug? Conflicting class name is permitted
Sam, you hit the spot. Thank you for pointing that out! It makes sense to ignore duplicate weak
unread,
Linker bug? Conflicting class name is permitted
Sam, you hit the spot. Thank you for pointing that out! It makes sense to ignore duplicate weak
Jul 3
Dana Jansens
, …
Daniel Cheng
34
Jun 30
ranges algorithms
I've sent out https://chromium-review.googlesource.com/c/chromium/src/+/5668999/ to update the
unread,
ranges algorithms
I've sent out https://chromium-review.googlesource.com/c/chromium/src/+/5668999/ to update the
Jun 30
Peter Boström
, …
Alison Gale
20
Jun 26
New TODO format?
I'm reverting my update to consolidate the TODO style in: https://chromium-review.googlesource.
unread,
New TODO format?
I'm reverting my update to consolidate the TODO style in: https://chromium-review.googlesource.
Jun 26
Peter Boström
, …
Peter Kasting
72
Jun 25
Reconsidering our optional-brace policy
I feel like every time this gets brought up there's a camp of "yay of course we should do
unread,
Reconsidering our optional-brace policy
I feel like every time this gets brought up there's a camp of "yay of course we should do
Jun 25
John Admanski
, …
Peter Kasting
12
Jun 10
Allowing the use of Abseil hash maps
On Mon, Apr 29, 2024 at 12:26 PM Daniel Cheng <dch...@chromium.org> wrote: Fair point. I'll
unread,
Allowing the use of Abseil hash maps
On Mon, Apr 29, 2024 at 12:26 PM Daniel Cheng <dch...@chromium.org> wrote: Fair point. I'll
Jun 10
Erik Chen
, …
Peter Kasting
42
Jun 7
cxx: Allow namespaces in //chrome/browser.
On Tuesday, May 28, 2024 at 8:40:45 AM UTC-7 Peter Kasting wrote: sounds like the right path forward
unread,
cxx: Allow namespaces in //chrome/browser.
On Tuesday, May 28, 2024 at 8:40:45 AM UTC-7 Peter Kasting wrote: sounds like the right path forward
Jun 7
Florian Leimgruber
,
David Benjamin
3
May 30
absl::variant and narrowing conversions
Awesome, thanks for confirming and providing all this context! On Wed, May 29, 2024 at 4:36 PM David
unread,
absl::variant and narrowing conversions
Awesome, thanks for confirming and providing all this context! On Wed, May 29, 2024 at 4:36 PM David
May 30
Daniel Cheng
, …
Peter Kasting
9
May 28
GCC warnings for memcpy
On Monday, April 29, 2024 at 11:21:16 AM UTC-7 John Admanski wrote: On Mon, Apr 29, 2024 at 11:00 AM
unread,
GCC warnings for memcpy
On Monday, April 29, 2024 at 11:21:16 AM UTC-7 John Admanski wrote: On Mon, Apr 29, 2024 at 11:00 AM
May 28
Takuto Ikuta
, …
Jean-Philippe Gravel
9
May 8
Proposing misc-include-cleaner check
I made https://crrev.com/c/5514394 for the instructions. On Wed, May 1, 2024 at 7:30 PM Takuto Ikuta
unread,
Proposing misc-include-cleaner check
I made https://crrev.com/c/5514394 for the instructions. On Wed, May 1, 2024 at 7:30 PM Takuto Ikuta
May 8
danakj
, …
Peter Kasting
17
Apr 29
Proposal: allow [[clang::attributes]] in Chromium without macros
On Monday, March 11, 2024 at 6:38:51 PM UTC-7 Peter Kasting wrote: On Tue, Mar 5, 2024 at 11:47 AM
unread,
Proposal: allow [[clang::attributes]] in Chromium without macros
On Monday, March 11, 2024 at 6:38:51 PM UTC-7 Peter Kasting wrote: On Tue, Mar 5, 2024 at 11:47 AM
Apr 29
Peter Kasting
, …
Peter Kasting
10
Apr 29
Proposal: base/ macros that supersede ABSL_ATTRIBUTE_*
On Monday, March 11, 2024 at 6:38:03 PM UTC-7 pkas...@google.com wrote: I propose that, for all
unread,
Proposal: base/ macros that supersede ABSL_ATTRIBUTE_*
On Monday, March 11, 2024 at 6:38:03 PM UTC-7 pkas...@google.com wrote: I propose that, for all
Apr 29
Szilard Szaloki
, …
Ryan Hamilton
6
Apr 13
Finite state machine abstraction
For tooling, see an example attached. Szilard On Wed, Apr 10, 2024 at 1:59 PM Szilard Szaloki <
unread,
Finite state machine abstraction
For tooling, see an example attached. Szilard On Wed, Apr 10, 2024 at 1:59 PM Szilard Szaloki <
Apr 13
James Lee
, …
Peter Kasting
10
Mar 29
Use of [[deprecated]] attribute
We can't really stop third-party deps from doing what they want, if they use [[deprecated]] in
unread,
Use of [[deprecated]] attribute
We can't really stop third-party deps from doing what they want, if they use [[deprecated]] in
Mar 29
Xianzhu Wang
, …
Roland McGrath
6
Mar 28
sizeof(class-inheriting-empty-class) increases by 8 bytes on Windows
If the only purpose of the new class is to do `static_assert`s then you don't need it to be a
unread,
sizeof(class-inheriting-empty-class) increases by 8 bytes on Windows
If the only purpose of the new class is to do `static_assert`s then you don't need it to be a
Mar 28
Matthew Jones
, …
Joe Mason
18
Mar 20
Moving and calling a OnceCallback from a RepeatingCallback
I do like the BarrierCallback idea, so if it's not particularly offensive to anyone on this
unread,
Moving and calling a OnceCallback from a RepeatingCallback
I do like the BarrierCallback idea, so if it's not particularly offensive to anyone on this
Mar 20
Jean-Philippe Gravel
, …
Hardik Goyal
29
Mar 20
IWYU in Chromium
Maybe worth reviving this. I just started making contributions to chromium and thought it could
unread,
IWYU in Chromium
Maybe worth reviving this. I just started making contributions to chromium and thought it could
Mar 20
Lei Zhang
, …
Arthur Sonzogni
40
Mar 12
Switching from base::WrapUnique() to absl::WrapUnique()
FYI: Here is a pending patch from @Takuto Ikuta about using IncludeBlocks: Regroup ( bug 329138753)
unread,
Switching from base::WrapUnique() to absl::WrapUnique()
FYI: Here is a pending patch from @Takuto Ikuta about using IncludeBlocks: Regroup ( bug 329138753)
Mar 12
David Benjamin
, …
Peter Kasting
21
Mar 11
PSA: absl::optional is now std::optional
On Tue, Feb 27, 2024 at 8:00 AM 'Arthur Sonzogni' via cxx <c...@chromium.org> wrote:
unread,
PSA: absl::optional is now std::optional
On Tue, Feb 27, 2024 at 8:00 AM 'Arthur Sonzogni' via cxx <c...@chromium.org> wrote:
Mar 11
Nick Diego Yamane
Feb 26
PSA: std::to_address is now banned
Hey folks, As of crrev.com/c/5313370, std::to_address is now banned in favor of its wrapper base::
unread,
PSA: std::to_address is now banned
Hey folks, As of crrev.com/c/5313370, std::to_address is now banned in favor of its wrapper base::
Feb 26
Harald Alvestrand
, …
David Benjamin
10
Feb 7
Query: Use of std::vector<const something> in Chromium?
Right, but std::vector isn't defined to call memcpy. That's an optimization libc++ does when
unread,
Query: Use of std::vector<const something> in Chromium?
Right, but std::vector isn't defined to call memcpy. That's an optimization libc++ does when
Feb 7
Peter Kasting
, …
Peter Boström
8
Feb 6
Default-allowing C++17
On Wed, Jan 17, 2024 at 12:41 PM Peter Kasting <pkas...@google.com> wrote: Since there have
unread,
Default-allowing C++17
On Wed, Jan 17, 2024 at 12:41 PM Peter Kasting <pkas...@google.com> wrote: Since there have
Feb 6
Tsuyoshi Horo
, …
Joe Mason
6
Jan 30
Requesting Guidance on Using absl::StatusOr in Chromium
I just put up a styleguide CL with this advice at https://crrev.com/c/5251128 On Tue, Jan 30, 2024 at
unread,
Requesting Guidance on Using absl::StatusOr in Chromium
I just put up a styleguide CL with this advice at https://crrev.com/c/5251128 On Tue, Jan 30, 2024 at
Jan 30
Avi Drissman
, …
Adam Rice
43
Jan 30
bit_cast?
If it makes people stop and think about what they are doing, then base::bit_cast is valuable. > I
unread,
bit_cast?
If it makes people stop and think about what they are doing, then base::bit_cast is valuable. > I
Jan 30
Anton Bikineev
, …
Peter Kasting
8
Jan 24
Using [[no_unique_address]] in Blink
On Thursday, October 17, 2019 at 12:27:11 PM UTC-7 Karl Wiberg wrote: On Thu, Oct 17, 2019 at 8:54 PM
unread,
Using [[no_unique_address]] in Blink
On Thursday, October 17, 2019 at 12:27:11 PM UTC-7 Karl Wiberg wrote: On Thu, Oct 17, 2019 at 8:54 PM
Jan 24
Jason Lin
, …
Dana Jansens
9
Jan 22
-Wrange-loop-bind-reference and looping through a Value::Dict
https://quuxplusone.github.io/blog/2020/08/26/wrange-loop-analysis/ agrees the warning is wrong. On
unread,
-Wrange-loop-bind-reference and looping through a Value::Dict
https://quuxplusone.github.io/blog/2020/08/26/wrange-loop-analysis/ agrees the warning is wrong. On
Jan 22
Julie Jeongeun Kim
, …
Peter Kasting
7
Jan 18
Proposing google-upgrade-googletest-case
Thanks for the suggestion. It sounds great. I prefer enabling this check and post on the bug. If
unread,
Proposing google-upgrade-googletest-case
Thanks for the suggestion. It sounds great. I prefer enabling this check and post on the bug. If
Jan 18
Jelle Foks
,
Peter Kasting
2
Jan 17
absl::synchronization is banned, but absl::Cord depends on it.
On Wed, Jan 17, 2024 at 8:54 AM 'Jelle Foks' via cxx <c...@chromium.org> wrote: `absl::
unread,
absl::synchronization is banned, but absl::Cord depends on it.
On Wed, Jan 17, 2024 at 8:54 AM 'Jelle Foks' via cxx <c...@chromium.org> wrote: `absl::
Jan 17
