Increasing triage coverage during COVID-19 crisis.

20 views
Skip to first unread message

Johnny Stenback

unread,
Mar 26, 2020, 3:06:48 PM3/26/20
to crblink-...@chromium.org
Hey Blink triage rotation folks,

First off, thank you for all the work that you all already do to ensure Blink bugs find a good home and move forward. Given the situation we are now in, the importance of bug triage is higher than during normal times. I'm proposing we add a step to the Blink triage rotation to also look at bugs that were filed in any Blink component, and any Internals component (I'm open to ideas wrt details of Internals components), to have our triage rotation look at bugs that did not get triaged in the past 7 days.

IOW I'm proposing we add a step to the instructions at https://sites.google.com/a/chromium.org/dev/blink/blink-triaging such that those doing blink triage would also look at bugs that are visible in the following queries (tweaks welcome):



with the intention of ensuring those who should be triaging those bugs are notified about the triage not happening, and if that fails, do at least an initial pass at tirage to help reduce the risk of us shipping regressions that we've been informed about but simply did not see.

I'd be happy to edit the instructions page to reflect this if someone can give me access.

Thoughts?

Thanks,
Johnny

- jstenback (he/him)

Fernando Serboncini

unread,
Mar 26, 2020, 3:33:10 PM3/26/20
to Johnny Stenback, crblink-...@chromium.org
Sounds reasonable to me.

Maybe use modified>today-7 instead of opened>today-7? As it's not unreasonable that a bug may be going back and forth a bit.

--
You received this message because you are subscribed to the Google Groups "Component:Blink bug rotation" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crblink-rotati...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/crblink-rotation/CACZRgz7ygpUU12tAMxiUdra%3Ds%2BnTOG8mfJCo0sz5YYA-Gx_P6w%40mail.gmail.com.

Chris Harrelson

unread,
Mar 26, 2020, 5:51:33 PM3/26/20
to Fernando Serboncini, Johnny Stenback, crblink-...@chromium.org

TAMURA, Kent

unread,
Mar 26, 2020, 10:16:19 PM3/26/20
to Chris Harrelson, Fernando Serboncini, Johnny Stenback, crblink-...@chromium.org
IMO it's great to help to triage such issues.

However, we don't have enough feature knowledge to do "real" triage.  I think we can do the following for such issues:
 - Try to confirm the issue
 - If the issue looks a regression, make sure the type is Bug-Regression, and add Needs-Bisect
 - Fill in the Owner field with the contact person of the component  



--
TAMURA Kent
Software Engineer, Google


Chris Harrelson

unread,
Mar 26, 2020, 10:28:47 PM3/26/20
to TAMURA, Kent, Fernando Serboncini, Johnny Stenback, crblink-...@chromium.org
On Thu, Mar 26, 2020 at 7:16 PM TAMURA, Kent <tk...@chromium.org> wrote:
IMO it's great to help to triage such issues.

However, we don't have enough feature knowledge to do "real" triage.  I think we can do the following for such issues:
 - Try to confirm the issue
 - If the issue looks a regression, make sure the type is Bug-Regression, and add Needs-Bisect
 - Fill in the Owner field with the contact person of the component  

The first two for sure, as well as releaseblock labels if it looks potentially bad. We also need to confirm with the testing team that they will have the bandwidth to perform the bisect after we add Needs-Bisect.

Assigning an owner may be good or may be bad - bad especially if the contact person is not paying attention.

Johnny Stenback

unread,
Mar 27, 2020, 6:23:27 PM3/27/20
to Chris Harrelson, TAMURA, Kent, Fernando Serboncini, crblink-...@chromium.org
Thanks for the feedback everyone. Who can give me edit access to the page so I can start adding suggestions based on the conversations here? I will also dig into the testing team's ability to do bisects etc and report back/incorporate that into the instructions.

I'll also offer to be available to help escallate if we find owners/areas that are unresponsive to this triage, or ones that explicitly don't triage and lay that burden on others here (I've started that work already).


Thanks,
Johnny

- jstenback (he/him)

Chris Harrelson

unread,
Mar 27, 2020, 6:43:45 PM3/27/20
to Johnny Stenback, TAMURA, Kent, Fernando Serboncini, crblink-...@chromium.org

Stephen Chenney

unread,
Mar 30, 2020, 11:17:11 AM3/30/20
to Chris Harrelson, Johnny Stenback, TAMURA, Kent, Fernando Serboncini, crblink-...@chromium.org
On the Core Rendering Team we use the following query for tracking bugs needing triage. I've modified it to be all Blink components:

Component:Blink status=Unconfirmed,Untriaged -has:NextAction OR Component:Blink status=Unconfirmed,Untriaged NextAction<today OR Component:Blink has:Owner ownerlastvisit<today-30 OR component:Blink is:ownerbouncing

In URL form:

There are 1714 or so bugs on this list right now.

Instead of "-Needs-Feedback" we use "-has:NextAction" because we insist that a NextAction date be defined for every bug requiring feedback or otherwise prevented from making triage progress. This ensures bugs requiring feedback do not get lost, as has happened to us in the past with significant regressions (this approach to triage came out of a post-mortem).

Generally we use 28 days for Needs-Feedback and 7 days for "Needs-Bisect". We also put NextAction on bugs with multiple components where we are asking for feedback from another team.

A side effect of the NextAction date with the query above is that it provides a consistent way to temporarily move bugs out of the needs-triage query while ensuring they come back again if no action is taken.

Regarding assigning owners, I would prefer CC'ing people, explicitly asking a question in the comments, and adding NextAction to follow up if they do not answer.

Cheers,
Stephen.

Johnny Stenback

unread,
Apr 3, 2020, 4:02:05 PM4/3/20
to Stephen Chenney, Chris Harrelson, TAMURA, Kent, Fernando Serboncini, crblink-...@chromium.org
Hey everyone,

I took a first stab at this in the instructions. I ended up keeping the query fairly simple in the interest of not letting perfect be the enemy of good, and being fairly loose in what we expect people to do. We obviously can, and will, adjust these queries if they in the end don't end up being meaningful. I listed myself as a contact person for cases where it's not clear what to do. I'm eager to hear people's feedback as they work through this, which I'll be doing on Monday and Tuesday next week myself.

Please do let me know how this goes for you all!

- jstenback (he/him)

Johnny Stenback

unread,
Apr 8, 2020, 10:58:10 AM4/8/20
to Stephen Chenney, Chris Harrelson, TAMURA, Kent, Fernando Serboncini, crblink-...@chromium.org
Hey everyone,

I spent a chunk of time on this triage over the past couple of days and immediately found a couple of cases that really stood out. I'll be digging into those cases myself (media, graphics, and network) so I excluded those components from the queries in the examples. Please proceed per the instructions and use said queries.

Thanks!
Johnny

- jstenback (he/him)

Reply all
Reply to author
Forward
0 new messages