win: fix nullptr reference in CleanDatabase() [crashpad/crashpad : main]

6 views

Skip to first unread message

Sorin Jianu (Gerrit)

unread,

Nov 13, 2025, 10:42:26 AMNov 13

to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Sorin Jianu voted and added 2 comments

Votes added by Sorin Jianu

Commit-Queue

2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Sorin Jianu . resolved

thank you!

Commit Message

Line 7, Patchset 1:crashpad: fix nullptr reference in CleanDatabase()

Mark Mentovai . resolved

In the Crashpad repository, a “crashpad:” prefix doesn’t make any sense.
The crash affects only the Windows database, so you could write “win:” or nothing at all.

Sorin Jianu

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Crashpad LUCI CQ (Gerrit)

unread,

Nov 13, 2025, 10:42:35 AMNov 13

to Sorin Jianu, Mark Mentovai, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

win: fix nullptr reference in CleanDatabase()

Bug: 441654963

Change-Id: I330aecc68fccdb9fdf537f31d48ed1a4dc99c2d5

Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/7148744

Reviewed-by: Mark Mentovai <ma...@chromium.org>

Commit-Queue: Sorin Jianu <so...@chromium.org>

Files:

M client/crash_report_database_win.cc

Change size: XS

Delta: 1 file changed, 3 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mark Mentovai

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages