Replace std::unique_ptr with base::HeapArray in process_memory.cc [crashpad/crashpad : main]

2 views
Skip to first unread message

Arthur Wang (Gerrit)

unread,
May 13, 2024, 5:18:35 PMMay 13
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai

Arthur Wang voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ic5e252285ed1fb1769eef67ddaea00a830d0ee6a
Gerrit-Change-Number: 5535006
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Mon, 13 May 2024 21:18:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 13, 2024, 8:06:24 PMMay 13
to Arthur Wang, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Arthur Wang

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Wang
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ic5e252285ed1fb1769eef67ddaea00a830d0ee6a
Gerrit-Change-Number: 5535006
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Arthur Wang <wuw...@chromium.org>
Gerrit-Comment-Date: Tue, 14 May 2024 00:06:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Arthur Wang (Gerrit)

unread,
May 13, 2024, 8:07:02 PMMay 13
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Arthur Wang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ic5e252285ed1fb1769eef67ddaea00a830d0ee6a
Gerrit-Change-Number: 5535006
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 14 May 2024 00:06:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
May 13, 2024, 8:07:09 PMMay 13
to Arthur Wang, Mark Mentovai, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
Replace std::unique_ptr with base::HeapArray in process_memory.cc
Bug: crashpad:326459219
Change-Id: Ic5e252285ed1fb1769eef67ddaea00a830d0ee6a
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Arthur Wang <wuw...@chromium.org>
Files:
  • M snapshot/mac/process_types.cc
Change size: XS
Delta: 1 file changed, 4 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ic5e252285ed1fb1769eef67ddaea00a830d0ee6a
Gerrit-Change-Number: 5535006
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages