Fix Fuchsia build [crashpad/crashpad : main]

9 views
Skip to first unread message

Joshua Peraza (Gerrit)

unread,
Aug 15, 2025, 6:17:08 PMAug 15
to Thomas Gales, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Thomas Gales

Joshua Peraza voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Gales
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ia54a4391d705e9360ccdfee42dbed76c12260b77
Gerrit-Change-Number: 6854524
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Thomas Gales <tga...@google.com>
Gerrit-Attention: Thomas Gales <tga...@google.com>
Gerrit-Comment-Date: Fri, 15 Aug 2025 22:17:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Gales (Gerrit)

unread,
Aug 15, 2025, 6:18:40 PMAug 15
to Mark Mentovai, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai

Thomas Gales added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Thomas Gales . resolved

Requires two +1's

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ia54a4391d705e9360ccdfee42dbed76c12260b77
Gerrit-Change-Number: 6854524
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Thomas Gales <tga...@google.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Fri, 15 Aug 2025 22:18:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Aug 15, 2025, 7:15:19 PMAug 15
to Thomas Gales, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Thomas Gales

Mark Mentovai added 1 comment

File snapshot/minidump/module_snapshot_minidump.cc
Line 19, Patchset 2 (Latest):#include <iterator>
Mark Mentovai . unresolved

Blank line before this. C and C++ headers go in distinct sections.

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Gales
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia54a4391d705e9360ccdfee42dbed76c12260b77
    Gerrit-Change-Number: 6854524
    Gerrit-PatchSet: 2
    Gerrit-Owner: Thomas Gales <tga...@google.com>
    Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Thomas Gales <tga...@google.com>
    Gerrit-Attention: Thomas Gales <tga...@google.com>
    Gerrit-Comment-Date: Fri, 15 Aug 2025 23:15:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Thomas Gales (Gerrit)

    unread,
    Aug 18, 2025, 1:12:05 PMAug 18
    to Mark Mentovai, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
    Attention needed from Joshua Peraza and Mark Mentovai

    Thomas Gales added 1 comment

    File snapshot/minidump/module_snapshot_minidump.cc
    Line 19, Patchset 2:#include <iterator>
    Mark Mentovai . resolved

    Blank line before this. C and C++ headers go in distinct sections.

    Thomas Gales

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Joshua Peraza
    • Mark Mentovai
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia54a4391d705e9360ccdfee42dbed76c12260b77
    Gerrit-Change-Number: 6854524
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Gales <tga...@google.com>
    Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Thomas Gales <tga...@google.com>
    Gerrit-Attention: Joshua Peraza <jpe...@chromium.org>
    Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 Aug 2025 17:12:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mark Mentovai (Gerrit)

    unread,
    Aug 18, 2025, 2:14:36 PMAug 18
    to Thomas Gales, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
    Attention needed from Joshua Peraza and Thomas Gales

    Mark Mentovai voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Joshua Peraza
    • Thomas Gales
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia54a4391d705e9360ccdfee42dbed76c12260b77
    Gerrit-Change-Number: 6854524
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Gales <tga...@google.com>
    Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Thomas Gales <tga...@google.com>
    Gerrit-Attention: Joshua Peraza <jpe...@chromium.org>
    Gerrit-Attention: Thomas Gales <tga...@google.com>
    Gerrit-Comment-Date: Mon, 18 Aug 2025 18:14:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Thomas Gales (Gerrit)

    unread,
    Aug 20, 2025, 1:18:42 PMAug 20
    to Mark Mentovai, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
    Attention needed from Joshua Peraza

    Thomas Gales added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Thomas Gales . resolved

    Hey Joshua, unfortunately your +1 got outdated because I uploaded a new patch set

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Joshua Peraza
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia54a4391d705e9360ccdfee42dbed76c12260b77
    Gerrit-Change-Number: 6854524
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Gales <tga...@google.com>
    Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Thomas Gales <tga...@google.com>
    Gerrit-Attention: Joshua Peraza <jpe...@chromium.org>
    Gerrit-Comment-Date: Wed, 20 Aug 2025 17:18:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joshua Peraza (Gerrit)

    unread,
    Aug 20, 2025, 1:20:44 PMAug 20
    to Thomas Gales, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
    Attention needed from Thomas Gales

    Joshua Peraza voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Thomas Gales
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia54a4391d705e9360ccdfee42dbed76c12260b77
    Gerrit-Change-Number: 6854524
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Gales <tga...@google.com>
    Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Thomas Gales <tga...@google.com>
    Gerrit-Attention: Thomas Gales <tga...@google.com>
    Gerrit-Comment-Date: Wed, 20 Aug 2025 17:20:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Thomas Gales (Gerrit)

    unread,
    Aug 20, 2025, 1:24:12 PMAug 20
    to Joshua Peraza, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

    Thomas Gales voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia54a4391d705e9360ccdfee42dbed76c12260b77
    Gerrit-Change-Number: 6854524
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Gales <tga...@google.com>
    Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Thomas Gales <tga...@google.com>
    Gerrit-Comment-Date: Wed, 20 Aug 2025 17:24:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Crashpad LUCI CQ (Gerrit)

    unread,
    Aug 20, 2025, 1:33:56 PMAug 20
    to Thomas Gales, Joshua Peraza, Mark Mentovai, crashp...@chromium.org

    Crashpad LUCI CQ submitted the change

    Change information

    Commit message:
    Fix Fuchsia build
    Bug: 40506050
    Fixed: 439063162
    Change-Id: Ia54a4391d705e9360ccdfee42dbed76c12260b77
    Reviewed-by: Mark Mentovai <ma...@chromium.org>
    Reviewed-by: Joshua Peraza <jpe...@chromium.org>
    Commit-Queue: Thomas Gales <tga...@google.com>
    Files:
    • M snapshot/minidump/module_snapshot_minidump.cc
    Change size: XS
    Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Joshua Peraza, +1 by Mark Mentovai
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia54a4391d705e9360ccdfee42dbed76c12260b77
    Gerrit-Change-Number: 6854524
    Gerrit-PatchSet: 4
    Gerrit-Owner: Thomas Gales <tga...@google.com>
    Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages